[PATCH v6 03/20] libtasn1: disable code not needed in grub

2023-10-03 Thread Gary Lin via Grub-devel
From: Daniel Axtens We don't expect to be able to write ASN.1, only read it, so we can disable some code. Do that with #if 0/#endif, rather than deletion. This means that the difference between upstream and grub is smaller, which should make updating libtasn1 easier in the future. With these ex

[PATCH v6 05/20] libtasn1: compile into asn1 module

2023-10-03 Thread Gary Lin via Grub-devel
From: Daniel Axtens Create a wrapper file that specifies the module license. Set up the makefile so it is built. Signed-off-by: Daniel Axtens Signed-off-by: Gary Lin --- grub-core/Makefile.core.def| 15 +++ grub-core/lib/libtasn1_wrap/wrap.c | 26 ++

[PATCH v6 11/20] cryptodisk: Support key protectors

2023-10-03 Thread Gary Lin via Grub-devel
From: Hernan Gatta Add a new parameter to cryptomount to support the key protectors framework: -P. The parameter is used to automatically retrieve a key from specified key protectors. The parameter may be repeated to specify any number of key protectors. These are tried in order until one provide

[PATCH v6 10/20] protectors: Add TPM2 Key Protector

2023-10-03 Thread Gary Lin via Grub-devel
From: Hernan Gatta The TPM2 key protector is a module that enables the automatic retrieval of a fully-encrypted disk's unlocking key from a TPM 2.0. The theory of operation is such that the module accepts various arguments, most of which are optional and therefore possess reasonable defaults. On

[PATCH v6 14/20] tpm2: Add more marshal/unmarshal functions

2023-10-03 Thread Gary Lin via Grub-devel
Add a few more marshal/unmarshal functions to support authorized policy. * Marshal: grub_tpm2_mu_TPMU_SENSITIVE_COMPOSITE_Marshal() grub_tpm2_mu_TPMT_SENSITIVE_Marshal() grub_tpm2_mu_TPM2B_SENSITIVE_Marshal() grub_tpm2_mu_TPMS_SIGNATURE_RSA_Marshal() grub_tpm2_mu_TPMS_SIGNATURE_ECC_Marsh

[PATCH v6 17/20] protectors: Implement NV index

2023-10-03 Thread Gary Lin via Grub-devel
From: Patrick Colp Currently with the TPM2 protector, only SRK mode is supported and NV index support is just a stub. Implement the NV index option. Note: This only extends support on the unseal path. grub2_protect has not been updated. tpm2-tools can be used to insert a key into the NV index.

[PATCH v6 01/20] posix_wrap: tweaks in preparation for libtasn1

2023-10-03 Thread Gary Lin via Grub-devel
From: Daniel Axtens - Define SIZEOF_UNSIGNED_LONG_INT, it's the same as SIZEOF_UNSIGNED_LONG. - Define WORD_BIT, the size in bits of an int. This is a defined in the Single Unix Specification and in gnulib's limits.h. gnulib assumes it's 32 bits on all our platforms, including 64 bit

[PATCH v6 08/20] protectors: Add key protectors framework

2023-10-03 Thread Gary Lin via Grub-devel
From: Hernan Gatta A key protector encapsulates functionality to retrieve an unlocking key for a fully-encrypted disk from a specific source. A key protector module registers itself with the key protectors framework when it is loaded and unregisters when unloaded. Additionally, a key protector ma

[PATCH v6 13/20] tpm2: Add TPM2 types, structures, and command constants

2023-10-03 Thread Gary Lin via Grub-devel
Add new TPM2 types and structures as the preparation to support authorized policy. * New types: TPM_ALG_ECDAA, TPM_ALG_ECDSA, TPM_ALG_ECSCHNORR, TPM_ALG_RSASSA, TPM_ALG_RSAPSS, TPM_ALG_SM2, and TPMI_ALG_SIG_SCHEME * New structures: TPMS_EMPTY, TPMS_SIGNATURE_RSA, TPMS_SIGNATURE_ECC, TPMS_

[PATCH v6 12/20] util/grub-protect: Add new tool

2023-10-03 Thread Gary Lin via Grub-devel
From: Hernan Gatta To utilize the key protectors framework, there must be a way to protect full-disk encryption keys in the first place. The grub-protect tool includes support for the TPM2 key protector but other protectors that require setup ahead of time can be supported in the future. For the

[PATCH v6 07/20] libtasn1: Add the documentation

2023-10-03 Thread Gary Lin via Grub-devel
Document libtasn1 in docs/grub-dev.texi and add the upgrade steps. Also add the patches to make libtasn1 compatible with grub code. Signed-off-by: Gary Lin --- docs/grub-dev.texi| 27 ++ ...asn1-disable-code-not-needed-in-grub.patch | 311 ++ ...tasn1

[PATCH v6 16/20] tpm2: Support authorized policy

2023-10-03 Thread Gary Lin via Grub-devel
This commit handles the TPM2_PolicyAuthorize command from the key file in TPM 2.0 Key File format. TPM2_PolicyAuthorize is the essential command to support authorized policy which allows the users to sign TPM policies with their own keys. Per TPM 2.0 Key File(*1), CommandPolicy for TPM2_PolicyAuth

[PATCH v6 19/20] cryptodisk: wipe out the cached keys from protectors

2023-10-03 Thread Gary Lin via Grub-devel
An attacker may insert a malicious disk with the same crypto UUID and trick grub2 to mount the fake root. Even though the key from the key protector fails to unlock the fake root, it's not wiped out cleanly so the attacker could dump the memory to retrieve the secret key. To defend such attack, wip

[PATCH v6 04/20] libtasn1: changes for grub compatibility

2023-10-03 Thread Gary Lin via Grub-devel
From: Daniel Axtens Do a few things to make libtasn1 compile as part of grub: - redefine _asn1_strcat. grub removed strcat so replace it with the appropriate calls to memcpy and strlen. Use this internally where strcat was used. - replace c_isdigit with grub_isdigit (and don't import c-

[PATCH v6 18/20] cryptodisk: Fallback to passphrase

2023-10-03 Thread Gary Lin via Grub-devel
From: Patrick Colp If a protector is specified, but it fails to unlock the disk, fall back to asking for the passphrase. However, an error was set indicating that the protector(s) failed. Later code (e.g., LUKS code) fails as `grub_errno` is now set. Print the existing errors out first, before pr

[PATCH v6 20/20] diskfilter: look up cryptodisk devices first

2023-10-03 Thread Gary Lin via Grub-devel
When using disk auto-unlocking with TPM 2.0, the typical grub.cfg may look like this: tpm2_key_protector_init --tpm2key=(hd0,gpt1)/boot/grub2/sealed.tpm cryptomount -u -P tpm2 search --fs-uuid --set=root Since the disk search order is based on the order of module loading, the attacker cou

[PATCH v6 15/20] tpm2: Implement more TPM2 commands

2023-10-03 Thread Gary Lin via Grub-devel
This commit implements a few more TPM2 commands as the preparation for the authorized policy support. * TPM2_LoadExternal This command is added to load the external public key to verify the signed policy digest * TPM2_HashSequenceStart, TPM2_SequenceUpdate, TPM2_SequenceComplete, and TPM2_Ha

[PATCH v6 00/20] Automatic Disk Unlock with TPM2

2023-10-03 Thread Gary Lin via Grub-devel
GIT repo for v6: https://github.com/lcp/grub2/tree/tpm2-unlock-v6 This patch series is based on "Automatic TPM Disk Unlock"(*1) posted by Hernan Gatta to introduce the key protector framework and TPM2 stack to GRUB2, and this could be a useful feature for the systems to implement full disk encrypt

Re: [PATCH] kern/ieee1275/init: ppc64: Restrict high memory in presence of fadump

2023-10-03 Thread Daniel Kiper
On Wed, Aug 02, 2023 at 11:48:18AM -0400, Stefan Berger wrote: > When a kernel dump is present then restrict the high memory regions to > avoid allocating memory where the kernel dump resides. Use the > ibm,kernel-dump node under /rtas to determine whether a kernel dump exists > and up to which lim

[SECURITY PATCH 0/6] GRUB2 NTFS driver vulnerabilities - 2023/10/03

2023-10-03 Thread Daniel Kiper
Hi all, This patch set contains a bundle of fixes for various security flaws discovered in the GRUB2 NTFS driver code recently. The most severe ones, i.e. potentially exploitable, have CVEs assigned and are listed at the end of this email. Details of exactly what needs updating will be provided b

[SECURITY PATCH 2/6] fs/ntfs: Fix an OOB read when reading data from the resident $DATA attribute

2023-10-03 Thread Daniel Kiper
From: Maxim Suhanov When reading a file containing resident data, i.e., the file data is stored in the $DATA attribute within the NTFS file record, not in external clusters, there are no checks that this resident data actually fits the corresponding file record segment. When parsing a specially-

[SECURITY PATCH 4/6] fs/ntfs: Fix an OOB read when parsing bitmaps for index attributes

2023-10-03 Thread Daniel Kiper
From: Maxim Suhanov This fix introduces checks to ensure that bitmaps for directory indices are never read beyond their actual sizes. The lack of this check is a minor issue, likely not exploitable in any way. Reported-by: Maxim Suhanov Signed-off-by: Maxim Suhanov Reviewed-by: Daniel Kiper

[SECURITY PATCH 3/6] fs/ntfs: Fix an OOB read when parsing directory entries from resident and non-resident index attributes

2023-10-03 Thread Daniel Kiper
From: Maxim Suhanov This fix introduces checks to ensure that index entries are never read beyond the corresponding directory index. The lack of this check is a minor issue, likely not exploitable in any way. Reported-by: Maxim Suhanov Signed-off-by: Maxim Suhanov Reviewed-by: Daniel Kiper -

[SECURITY PATCH 1/6] fs/ntfs: Fix an OOB write when parsing the $ATTRIBUTE_LIST attribute for the $MFT file

2023-10-03 Thread Daniel Kiper
From: Maxim Suhanov When parsing an extremely fragmented $MFT file, i.e., the file described using the $ATTRIBUTE_LIST attribute, current NTFS code will reuse a buffer containing bytes read from the underlying drive to store sector numbers, which are consumed later to read data from these sectors

[SECURITY PATCH 5/6] fs/ntfs: Fix an OOB read when parsing a volume label

2023-10-03 Thread Daniel Kiper
From: Maxim Suhanov This fix introduces checks to ensure that an NTFS volume label is always read from the corresponding file record segment. The current NTFS code allows the volume label string to be read from an arbitrary, attacker-chosen memory location. However, the bytes read are always tre

[SECURITY PATCH 6/6] fs/ntfs: Make code more readable

2023-10-03 Thread Daniel Kiper
From: Maxim Suhanov Move some calls used to access NTFS attribute header fields into functions with human-readable names. Suggested-by: Daniel Kiper Signed-off-by: Maxim Suhanov Reviewed-by: Daniel Kiper --- grub-core/fs/ntfs.c | 48 +--- 1 file ch

Re: [PATCH v3] Fix XFS directory extent parsing

2023-10-03 Thread Lidong Chen
On Sep 27, 2023, at 5:43 PM, Jon DeVree wrote: The XFS directory entry parsing code has never been completely correct for extent based directories. The parser correctly handles the case where the directory is contained in a single extent, but then mistakenly assumes the data blocks for the mult