Re: [PATCH v12 20/20] tests: Add tpm2_test

On Fri, Apr 19, 2024 at 09:12:00AM -0400, Stefan Berger wrote: > > > On 4/19/24 04:31, Gary Lin via Grub-devel wrote: > > For the tpm2 module, the TCG2 command submission function is the only > > difference between the a QEMU instance and grub-emu. To test TPM key > > unsealing with a QEMU instan

Re: [PATCH v12 11/20] key_protector: Add TPM2 Key Protector

On Fri, Apr 19, 2024 at 08:23:44AM -0400, James Bottomley wrote: > On Fri, 2024-04-19 at 16:30 +0800, Gary Lin wrote: > >    TPMKey ::= SEQUENCE { > > type    OBJECT IDENTIFIER > > emptyAuth   [0] EXPLICIT BOOLEAN OPTIONAL > > policy  [1] EXPLICIT SEQUENCE OF TPMPolicy OPTION

[PATCH] efi: mm: Fix incorrect free size

From: Zhou JianFeng Memory freed by function grub_efi_free_pages() with wrong pages will not be removed from list efi_allocated_memory by function grub_efi_drop_alloc(), it will be freed again by function grub_efi_memory_fini() which is called by function grub_machine_fini()/grub_exit() when exit

Re: [PATCH v2] cryptodisk: allow the user to retry failed passphrases

On Mon, Apr 22, 2024 at 1:48 PM Forest wrote: > On Sun, 07 Apr 2024 14:52:32 -0700, Forest wrote: > > >Changes since last rev: > >- replace some spaces with tabs > >- better explain the clearing of grub_errno > >- let an environment variable override the number of passphrase tries > > As a new co

Re: [PATCH v2] cryptodisk: allow the user to retry failed passphrases

On Sun, 07 Apr 2024 14:52:32 -0700, Forest wrote: >Changes since last rev: >- replace some spaces with tabs >- better explain the clearing of grub_errno >- let an environment variable override the number of passphrase tries As a new contributor, is there something I should do to ensure my patch i

Re: [PATCH 1/2] Allow "fallback" to include entries by title, not just number.

Selecting by title is deprecated and kept only for compatibility. Please use id instead Le lun. 22 avr. 2024, 17:56, Marek Marczykowski-Górecki < marma...@invisiblethingslab.com> a écrit : > From: Peter Jones > > Resolves: rhbz#1026084 > > Signed-off-by: Peter Jones > --- > grub-core/normal/me

Re: [PATCH 2/2] Fix menu entry selection based on ID and title

I'm unsure whether an id starting with a numeral should be considered valid at all. Variable named 0x would be incorrect Le lun. 22 avr. 2024, 17:57, Marek Marczykowski-Górecki < marma...@invisiblethingslab.com> a écrit : > From: Peter Jones > > Currently if grub_strtoul(saved_entry_value, NULL,

[PATCH 2/2] Fix menu entry selection based on ID and title

From: Peter Jones Currently if grub_strtoul(saved_entry_value, NULL, 0) does not return an error, we assume the value it has produced is a correct index into our menu entry list, and do not try to interpret the value as the "id" or "title" . In cases where "id" or "title" start with a numeral, t

[PATCH 0/2] Two patches related to menu entries selection

Those are two patches from Fedora's grub package that are related to menu titles handling. I hope submiting them this way is okay and will help bringing Fedora and upstream grub versions together. See individual commit messages for details. Peter Jones (2): Allow "fallback" to include entries by

[PATCH 1/2] Allow "fallback" to include entries by title, not just number.

From: Peter Jones Resolves: rhbz#1026084 Signed-off-by: Peter Jones --- grub-core/normal/menu.c | 85 -- 1 file changed, 58 insertions(+), 27 deletions(-) diff --git a/grub-core/normal/menu.c b/grub-core/normal/menu.c index 6a90e09..6444ee6 100644 --- a