Re: [PATCH v8 0/2] Introduce EROFS support

2024-05-01 Thread Yifan Zhao
On 5/1/24 9:22 PM, Daniel Axtens wrote: Hi, Could you help have another look at this latest version? Is it ready for merging (Yifan has been working on for almost one year in his leisure time) so that kernel/initrd can be loaded then.. Any comment would be much helpful. I am doing this in

Re: [PATCH v8 1/2] fs/erofs: Add support for EROFS

2024-05-01 Thread Yifan Zhao
On 4/29/24 10:15 PM, Vladimir 'phcoder' Serbinenko wrote: Generally looks good. Few comments. I have missed part of discussion, so point me to relevant parts of it if I miss something that's already been discussed Le mer. 24 avr. 2024, 14:31, Yifan Zhao a écrit : De qq, + struct grub_e

Re: [PATCH v2] util/grub.d/30_os-prober.in: Conditionally show or hide chain and efi menu entries

2024-05-01 Thread Pascal Hambourg
Any feedback on this ? On 19/01/2024 at 16:25, Pascal Hambourg wrote: On systems which support multiple boot platforms such as BIOS or EFI, it makes no sense to show menu entries which are not supported by the current boot platform. Menu entries generated from os-prober 'chain' boot type use boo

Re: [PATCH] util/grub.d/30_os-prober.in: Fix GRUB_OS_PROBER_SKIP_LIST for non-EFI

2024-05-01 Thread Pascal Hambourg
On 27/04/2024 at 08:32, Glenn Washburn wrote: On Fri, 19 Jan 2024 11:28:55 +0100 Pascal Hambourg wrote: GRUB documentation states: 'GRUB_OS_PROBER_SKIP_LIST' List of space-separated FS UUIDs of filesystems to be ignored from os-prober output. For efi chainloaders it's @ But the actual

Re: [PATCH v8 0/2] Introduce EROFS support

2024-05-01 Thread Daniel Axtens
Hi, > > Could you help have another look at this latest version? > Is it ready for merging (Yifan has been working on for almost one year > in his leisure time) so that kernel/initrd can be loaded then.. > Any comment would be much helpful. > I am doing this in my leisure time too - I appreciat

Re: [PATCH v8 1/2] fs/erofs: Add support for EROFS

2024-05-01 Thread Vladimir 'phcoder' Serbinenko
On Tue, Apr 30, 2024 at 4:27 PM Yifan Zhao wrote: > > >> + err = grub_disk_read (disk, EROFS_SUPER_OFFSET >> GRUB_DISK_SECTOR_BITS, >> 0, >> + sizeof (sb), &sb); >> + if (grub_errno == GRUB_ERR_OUT_OF_RANGE) >> +grub_error (GRUB_ERR_BAD_FS, "not a valid erofs filesyste