[PATCH v5] cryptodisk: allow user to retry failed passphrase

2024-05-06 Thread Forest
Give the user a chance to re-enter their cryptodisk passphrase after a typo, rather than immediately failing (and likely dumping them into a grub shell). By default, we allow 3 tries before giving up. A value in the cryptodisk_passphrase_tries environment variable will override this default. The

Re: [PATCH v4] cryptodisk: allow user to retry failed passphrase

2024-05-06 Thread Forest
On Mon, 6 May 2024 20:22:48 +0200, Daniel Kiper wrote: >You can make this check much simpler. Please take a look at the commit >ac8a37dda (net/http: Allow use of non-standard TCP/IP ports). I did it that way in order to preserve a feature of Glenn's suggested approach: passing through any

[PATCH] lvm: Grub2 fails to detect LVM volumes due to an incorrect computation of mda_end

2024-05-06 Thread Glenn Washburn
From: Rogier When handling a regular LVM volume, Grub can fail with the message: error: disk `lvmid/**------ /**------**' not found. If the condition which triggers this exists, grub-probe will report the error mentioned above. Similarly,

Re: bug #61620: Grub2 fails to detect LVM volumes with: error: disk `lvmid/*/*' not found

2024-05-06 Thread Glenn Washburn
On Thu, 2 May 2024 18:40:16 +0200 Horst Prote wrote: > On 26.04.2024, Glenn Washburn wrote: > > > On Wed, 3 Apr 2024 10:23:59 +0200 > > Horst Prote wrote: > > > > > Hi, > > > > > > could the patch supplied in bug #61620 > > > (https://savannah.gnu.org/bugs/?func=detailitem_id=61620) please

Re: [PATCH v14 20/20] tests: Add tpm2_test

2024-05-06 Thread Glenn Washburn
On Fri, 3 May 2024 14:48:56 +0800 Gary Lin wrote: > For the tpm2 module, the TCG2 command submission function is the only > difference between the a QEMU instance and grub-emu. To test TPM key > unsealing with a QEMU instance, it requires an extra OS image to invoke > grub-protect to seal the

Re: [PATCH] disk/mdraid1x_linux: Prevent infinite recursion

2024-05-06 Thread Daniel Kiper via Grub-devel
On Mon, Apr 29, 2024 at 04:38:03PM +, Lidong Chen wrote: > The test corpus for version-1 RAID generated an infinite recursion > in grub_partition_iterate() while attempting to read the superblock. > The reason for the issue was that the data region overlapped with > the superblock. > > The

Re: [PATCH v4] cryptodisk: allow user to retry failed passphrase

2024-05-06 Thread Daniel Kiper via Grub-devel
On Sat, Apr 27, 2024 at 05:48:31PM -0700, Forest wrote: > Give the user a chance to re-enter their cryptodisk passphrase after a typo, > rather than immediately failing (and likely dumping them into a grub shell). > > By default, we allow 3 tries before giving up. A value in the >