[PATCH] tests: Switch to requiring exfatprogs from exfat-utils

2024-06-08 Thread Glenn Washburn
The current Debian stable, now 12, has dropped the exfat-utils package that the exfat filesystem test requires to run. There is an exfatprogs package that replaces exfat-utils, though it is not a drop-in replacement because mkfs.exfat has differing command line option names. Note, that we're not

[PATCH] tests/util/grub-shell-luks-tester: Fix detached header test getting wrong header path

2024-06-08 Thread Glenn Washburn
When $detached_header was set 1, $luksdiskfile was set to the luks header file path with "${detached_header:-$luksfile}" appended, which evaluates to "1". Fix this by using two statements to set $luksdiskfile. The first sets it to the header file if $detached_header is set, otherwise leave it

[PATCH 2/2] tests/util/grub-shell: Add flexibility in QEMU firmware handling

2024-06-08 Thread Glenn Washburn
First look for firmware files in the source directory and then, if not found, look for them in locations where Debian installs them. Prefer to use the unified firmware file and, if not found, use the pflash firmware files split in to code and variables. By looking for files in the source directory

[PATCH 1/2] tests/util/grub-shell: Use pflash instead of -bios to load UEFI firmware

2024-06-08 Thread Glenn Washburn
According to the OVMF whitepaper[1]: IMPORTANT: Never pass OVMF.fd to qemu with the -bios option. That option maps the firmware image as ROM into the guest's address space, and forces OVMF to emulate non-volatile variables with a fallback driver that is bound to have insufficient and

[PATCH 0/2] Better UEFI firmware handling in tests

2024-06-08 Thread Glenn Washburn
The first patch moves away from using -bios which appears to be a best practice. And the second patch allows the firmware to be found in the source directory or system directory, in case the tester does not want to use system firmwares or is not on a Debian system. Glenn Glenn Washburn (2):

[PATCH] tests/util/grub-shell: Print gdbinfo if on EFI platform

2024-06-08 Thread Glenn Washburn
Allow using GDB to debug a failing QEMU test. This output does not cause issues for tests because it happens before the trim line, and so will be ignored. Signed-off-by: Glenn Washburn --- tests/util/grub-shell.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/util/grub-shell.in

[PATCH] configure: Add Debian/Ubuntu dejavu font path

2024-06-08 Thread Glenn Washburn
Signed-off-by: Glenn Washburn --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 99aae8700d72..d4a14bf937e1 100644 --- a/configure.ac +++ b/configure.ac @@ -1847,7 +1847,7 @@ if test "x$with_dejavufont" = x; then # search in

[PATCH v2 3/3] commands/ls: Proper line breaks between arguments

2024-06-08 Thread Glenn Washburn
There should be a blank line before each directory argument and before each file arugment that come after a directory argument. This brings the ls command more inline with GNU's ls. Although one key difference still is that GNU's ls reorders the output of arguments so that all file arguments are

[PATCH v2 1/3] commands/ls: Allow printing mtime for file arguments

2024-06-08 Thread Glenn Washburn
File arguments were processed differently than files listed from directory arguments. A side effect of this was that mtime was not shown for file arguments when long listing was enabled. Refactor to have the same code path for printing files that are arguments and ones that are contained in

[PATCH v2 2/3] commands/ls: Add directory header for dir args and print full paths for file args

2024-06-08 Thread Glenn Washburn
Like the GNU ls first print a line with the directory path before printing files in the directory, which will not have a directory component, but only if there is more than one argument. Also, for arguments that are paths to files, print the full path of the file. Signed-off-by: Glenn Washburn

[PATCH v2 0/3] More ls improvements

2024-06-08 Thread Glenn Washburn
Currently when given a path to a file, ls will open the file to determine if its is valid and then run the appropriate print function, in contrast to directory arguments that use the directory iterator and callback on each file. One issue with this is that opening a file does not allow access to

Re: [PATCH] term/ns8250-spcr: Add one more 16550 debug type.

2024-06-08 Thread Glenn Washburn
On Fri, 7 Jun 2024 23:57:14 +0200 Udo Steinberg wrote: > Hi all, > > below is a patch for picking up the correct UART address from the ACPI SPCR > table on modern AWS bare-metal instances. > > CC: Benjamin and Glenn for review. > > Cheers, > Udo LGTM for the changes itself. I don't think you