Re: [PATCH 0/3 v8] LVM Cachevol and Integrity volumes break entire LVM VG

2024-09-16 Thread Patrick Plenefisch
Hello, I'd love to get this latest version reviewed at some point Thanks, Patrick On Tue, Aug 13, 2024 at 8:50 PM Patrick Plenefisch wrote: > > In an effort to solve > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061168 for myself, > I implemented basic support for cachevol and integrity

Re: [PATCH 04/24] i386/memory: Rename PAGE_SHIFT to GRUB_PAGE_SHIFT

2024-09-16 Thread Ross Philipson via Grub-devel
On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Daniel Kiper ...to avoid potential conflicts and confusion. Please fix these commit messages to be complete and not use the ellipsis to reference the short description. Thanks Ross Signed-off-by: Daniel Kiper --- grub-core/lib/i386/xen/

Re: [PATCH 03/24] i386/msr: Extract and improve MSR support detection code

2024-09-16 Thread Ross Philipson via Grub-devel
On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Daniel Kiper Currently rdmsr and wrmsr commands have own MSR support detection code. This code is the same. So, it is duplicated. Additionally, this code cannot be reused by others. Hence, extract this code to a function and make it public. By the

Re: [PATCH 02/24] i386/msr: Rename grub_msr_read() and grub_msr_write()

2024-09-16 Thread Ross Philipson via Grub-devel
On 8/26/24 5:44 AM, Sergii Dmytruk wrote: From: Daniel Kiper ... to grub_rdmsr() and grub_wrmsr() respectively. New names are more obvious than older ones. This patch needs its commit message fixed to remove the ellipsis and just make it a complete sentence. Also since you are not the auth

Re: [PATCH v19 00/33] Automatic Disk Unlock with TPM2

2024-09-16 Thread Stefan Berger
On 9/15/24 11:35 PM, Gary Lin wrote: On Mon, Sep 16, 2024 at 10:24:03AM +0800, Gary Lin wrote: On Fri, Sep 13, 2024 at 10:32:39AM -0400, Stefan Berger wrote: On 9/6/24 5:10 AM, Gary Lin wrote: GIT repo for v19: https://github.com/lcp/grub2/tree/tpm2-unlock-v19 This patch series is based o

Re: [PATCH] kern/fs: honour file->read_hook in grub_fs_blocklist_read()

2024-09-16 Thread Vladimir 'phcoder' Serbinenko
Reviewed-by: phco...@gmail.com Le jeu. 29 août 2024, 14:07, Rasmus Villemoes via Grub-devel < grub-devel@gnu.org> a écrit : > Unlike files accessed via a normal file system, the file->read_hook is > not honoured when using blocklist notation. > > This means that when trying to use a dedicated, 1K

Re: [PATCH] kern/fs: honour file->read_hook in grub_fs_blocklist_read()

2024-09-16 Thread Rasmus Villemoes via Grub-devel
Rasmus Villemoes writes: > Unlike files accessed via a normal file system, the file->read_hook is > not honoured when using blocklist notation. > > This means that when trying to use a dedicated, 1KiB, raw partition > for the environment block and hence does something like > > save_env --file=(