On 9/19/24 3:02 PM, Sergii Dmytruk wrote:
From: Daniel Kiper
The functions calculate lowest and highest available RAM
addresses respectively.
It seems that the functions do a bit more than this. They find the
lowest and highest values wrt to the limit you pass in. In the case of
passing a l
On 9/19/24 3:02 PM, Sergii Dmytruk wrote:
From: Ross Philipson
I can't really give an R-b on this once since it originated with me. I
think it looks fine though perhaps adding something of a commit message
might be desirable, maybe just listing what was added here.
Thanks
Ross
Signed-of
On 9/19/24 3:02 PM, Sergii Dmytruk wrote:
From: Daniel Kiper
Currently rdmsr and wrmsr commands have own MSR support detection code.
This code is the same. So, it is duplicated. Additionally, this code
cannot be reused by others. Hence, extract this code to a function and
make it public. By the
On 9/19/24 3:02 PM, Sergii Dmytruk wrote:
From: Daniel Kiper
Use more obvious names which match corresponding instructions:
* grub_msr_read() => grub_rdmsr()
* grub_msr_write() => grub_wrmsr()
Signed-off-by: Daniel Kiper
Signed-off-by: Sergii Dmytruk
Reviewed-by: Ross Philipson
---
On 9/19/24 3:02 PM, Sergii Dmytruk wrote:
From: Daniel Kiper
It does not make sense to have separate headers for individual static
functions. Additionally, we have to add some constants with MSR
addresses in subsequent patches. So, make one common place to store
them.
Signed-off-by: Daniel Kip
On Fri, Sep 20, 2024 at 02:40:22PM +0100, Frediano Ziglio via Grub-devel wrote:
> On Thu, Sep 19, 2024 at 11:03 PM Sergii Dmytruk
> wrote:
> >
> > From: Krystian Hebel
> >
> > Subsequent patches will use those macros and constant.
> >
>
> Minor, but "Define GRUB_PAGE_MASK constant and GRUB_PAGE_{
On Thu, Sep 19, 2024 at 11:03 PM Sergii Dmytruk
wrote:
>
> From: Krystian Hebel
>
> Subsequent patches will use those macros and constant.
>
Minor, but "Define GRUB_PAGE_MASK constant and GRUB_PAGE_{UP, DOWN}
macros" subject sounds a bit confusing to me. I mean, at the end they
are all defined a
On 9/20/24 4:16 AM, Gary Lin wrote:
On Fri, Sep 13, 2024 at 10:25:14AM -0400, Stefan Berger wrote:
+SHA1, SHA256, SHA384, and SHA512, and the default is SHA256.
+
+There are some options only available for the specific mode. The SRK-specific
+options are @option{-T}, @option{-k}, @option{
On Fri, Sep 13, 2024 at 10:25:14AM -0400, Stefan Berger wrote:
>
>
> On 9/6/24 5:11 AM, Gary Lin wrote:
> > Update the user manual to address TPM2 key protector including the two
> > related commands, tpm2_key_protector_init and tpm2_key_protector_clear,
> > and the user-space utility: grub-prote
