Re: [Xen-devel] [PATCH v2 10/18] xen: setup hypercall page for PVH

2018-10-19 Thread Andrew Cooper
On 19/10/18 13:30, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:09PM +0200, Juergen Gross wrote: >> + >> + __arg0 = a0; >> + __arg1 = a1; >> + __arg2 = a2; >> + __arg3 = a3; >> + __arg4 = a4; >> + asm volatile ("call *%[callno]" >> +: "=r" (__res), "+r" (__arg0), "+r" (__ar

Re: [Xen-devel] [PATCH 01/18] x86/boot/reloc: mask out MBI_BOOTDEV from mbi flags

2015-01-30 Thread Andrew Cooper
On 30/01/15 17:54, Daniel Kiper wrote: > ..because it is ignored by Xen. > > Signed-off-by: Daniel Kiper Reviewed-by: Andrew Cooper > --- > xen/arch/x86/boot/reloc.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/

Re: [PATCH 02/18] x86/boot/reloc: create generic alloc and copy functions

2015-01-30 Thread Andrew Cooper
On 30/01/15 17:54, Daniel Kiper wrote: > Create generic alloc and copy functions. We need > separate tools for memory allocation and copy to > provide multiboot2 protocol support. > > Signed-off-by: Daniel Kiper Reviewed-by: Andrew Cooper > --- > xen/arch/x8

Re: [PATCH 04/18] xen/x86: add multiboot2 protocol support

2015-01-30 Thread Andrew Cooper
Kiper I have not reviewed the multiboot2 protocol in detail, but it appears sane and I presume it is suitably tested and works. As far as the mb1/mb2 interaction goes, this is looking far better. Reviewed-by: Andrew Cooper > --- > xen/arch/x86/boot/Makefile|3 +- >

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-01-30 Thread Andrew Cooper
On 30/01/15 17:54, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper > --- > xen/arch/x86/boot/head.S | 174 > +++-- > xen/arch/x86/efi/efi-boot.h | 29 +++ > xen/arch/x86/setup.c | 23 ++--- > xen/arch/x86/x86_64/asm-offsets.c

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-01-30 Thread Andrew Cooper
On 30/01/2015 23:43, Daniel Kiper wrote: > On Fri, Jan 30, 2015 at 07:06:53PM +0000, Andrew Cooper wrote: >> On 30/01/15 17:54, Daniel Kiper wrote: >>> + >>> +efi_multiboot2_proto: >>> +/* Skip Multiboot2 information fixed part */ >>>

Re: [PATCH 00/18] x86: multiboot2 protocol support

2015-02-04 Thread Andrew Cooper
On 03/02/2015 17:14, Daniel Kiper wrote: > On Mon, Feb 02, 2015 at 09:28:49AM +, Jan Beulich wrote: > On 30.01.15 at 18:54, wrote: >>> - xen.efi build will not so strongly depend >>> on a given GCC and binutils version. >> While I can see the possibility of making the binutils versio

Re: [PATCH 00/18] x86: multiboot2 protocol support

2015-02-05 Thread Andrew Cooper
On 04/02/15 09:51, Jan Beulich wrote: On 04.02.15 at 10:04, wrote: >> On 03/02/2015 17:14, Daniel Kiper wrote: >>> On Mon, Feb 02, 2015 at 09:28:49AM +, Jan Beulich wrote: >>> On 30.01.15 at 18:54, wrote: > - xen.efi build will not so strongly depend > on a given GCC an

Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms

2015-02-10 Thread Andrew Cooper
On 10/02/2015 21:27, Daniel Kiper wrote: > On Fri, Jan 30, 2015 at 06:54:22PM +0100, Daniel Kiper wrote: >> Signed-off-by: Daniel Kiper >> --- >> xen/arch/x86/boot/head.S | 174 >> +++-- >> xen/arch/x86/efi/efi-boot.h | 29 +++ >> xen/arch/x8

Re: [PATCH 08/18] efi: build xen.gz with EFI code

2015-03-27 Thread Andrew Cooper
On 27/03/15 11:46, Jan Beulich wrote: On 27.03.15 at 12:14, wrote: IIRC, MS ABI is supported starting from GCC v4.0. Where did you find that? From all I know __attribute__((__ms_abi__)) is being supported only by 4.5 and newer. The mere support of the MS ABI via command line option doesn't hel

Re: [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-03-27 Thread Andrew Cooper
On 27/03/15 13:43, Jan Beulich wrote: On 27.03.15 at 14:32, wrote: On Fri, Feb 20, 2015 at 04:17:35PM +, Jan Beulich wrote: On 30.01.15 at 18:54, wrote: We need more fine grained knowledge about EFI environment and check for EFI platform and EFI loader separately to properly support mult

Re: [Xen-devel] [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-14 Thread Andrew Cooper
On 14/08/15 11:03, Jan Beulich wrote: On 13.08.15 at 21:22, wrote: On Mon, Aug 10, 2015 at 03:17:48PM -0400, Konrad Rzeszutek Wilk wrote: On Mon, Jul 20, 2015 at 04:29:03PM +0200, Daniel Kiper wrote: @@ -34,6 +57,42 @@ multiboot1_header_start: /*** MULTIBOOT1 HEADER / .l

Re: [PATCH v2 10/23] efi: build xen.gz with EFI code

2015-08-25 Thread Andrew Cooper
On 24/08/15 21:54, Daniel Kiper wrote: > > Currently, PE file contains many sections which are not "linear" (one > after another without any holes) or even do not have representation > in a file (e.g. BSS). In theory there is a chance that we could build > proper PE file using curre

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Andrew Cooper
On 27/08/15 16:29, Jan Beulich wrote: On 27.08.15 at 17:10, wrote: >> On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: >> On 20.07.15 at 16:29, wrote: /* Copy bootstrap trampoline to low memory, below 1MB. */ -mov $sym_phys(trampoline_start),%es

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-28 Thread Andrew Cooper
On 28/08/15 07:54, Jan Beulich wrote: > >> Therefore I am very much +1 get grub working. > Then you kind of misunderstood: I'm not against getting grub2 > working (i.e. patches prior to this one are fine in principle). What > I'm against is hacking around firmware+grub2 combinations not > suitable

Re: [Xen-devel] Uniform commands for booting xen

2015-11-12 Thread Andrew Cooper
On 12/11/15 15:44, Jan Beulich wrote: On 12.11.15 at 14:41, wrote: >> Hello, all. I'd like to have set of commands that would boot xen on all >> platforms. I thought of following set: >> >> xen_hypervisor FILE XEN_OPTIONS >> xen_kernel FILE KERNEL_OPTIONS >> xen_initrd INITRD INITRD INITRD >>

Re: [Xen-devel] [BUG] XEN domU crash when PV grub chainloads 32-bit domU grub

2016-01-22 Thread Andrew Cooper
On 22/01/16 12:56, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 22.09.2015 10:53, Ian Campbell wrote: >> Hi Vladimir & grub-devel, >> >> Do you have any thoughts on this issue with i386 pv-grub2? >> > Is it still an issue? If so I'll try to replicate it. From stack dump I > see that it has jum

Re: [Xen-devel] [BUG] XEN domU crash when PV grub chainloads 32-bit domU grub

2016-01-22 Thread Andrew Cooper
On 22/01/16 13:08, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 22.01.2016 14:01, Andrew Cooper wrote: >> On 22/01/16 12:56, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>> On 22.09.2015 10:53, Ian Campbell wrote: >>>> Hi Vladimir &

Re: [MULTIBOOT2 DOC PATCH 01/10] multiboot2: Remove redundant if

2016-06-09 Thread Andrew Cooper
On 09/06/2016 21:30, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper > --- > doc/multiboot.texi |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/multiboot.texi b/doc/multiboot.texi > index 4b92918..27e5a2f 100644 > --- a/doc/multiboot.texi > +++ b/doc/multiboot.te

Re: [Xen-devel] [MULTIBOOT2 DOC PATCH 02/10] multiboot2: Clarify meaning of information request header tag

2016-06-09 Thread Andrew Cooper
On 09/06/2016 21:30, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper > --- > doc/multiboot.texi | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/doc/multiboot.texi b/doc/multiboot.texi > index 27e5a2f..a7e3584 100644 > --- a/doc/multiboot.texi > +

Re: [MULTIBOOT2 DOC PATCH 04/10] multiboot2: Add description of support for EFI boot services

2016-06-09 Thread Andrew Cooper
On 09/06/2016 21:30, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper > --- > doc/multiboot.texi | 108 > +++- > doc/multiboot2.h |2 + > 2 files changed, 108 insertions(+), 2 deletions(-) > > diff --git a/doc/multiboot.texi b/doc/multiboot

Re: [Xen-devel] [MULTIBOOT2 DOC PATCH 06/10] multiboot2: Add description of support for relocatable images

2016-06-09 Thread Andrew Cooper
On 09/06/2016 21:30, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper > --- > doc/multiboot.texi | 56 > > doc/multiboot2.h | 24 ++ > 2 files changed, 80 insertions(+) > > diff --git a/doc/multiboot.texi b/doc/multi

Re: [MULTIBOOT2 DOC PATCH 07/10] multiboot2: Say that memory maps may not be available on EFI platforms

2016-06-09 Thread Andrew Cooper
On 09/06/2016 21:30, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper > --- > doc/multiboot.texi | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/doc/multiboot.texi b/doc/multiboot.texi > index f1e0e09..c81b2ea 100644 > --- a/doc/multiboot.texi > +++ b/doc/multiboot.texi >

Re: [MULTIBOOT2 DOC PATCH 08/10] multiboot2: Add C structure alignment and padding consideration section

2016-06-09 Thread Andrew Cooper
On 09/06/2016 21:30, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper > --- > doc/multiboot.texi | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/doc/multiboot.texi b/doc/multiboot.texi > index c81b2ea..bf02a1b 100644 > --- a/doc/multiboot.texi > +++ b/doc/multiboot.

Re: [Xen-devel] [PATCH v7 2/3] * util/grub.d/20_linux_xen.in: Add xen_boot command support for aarch64

2017-05-03 Thread Andrew Cooper
On 02/05/17 08:06, fu@linaro.org wrote: > From: Fu Wei > > This patch adds the support of xen_boot command for aarch64: > xen_hypervisor > xen_module > These two commands are only for aarch64, since it has its own protocol and > commands to boot xen hypervisor and Dom0, but not multibo

Re: [Xen-devel] [PATCH v7 2/3] * util/grub.d/20_linux_xen.in: Add xen_boot command support for aarch64

2017-05-05 Thread Andrew Cooper
On 05/05/17 09:57, Fu Wei wrote: > Hi Stefano, > > On 4 May 2017 at 04:53, Stefano Stabellini wrote: >> On Wed, 3 May 2017, Andrew Cooper wrote: >>> On 02/05/17 08:06, fu@linaro.org wrote: >>>> From: Fu Wei >>>> >>>>

Re: [Xen-devel] Grant table version

2013-10-28 Thread Andrew Cooper
On 28/10/13 18:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Hello, all. I'm working on pvgrub2 and my problem is following: > When you first use grant tables you commit yourself to a particular > grant table version. GRUB has to read from disk and hence use grant > tables. By doing so it comm

Re: [Xen-devel] pvgrub2 is merged

2013-11-26 Thread Andrew Cooper
On 26/11/13 18:12, Andrey Borzenkov wrote: > В Tue, 26 Nov 2013 18:58:47 +0100 > Fabio Fantoni пишет: > >> I have also another question: >> Is possible specify multiple path where search the grub.cfg for support >> all mainly distributions and add a custom cfg path support taking it >> from argu

Re: multiboot2 and module2 boot issues via GRUB2

2021-03-30 Thread Andrew Cooper via Grub-devel
On 30/03/2021 19:28, Roman Shaposhnik wrote: > Hi! > > seems like I've run into an issue with multiboot2 and module2 > commands that I can't quite explain. Since it may be something > super simply and silly -- I wanted to reach out here before I do > a GRUB/Xen/LK source deepdive. > > So here's the

Re: multiboot2 and module2 boot issues via GRUB2

2021-04-01 Thread Andrew Cooper via Grub-devel
On 01/04/2021 09:44, Roger Pau Monné wrote: > On Thu, Apr 01, 2021 at 09:31:07AM +0200, Jan Beulich wrote: >> On 01.04.2021 03:06, Roman Shaposhnik wrote: >>> And the obvious next question: is my EVE usecase esoteric enough that >>> I should just go ahead and do a custom GRUB patch or is there a mo

Re: multiboot2 and module2 boot issues via GRUB2

2021-04-06 Thread Andrew Cooper via Grub-devel
On 06/04/2021 09:19, Jan Beulich wrote: > On 01.04.2021 21:43, Andrew Cooper wrote: >> On 01/04/2021 09:44, Roger Pau Monné wrote: >>> On Thu, Apr 01, 2021 at 09:31:07AM +0200, Jan Beulich wrote: >>>> On 01.04.2021 03:06, Roman Shaposhnik wrote: >>>>

Re: multiboot2 and module2 boot issues via GRUB2

2021-04-06 Thread Andrew Cooper via Grub-devel
On 06/04/2021 19:03, Roman Shaposhnik wrote: > On Tue, Apr 6, 2021 at 10:51 AM Andrew Cooper > mailto:andrew.coop...@citrix.com>> wrote: > > On 06/04/2021 09:19, Jan Beulich wrote: > > On 01.04.2021 21:43, Andrew Cooper wrote: > >> On 01/04/