[PATCH] i386/relocator_common.S: drop empty #ifdef

Signed-off-by: Cao jin --- grub-core/lib/i386/relocator_common.S | 2 -- 1 file changed, 2 deletions(-) diff --git a/grub-core/lib/i386/relocator_common.S b/grub-core/lib/i386/relocator_common.S index 03f427a03..1b5210dd3 100644 --- a/grub-core/lib/i386/relocator_common.S +++ b/grub-core/lib

[PATCH] realmode.S: update comments

Commit b81d609e4c forget to update it. Signed-off-by: Cao jin --- grub-core/kern/i386/realmode.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/kern/i386/realmode.S b/grub-core/kern/i386/realmode.S index 998fdc756..265cdcb9d 100644 --- a/grub-core/kern/i386

Re: questions about relocator16.S

Sorry I don't see reply in time because I am not on the TO or CC list. On 08/14/2018 04:36 PM, Vladimir 'phcoder' Serbinenko wrote: > > > вт, 14 авг. 2018 г., 9:11 Cao jin <mailto:caoj.f...@cn.fujitsu.com>>: > > Hi, > >   I am learning the

questions about relocator16.S

DATA_SEGMENT? -- Sincerely, Cao jin ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] relocator16.S: comments update

Signed-off-by: Cao jin --- grub-core/lib/i386/relocator16.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/grub-core/lib/i386/relocator16.S b/grub-core/lib/i386/relocator16.S index c8d6f86d8..a8b48d2c4 100644 --- a/grub-core/lib/i386/relocator16.S +++ b/grub-core/lib

[PATCH] linux16 module: code cleanup

1. move relocator related code more close to each other 2. use variable "len" since it has correct assignment, and keep coding style with upper code Signed-off-by: Cao jin --- grub-core/loader/i386/pc/linux.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --

[PATCH] grub-setup: debug message cleanup

variable "root" is initialized after root device probing, and is null in current place, so, drop it. Signed-off-by: Cao jin --- util/setup.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) BTW, I am still not very sure about "root device" in grub, is it the

[PATCH] diskboot: trivial correction on stale comments

diskboot.img now is loaded at 0x8000 and is jumped to with 0:0x8000. Signed-off-by: Cao jin --- grub-core/boot/i386/pc/diskboot.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/boot/i386/pc/diskboot.S b/grub-core/boot/i386/pc/diskboot.S index 1ee4cf5b2

Re: stale comment in diskboot.S ?

Hi Daniel, On 04/11/2018 04:25 AM, Daniel Kiper wrote: > On Wed, Mar 28, 2018 at 04:09:00PM +0800, Cao jin wrote: >> Hi, >> >> I was reading the code, and I want to confirm is following comment is stale? >> >> /* >> * _start is loaded at 0x2000 a

stale comment in diskboot.S ?

Hi, I was reading the code, and I want to confirm is following comment is stale? /* * _start is loaded at 0x2000 and is jumped to with * CS:IP 0:0x2000 in kernel. */ As I understand, it is loaded at 0x8000 and is jumped to with 0:0x8000. -- Sincerely, Cao jin