Thanks, Daniel. Thanks, Glenn.
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
user can give up early by entering an empty passphrase, just as they
could before this patch.
Signed-off-by: Forest
---
Changes since v4:
Default to 3 tries (don't fail) if cryptodisk_passphrase_tries is invalid.
Move temporary vars into the block where they are used.
---
docs/grub
On Mon, 6 May 2024 20:22:48 +0200, Daniel Kiper wrote:
>You can make this check much simpler. Please take a look at the commit
>ac8a37dda (net/http: Allow use of non-standard TCP/IP ports).
I did it that way in order to preserve a feature of Glenn's suggested
approach: passing through any grub_er
user can give up early by entering an empty passphrase, just as they
could before this patch.
Signed-off-by: Forest
---
Note: This is identical to the v3 patch. The change I had in mind proved
unviable.
docs/grub.texi | 9 +
grub-core/disk/cryptodisk.c | 74
Please ignore this rev in favor of v4, coming soon.
(I want to simplify the stale-errno guard around grub_strtoul().)
On Sat, 27 Apr 2024 17:15:42 -0700, Forest wrote:
>Give the user a chance to re-enter their cryptodisk passphrase after a typo,
>rather than immediately failing (and
user can give up early by entering an empty passphrase, just as they
could before this patch.
Signed-off-by: Forest
---
docs/grub.texi | 9 +
grub-core/disk/cryptodisk.c | 74 +
2 files changed, 67 insertions(+), 16 deletions(-)
diff --git a
On Sat, 27 Apr 2024 04:18:29 -0500, Glenn Washburn wrote:
>Its also a good idea to always CC Daniel on patches. They may more easily
>get dropped otherwise.
Thanks. Will do.
>This does not account for tries_env not being a numeric value with no
>garbage at the end or the empty string. I think th
On Sun, 07 Apr 2024 14:52:32 -0700, Forest wrote:
>Changes since last rev:
>- replace some spaces with tabs
>- better explain the clearing of grub_errno
>- let an environment variable override the number of passphrase tries
As a new contributor, is there something I should do to ens
Changes since last rev:
- replace some spaces with tabs
- better explain the clearing of grub_errno
- let an environment variable override the number of passphrase tries
Thanks to Glenn Washburn for reviewing.
Signed-off-by: Forest
diff --git a/docs/grub.texi b/docs/grub.texi
index a225f9a88
On Thu, 4 Apr 2024 02:50:54 -0500, Glenn Washburn wrote:
>Are you getting dumped into the rescue shell or the normal shell?
In my virtual machine, the prompt says:
grub rescue>
I don't think the distinction matters here, though, since GRUB shells and
scripts are beyond most of my friends and f
that ignores whitespace,
since a good chunk of the changed lines are from reordering and indenting
existing code.
Signed-off-by: Forest
--- a/grub-core/disk/cryptodisk.c
+++ b/grub-core/disk/cryptodisk.c
@@ -1063,6 +1063,7 @@
grub_cryptodisk_dev_t cr;
struct cryptodisk_read_hook_ctx
11 matches
Mail list logo
