Re: Lagging cursor in GRUB menu with HiDPI display

2022-08-23 Thread Hans de Goede
Hi Paul, On 8/23/22 17:01, Paul Menzel wrote: > Dear GRUB folks, > > > Trying to navigate the GRUB menu on a HiDPI display (GOP driver), in this > case a Dell XPS 13 9370, the cursor response is quite lagging. Especially in > the edit mode (c) moving around a line is quite slow. Each step take

Re: [PATCH 1/2] EFI: console: Do not set colorstate until the first text output

2022-03-04 Thread Hans de Goede
Hi Daniel, On 1/28/22 12:43, Hans de Goede wrote: > GRUB_MOD_INIT(normal) does an unconditional: > > grub_env_set ("color_normal", "light-gray/black"); > > which triggers a grub_term_setcolorstate() call. The original version > of the "efi/console: Do

Re: [PATCH 0/2] EFI/menu: Do not print messages when autobooting with TIMEOUT_STYLE_HIDDEN

2022-03-04 Thread Hans de Goede
Hi Daniel, On 1/28/22 11:30, Hans de Goede wrote: > Hi All, > > This series in essence is a renewed attempt to get grub to really > be truly hidden when autobooting with TIMEOUT_STYLE_HIDDEN. > > This is something which multiple big Linux distributions want, > this is a mi

[PATCH 2/2] EFI: console: Do not set cursor until the first text output

2022-01-28 Thread Hans de Goede
the cursorstate and then use the last set value when the first text is output. Fixes: 2d7c3abd871f ("efi/console: Do not set text-mode until we actually need it") Signed-off-by: Hans de Goede --- grub-core/term/efi/console.c | 19 --- 1 file changed, 16 insert

[PATCH 1/2] EFI: console: Do not set colorstate until the first text output

2022-01-28 Thread Hans de Goede
efi/console.c file the code to cache the color-state + bail early was accidentally dropped. Restore the cache the color-state + bail early behavior from the original. Cc: Javier Martinez Canillas Fixes: 2d7c3abd871f ("efi/console: Do not set text-mode until we actually need it") Signed-of

[PATCH 0/2] EFI/menu: Do not print messages when autobooting with TIMEOUT_STYLE_HIDDEN

2022-01-28 Thread Hans de Goede
. Regards, Hans 1) It is only silenced when autobooting with TIMEOUT_STYLE_HIDDEN Hans de Goede (2): normal/menu: Don't show "Booting `%s'" msg when auto-booting with TIMEOUT_STYLE_HIDDEN EFI: suppress the "Welcome to GRUB!" message in EFI builds grub-core/

[PATCH 2/2] EFI: suppress the "Welcome to GRUB!" message in EFI builds

2022-01-28 Thread Hans de Goede
uld not be printed. Signed-off-by: Hans de Goede --- grub-core/kern/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/grub-core/kern/main.c b/grub-core/kern/main.c index 73967e2f5..e811dc3b1 100644 --- a/grub-core/kern/main.c +++ b/grub-core/kern/main.c @@ -270,10 +270,13 @@ grub_

[PATCH 1/2] normal/menu: Don't show "Booting `%s'" msg when auto-booting with TIMEOUT_STYLE_HIDDEN

2022-01-28 Thread Hans de Goede
msg will kick the EFI fb into text mode and show the msg, breaking the flicker-free experience. Signed-off-by: Hans de Goede --- grub-core/normal/menu.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/grub-core/normal/menu.c b/grub-core/normal/menu.

Re: Transfering Data from GRUB to userspace?

2019-11-14 Thread Hans de Goede
Hi, Sorry for jumping in mid thread, but I just noticed this and some functionality like this has my interest too. I especially triggered on the cpio / initrd proposal. I have been discussing something similar with the systemd folks, see some background see: https://lists.freedesktop.org/arch

[PATCH] EFI: console: Fix the "enter" key not working on X86 tablets

2018-06-26 Thread Hans de Goede
d unicode_char being set to 0x0d and treats this as an enter key press. This fixes things getting stuck at the grub-menu and allows the user to choice a grub-menu entry using the buttons on the tablet. Signed-off-by: Hans de Goede --- grub-core/term/efi/console.c | 3 +++ 1 file changed, 3 inser

Re: [PATCH 4/4] EFI: Do not set text-mode until we actually need it

2018-04-05 Thread Hans de Goede
Hi, On 05-04-18 14:34, Daniel Kiper wrote: On Wed, Mar 28, 2018 at 04:50:28PM +0200, Hans de Goede wrote: If we're running with a hidden menu we may never need text mode, so do not change the video-mode to text until we actually need it. Signed-off-by: Hans de Goede --- grub-core/ter

Re: [PATCH 3/4] Optionally print less messages at boot

2018-04-05 Thread Hans de Goede
Hi, On 05-04-18 14:12, Daniel Kiper wrote: On Wed, Mar 28, 2018 at 04:50:27PM +0200, Hans de Goede wrote: The patch optionally makes grub not show any text (be fully quiet) when timeout_style=hidden is set and the user does not interrupt the boot. Combined with a later patch in this series

Re: [PATCH 1/1] Fix PCIe LER when GRUB2 accesses non-enabled MMIO data from VGA

2018-03-29 Thread Hans de Goede
Hi, On 29-03-18 16:27, Mike Travis wrote: On 3/29/2018 2:36 AM, Daniel Kiper wrote: On Thu, Mar 29, 2018 at 05:29:01PM +0800, Michael Chang wrote: On Thu, Mar 29, 2018 at 11:02:51AM +0200, Daniel Kiper wrote: On Wed, Mar 28, 2018 at 11:42:18AM -0500, mike.tra...@hpe.com wrote: A GPU insert

Re: [PATCH 1/4] Add new "version" command

2018-03-29 Thread Hans de Goede
Hi, On 29-03-18 09:53, Olaf Hering wrote: On Wed, Mar 28, Hans de Goede wrote: + grub_printf ("%s, build %s %s\n", PACKAGE_STRING, __DATE__, __TIME__); NACK. Debian sells something what they call "reproducible build". Check their website why usage of __DATE__ and __T

Re: [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

2018-03-28 Thread Hans de Goede
Hi, On 28-03-18 17:11, Lennart Sorensen wrote: On Wed, Mar 28, 2018 at 05:06:53PM +0200, Hans de Goede wrote: Hmm, well people will still be able to use ESC to get the grub boot menu, rather then the firmware boot-menu on those. The problem is that our current check for ESC only approach is

Re: [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

2018-03-28 Thread Hans de Goede
Hi, On 28-03-18 16:56, Lennart Sorensen wrote: On Wed, Mar 28, 2018 at 04:50:26PM +0200, Hans de Goede wrote: On most Bay Trail, Cherry Trail and Apollo Lake devices the ESC key is the hotkey to enter the BIOS/EFI setup screen. This makes it hard for the user to show the grub-menu when it is

[PATCH 3/4] Optionally print less messages at boot

2018-03-28 Thread Hans de Goede
Ubuntu patches, as Fedora's patches where simply unconditionally removing all the unwanted grub_printf calls. Cc: Colin Watson Signed-off-by: Hans de Goede --- config.h.in | 2 ++ configure.ac | 16 grub-core/boot/i386/pc/b

[PATCH 4/4] EFI: Do not set text-mode until we actually need it

2018-03-28 Thread Hans de Goede
If we're running with a hidden menu we may never need text mode, so do not change the video-mode to text until we actually need it. Signed-off-by: Hans de Goede --- grub-core/term/efi/console.c | 72 +++- 1 file changed, 47 insertions(+), 25 deletions(-)

[PATCH 2/4] Accept Both ESC and F8 as user interrupt keys

2018-03-28 Thread Hans de Goede
screen. F8 is (almost?) always free (on X86/PC platforms) as Windows uses this for its boot menu, so also accept F8 as interrupt/show-menu key. As an added advantage this is also more discoverable / easier for users coming from Windows. Signed-off-by: Hans de Goede --- grub-core/commands/sleep.c

[PATCH 1/4] Add new "version" command

2018-03-28 Thread Hans de Goede
Add a new "version" command which prints the grub PACKAGE_STRING + build time and date. This is useful to check if the expected version is running, for e.g. trouble-shooting purposes. Signed-off-by: Hans de Goede --- grub-core/kern/corecmd.c | 11 +++ 1 file changed, 11

[PATCH 0/4] Make hidden menu really hidden

2018-03-28 Thread Hans de Goede
Hi All, Let me start with a quick self-intro: I'm a FOSS enthusiast / developer working for Red Hat, my latest project at Red Hat is chasing what has over the years become the magical unicorn of desktop Linux distros: a smooth graphical boot where the machine goes from the BIOS screen to the grap