[PATCH v3 7/9] btrfs: add environment block to reserved header area

2025-10-02 Thread Michael Chang via Grub-devel
defines regions for bootloader use. By adding this entry, GRUB gains a fixed and safe location to store the environment block without conflicting with other structures in the header. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa --- grub-core/fs/btrfs.c | 3 ++- 1 file changed, 2

[PATCH v3 6/9] util/grub-editenv: wire list_variables to optional fs_envblk

2025-10-02 Thread Michael Chang via Grub-devel
before. The change makes it possible to inspect variables regardless of whether they are stored in the file envblk or in the reserved block. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa Reviewed-by: Avnish Chouhan Reviewed-by: Sudhakar Kuppusamy --- util/grub-editenv.c | 7 +++ 1 file

Re: [PATCH] loader/i386/linux: Transfer EDID information to kernel

2025-10-02 Thread Michael Chang via Grub-devel
ecent addition of the efidrm > and vesadrm drivers to the kernel, it becomes much more useful. As with > the initial screen setup, these drivers can make use of the provided > EDID information for basic display output. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Mich

[PATCH v3 9/9] docs: add Btrfs env block and special env vars

2025-10-02 Thread Michael Chang via Grub-devel
Update grub.texi to describe the external environment block in the reserved area of Btrfs header used for grub-reboot and savedefault, and add a section documenting the saved_entry, next_entry, and env_block variables. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa --- docs/grub.texi

[PATCH v3 8/9] 00_header.in: wire grub.cfg to use env_block when present

2025-10-01 Thread Michael Chang via Grub-devel
need to change. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa --- util/grub.d/00_header.in | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/util/grub.d/00_header.in b/util/grub.d/00_header.in index f86b69bad..9d36feda3 100644 --- a/util/grub.d

[PATCH v3 1/9] util/grub-editenv: add basic structures and probe call for external envblk

2025-10-01 Thread Michael Chang via Grub-devel
grub editenv is unchanged. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa Reviewed-by: Avnish Chouhan --- include/grub/fs.h | 2 + util/grub-editenv.c | 155 +++- 2 files changed, 156 insertions(+), 1 deletion(-) diff --git a/include/grub/fs.h

[PATCH v3 4/9] util/grub-editenv: wire set_variables to optional fs_envblk

2025-10-01 Thread Michael Chang via Grub-devel
block is deleted. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa --- util/grub-editenv.c | 55 +++-- 1 file changed, 53 insertions(+), 2 deletions(-) diff --git a/util/grub-editenv.c b/util/grub-editenv.c index 450bb00a5..efc6ec5f2 100644 --- a/util

[PATCH v3 3/9] util/grub-editenv: add fs_envblk write helper

2025-10-01 Thread Michael Chang via Grub-devel
by later patches. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa --- util/grub-editenv.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/util/grub-editenv.c b/util/grub-editenv.c index 829384392..450bb00a5 100644 --- a/util/grub

[PATCH v3 0/9] Add support for external environment block on Btrfs

2025-10-01 Thread Michael Chang via Grub-devel
line before return statement - Fix missing space after cast operator Michael Chang (9): util/grub-editenv: add basic structures and probe call for external envblk util/grub-editenv: add fs_envblk open helper util/grub-editenv: add fs_envblk write helper util/grub-editenv: wire set_

[PATCH v3 5/9] util/grub-editenv: wire unset_variables to optional fs_envblk

2025-10-01 Thread Michael Chang via Grub-devel
written as before. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa Reviewed-by: Avnish Chouhan --- util/grub-editenv.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/util/grub-editenv.c b/util/grub-editenv.c index efc6ec5f2..ad3088475 100644 --- a/util/grub-editenv.c

[PATCH v3 2/9] util/grub-editenv: add fs_envblk open helper

2025-10-01 Thread Michael Chang via Grub-devel
off-by: Michael Chang Reviewed-by: Neal Gompa --- util/grub-editenv.c | 128 1 file changed, 128 insertions(+) diff --git a/util/grub-editenv.c b/util/grub-editenv.c index 1f055ca43..829384392 100644 --- a/util/grub-editenv.c +++ b/util/grub-editenv.c @@ -

Re: [PATCH v2 3/9] util/grub-editenv: add fs_envblk write helper

2025-10-01 Thread Michael Chang via Grub-devel
Hi Avnish, Thanks a not for the review, please check my comments below. On Wed, Sep 17, 2025 at 04:34:52PM +0530, Avnish Chouhan wrote: > On 2025-09-15 14:39, grub-devel-requ...@gnu.org wrote: > > Message: 4 > > Date: Mon, 15 Sep 2025 17:08:42 +0800 > > From: Micha

Re: [PATCH v2 4/9] util/grub-editenv: wire set_variables to optional fs_envblk

2025-09-23 Thread Michael Chang via Grub-devel
On Wed, Sep 17, 2025 at 10:38:17PM +0530, Avnish Chouhan wrote: > On 2025-09-15 14:39, grub-devel-requ...@gnu.org wrote: > > Message: 1 > > Date: Mon, 15 Sep 2025 17:08:43 +0800 > > From: Michael Chang > > To: The development of GNU GRUB > > Cc: Neal

[PATCH v2 6/9] util/grub-editenv: wire list_variables to optional fs_envblk

2025-09-20 Thread Michael Chang via Grub-devel
before. The change makes it possible to inspect variables regardless of whether they are stored in the file envblk or in the reserved block. Signed-off-by: Michael Chang --- util/grub-editenv.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/util/grub-editenv.c b/util/grub-editenv.c index

[PATCH v2 4/9] util/grub-editenv: wire set_variables to optional fs_envblk

2025-09-20 Thread Michael Chang via Grub-devel
block is deleted. Signed-off-by: Michael Chang --- util/grub-editenv.c | 55 +++-- 1 file changed, 53 insertions(+), 2 deletions(-) diff --git a/util/grub-editenv.c b/util/grub-editenv.c index 26a81d2d0..d47adeb5e 100644 --- a/util/grub-editenv.c +++ b/util

[PATCH v2 7/9] btrfs: add environment block to reserved header area

2025-09-20 Thread Michael Chang via Grub-devel
defines regions for bootloader use. By adding this entry, GRUB gains a fixed and safe location to store the environment block without conflicting with other structures in the header. Signed-off-by: Michael Chang --- grub-core/fs/btrfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH v2 8/9] 00_header.in: wire grub.cfg to use env_block when present

2025-09-18 Thread Michael Chang via Grub-devel
need to change. Signed-off-by: Michael Chang --- util/grub.d/00_header.in | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/util/grub.d/00_header.in b/util/grub.d/00_header.in index f86b69bad..9d36feda3 100644 --- a/util/grub.d/00_header.in +++ b/util

[PATCH v2 1/9] util/grub-editenv: add basic structures and probe call for external envblk

2025-09-17 Thread Michael Chang via Grub-devel
grub editenv is unchanged. Signed-off-by: Michael Chang --- include/grub/fs.h | 2 + util/grub-editenv.c | 153 +++- 2 files changed, 154 insertions(+), 1 deletion(-) diff --git a/include/grub/fs.h b/include/grub/fs.h index df4c93b16..1be26dfba 100644

[PATCH] getroot: Skip mount points in grub_find_device

2025-09-15 Thread Michael Chang via Grub-devel
all types of mounts, for eg bind mounts, it is a practical solution that avoids the need to parse /proc/self/mounts. Signed-off-by: Michael Chang --- grub-core/osdep/unix/getroot.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/grub-core/osdep/unix/getroot.c b/grub-core/osdep

Re: [PATCH v2 1/9] util/grub-editenv: add basic structures and probe call for external envblk

2025-09-15 Thread Michael Chang via Grub-devel
Hi Avnish, Thanks for the review. Please see my comments below. On Mon, Sep 15, 2025 at 06:37:05PM +0530, Avnish Chouhan wrote: > On 2025-09-15 14:39, grub-devel-requ...@gnu.org wrote: > > > > Message: 2 > > Date: Mon, 15 Sep 2025 17:08:40 +0800 > > From: Michael Cha

[PATCH v2 3/9] util/grub-editenv: add fs_envblk write helper

2025-09-15 Thread Michael Chang via Grub-devel
by later patches. Signed-off-by: Michael Chang --- util/grub-editenv.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/util/grub-editenv.c b/util/grub-editenv.c index 4e5dffa86..26a81d2d0 100644 --- a/util/grub-editenv.c +++ b/util/grub

[PATCH v2 9/9] docs: add Btrfs env block and special env vars

2025-09-15 Thread Michael Chang via Grub-devel
Update grub.texi to describe the external environment block in the reserved area of Btrfs header used for grub-reboot and savedefault, and add a section documenting the saved_entry, next_entry, and env_block variables. Signed-off-by: Michael Chang --- docs/grub.texi | 60

[PATCH v2 5/9] util/grub-editenv: wire unset_variables to optional fs_envblk

2025-09-15 Thread Michael Chang via Grub-devel
written as before. Signed-off-by: Michael Chang --- util/grub-editenv.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/util/grub-editenv.c b/util/grub-editenv.c index d47adeb5e..5fe240c42 100644 --- a/util/grub-editenv.c +++ b/util/grub-editenv.c @@ -476,18 +476,32 @@ static

[PATCH v2 0/9] Add support for external environment block on Btrfs

2025-09-15 Thread Michael Chang via Grub-devel
quot; instead of "(! fp)", fix similar cases throughout - Use bool for the "found" field in var_lookup_ctx - Add documentation describing the Btrfs environment block and special environment block variables Michael Chang (9): util/grub-editenv: add basic structures and pro

[PATCH v2 2/9] util/grub-editenv: add fs_envblk open helper

2025-09-15 Thread Michael Chang via Grub-devel
off-by: Michael Chang --- util/grub-editenv.c | 128 1 file changed, 128 insertions(+) diff --git a/util/grub-editenv.c b/util/grub-editenv.c index 2302a6acf..4e5dffa86 100644 --- a/util/grub-editenv.c +++ b/util/grub-editenv.c @@ -130,12 +130,23 @@

Re: [PATCH 4/8] util/grub-editenv: wire set_variables to optional fs_envblk

2025-09-08 Thread Michael Chang via Grub-devel
On Fri, Sep 05, 2025 at 10:24:58PM +0200, Daniel Kiper wrote: > On Tue, Sep 02, 2025 at 02:46:00PM +0800, Michael Chang via Grub-devel wrote: > > This patch changes set_variables so that it can use an external > > environment block when one is present. The variable next_entry is &

[PATCH] efi/sb: Fix boot failure when shim validation is disabled

2025-09-08 Thread Michael Chang via Grub-devel
discovered and used even if shim is placed into insecure mode. At the same time, grub_efi_get_secureboot() continues to preserve the logic that matches the Linux kernel implementation, keeping the two consistent. Signed-off-by: Michael Chang --- grub-core/kern/efi/init.c | 2 +- grub-core/

Re: [PATCH 0/8] Add support for external environment block on Btrfs

2025-09-08 Thread Michael Chang via Grub-devel
On Fri, Sep 05, 2025 at 10:32:24PM +0200, Daniel Kiper wrote: > On Tue, Sep 02, 2025 at 02:45:56PM +0800, Michael Chang via Grub-devel wrote: > > This patch series adds support for storing the GRUB environment block in > > a reserved area of the Btrfs header. On copy on write f

Re: [PATCH 3/8] util/grub-editenv: add fs_envblk write helper

2025-09-07 Thread Michael Chang via Grub-devel
On Fri, Sep 05, 2025 at 10:15:48PM +0200, Daniel Kiper wrote: > On Tue, Sep 02, 2025 at 02:45:59PM +0800, Michael Chang via Grub-devel wrote: > > This patch adds the function fs_envblk_write to update the reserved > > environment block on disk. The helper takes an in memory envblk

Re: [PATCH 1/8] util/grub-editenv: add basic structures and probe call for external envblk

2025-09-07 Thread Michael Chang via Grub-devel
On Fri, Sep 05, 2025 at 09:39:56PM +0200, Daniel Kiper wrote: > On Tue, Sep 02, 2025 at 02:45:57PM +0800, Michael Chang via Grub-devel wrote: > > This patch prepares for using an environment block stored in a reserved > > area of the filesystem. It adds a constant ENV_BTRFS_OF

Re: [PATCH 2/8] util/grub-editenv: add fs_envblk open helper

2025-09-07 Thread Michael Chang via Grub-devel
On Fri, Sep 05, 2025 at 10:08:41PM +0200, Daniel Kiper wrote: > On Tue, Sep 02, 2025 at 02:45:58PM +0800, Michael Chang via Grub-devel wrote: > > This patch adds the logic to locate and open an environment block that > > is stored in a reserved area on the device. It introduc

[PATCH 7/8] btrfs: add environment block to reserved header area

2025-09-03 Thread Michael Chang via Grub-devel
defines regions for bootloader use. By adding this entry, GRUB gains a fixed and safe location to store the environment block without conflicting with other structures in the header. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa --- grub-core/fs/btrfs.c | 3 ++- 1 file changed, 2

[PATCH 0/8] Add support for external environment block on Btrfs

2025-09-03 Thread Michael Chang via Grub-devel
load_env and save_env use the external block automatically when env_block is defined. Michael Chang (8): util/grub-editenv: add basic structures and probe call for external envblk util/grub-editenv: add fs_envblk open helper util/grub-editenv: add fs_envblk write helper util/grub-editenv

[PATCH v2] tcp: Fix TCP port number reused on reboot

2025-09-02 Thread Michael Chang via Grub-devel
ely. In typical usage, a GRUB boot cycle lasts about 15 seconds and may open fewer than 100 connections total, well below the reuse threshold. This makes the approach robust against short reboot intervals while keeping the logic simple and deterministic. Signed-off-by: Michael Chang Review

[PATCH 8/8] 00_header.in: wire grub.cfg to use env_block when present

2025-09-01 Thread Michael Chang via Grub-devel
need to change. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa --- util/grub.d/00_header.in | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/util/grub.d/00_header.in b/util/grub.d/00_header.in index f86b69bad..9d36feda3 100644 --- a/util/grub.d

[PATCH 5/8] util/grub-editenv: wire unset_variables to optional fs_envblk

2025-09-01 Thread Michael Chang via Grub-devel
written as before. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa --- util/grub-editenv.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/util/grub-editenv.c b/util/grub-editenv.c index ca3787c98..b2aac8e1f 100644 --- a/util/grub-editenv.c +++ b/util/grub-editenv.c

[PATCH 4/8] util/grub-editenv: wire set_variables to optional fs_envblk

2025-09-01 Thread Michael Chang via Grub-devel
block is deleted. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa --- util/grub-editenv.c | 55 +++-- 1 file changed, 53 insertions(+), 2 deletions(-) diff --git a/util/grub-editenv.c b/util/grub-editenv.c index a319d01b7..ca3787c98 100644 --- a/util

[PATCH 1/8] util/grub-editenv: add basic structures and probe call for external envblk

2025-09-01 Thread Michael Chang via Grub-devel
grub editenv is unchanged. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa --- include/grub/fs.h | 2 + util/grub-editenv.c | 156 +++- 2 files changed, 157 insertions(+), 1 deletion(-) diff --git a/include/grub/fs.h b/include/grub/fs.h index

[PATCH 6/8] util/grub-editenv: wire list_variables to optional fs_envblk

2025-09-01 Thread Michael Chang via Grub-devel
before. The change makes it possible to inspect variables regardless of whether they are stored in the file envblk or in the reserved block. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa --- util/grub-editenv.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/util/grub-editenv.c b

[PATCH 3/8] util/grub-editenv: add fs_envblk write helper

2025-09-01 Thread Michael Chang via Grub-devel
by later patches. Signed-off-by: Michael Chang Reviewed-by: Neal Gompa --- util/grub-editenv.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/util/grub-editenv.c b/util/grub-editenv.c index 7bc872dc7..a319d01b7 100644 --- a/util/grub

[PATCH 2/8] util/grub-editenv: add fs_envblk open helper

2025-09-01 Thread Michael Chang via Grub-devel
off-by: Michael Chang Reviewed-by: Neal Gompa --- util/grub-editenv.c | 127 1 file changed, 127 insertions(+) diff --git a/util/grub-editenv.c b/util/grub-editenv.c index a1fa711cd..7bc872dc7 100644 --- a/util/grub-editenv.c +++ b/util/grub-editenv.c @@

Re: [PATCH] Support environment block in btrfs reserved area

2025-08-21 Thread Michael Chang via Grub-devel
On Thu, Aug 21, 2025 at 03:59:56PM +0200, Daniel Kiper wrote: > On Fri, Jul 11, 2025 at 12:21:11PM +0800, Michael Chang via Grub-devel wrote: > > On Btrfs, GRUB cannot update the environment block (grubenv) because > > file based writes via blocklists are incompatible with Btrfs C

[PATCH v2] tcp: Fix TCP port number reused on reboot

2025-07-11 Thread Michael Chang via Grub-devel
ely. In typical usage, a GRUB boot cycle lasts about 15 seconds and may open fewer than 100 connections total, well below the reuse threshold. This makes the approach robust against short reboot intervals while keeping the logic simple and deterministic. Signed-off-by: Michael Chang Review

Re: [PATCH] tcp: Fix TCP port number reused on reboot

2025-07-11 Thread Michael Chang via Grub-devel
Hi Subhakar, Thanks for the review. On Fri, Jul 11, 2025 at 11:17:00AM +0530, Sudhakar Kuppusamy wrote: > > > > On 11 Jul 2025, at 9:37 AM, Michael Chang via Grub-devel > > wrote: > > > > GRUB's TCP stack assigns source ports for outgoing connections s

[PATCH] Support environment block in btrfs reserved area

2025-07-10 Thread Michael Chang via Grub-devel
reserved area as used to avoid conflicts with embedded core images. This enables support for runtime environment updates on Btrfs root volumes, allowing tools like grub-reboot to boot an entry once. Signed-off-by: Michael Chang --- grub-core/fs/btrfs.c | 3 +- include/grub/fs.h| 2

[PATCH] tcp: Fix TCP port number reused on reboot

2025-07-10 Thread Michael Chang via Grub-devel
ely. In typical usage, a GRUB boot cycle lasts about 15 seconds and may open fewer than 100 connections total, well below the reuse threshold. This makes the approach robust against short reboot intervals while keeping the logic simple and deterministic. Signed-off-by: Michael Chang --- grub-core

Re: [PATCH v3 2/5] efi/sb: Add support for the shim loader protocol

2025-04-02 Thread Michael Chang via Grub-devel
On Tue, Apr 01, 2025 at 11:26:42AM +0100, Mate Kukri wrote: > Use loader protocol for image verification where available, otherwise > fall back to the old shim lock protocol. > > Signed-off-by: Mate Kukri > --- > grub-core/kern/efi/sb.c | 58 > grub-core

Re: [PATCH v2 2/2] efi: Use shim's loader protocol for EFI image verification and loading

2025-03-24 Thread Michael Chang via Grub-devel
On Mon, Mar 10, 2025 at 09:12:22AM +, Mate Kukri wrote: > - Use shim loader protocol to verify images in the shim_lock verifier. This change makes the shim loader protocol mandatory for GRUB under UEFI Secure Boot. However, I don't think this is a good idea, since the new protocol is only avai

Re: Arch Linux latest git snapshot has too many issues to be a new release base

2025-02-21 Thread Michael Chang via Grub-devel
On Fri, Feb 21, 2025 at 10:01:11AM +0100, Christian Hesse wrote: > Michael Chang via Grub-devel on Fri, 2025/02/21 15:55: > > On Thu, Feb 20, 2025 at 12:27:12PM +0100, Tobias Powalowski via Grub-devel > > wrote: > > > It failed for my co-maintainer in 2 cases: > > &g

Re: Arch Linux latest git snapshot has too many issues to be a new release base

2025-02-20 Thread Michael Chang via Grub-devel
On Thu, Feb 20, 2025 at 12:27:12PM +0100, Tobias Powalowski via Grub-devel wrote: > Hi Daniel, > > according to my unanswered mail 2 days ago, we tried to bump grub to latest > git snapshot. > > It failed for my co-maintainer in 2 cases: > > - loopback device seems to be broken Is the loopback

Re: [SECURITY PATCH 14/73] fs/ext2: Fix out-of-bounds read for inline extents

2025-02-20 Thread Michael Chang via Grub-devel
, Daniel Kiper via Grub-devel wrote: > From: Michael Chang > > When inline extents are used, i.e. the extent tree depth equals zero, > a maximum of four entries can fit into the inode's data block. If the > extent header states a number of entries greater than four the current &

[PATCH] fs/ext2: Rework out-of-bounds read for inline and external extents

2025-02-20 Thread Michael Chang via Grub-devel
ent entries is processed, preventing out-of-bound reads and potential filesystem corruption. Fixes: 7e2f750f0a (fs/ext2: Fix out-of-bounds read for inline extents) Signed-off-by: Michael Chang --- grub-core/fs/ext2.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --gi

Re: [PATCH v4 5/5] ieee1275: ofpath enable NVMeoF logical device translate

2025-02-12 Thread Michael Chang via Grub-devel
Hi Avnish, This patch doesn't build: ../grub-core/osdep/linux/ofpath.c: In function ‘of_path_of_nvme’: ../grub-core/osdep/linux/ofpath.c:729:37: error: ‘%x’ directive output may be truncated writing between 1 and 8 bytes into a region of size 7 [-Werror=format-truncation=] 729 |

Re: [PATCH] powerpc: increase MIN RMA size for CAS negotiation

2025-02-05 Thread Michael Chang via Grub-devel
On Wed, Jan 15, 2025 at 05:46:05PM +0530, Avnish Chouhan wrote: > Change RMA size from 512 MB to 768 MB which will result > in more memory at boot time for PowerPC. When PowerPC LPAR use/uses vTPM, > Secure Boot or FADump, the 512 MB RMA memory is not sufficient for > booting. With this 512 MB RMA,

Re: [PATCH RESEND] grub-install: force journal draining to ensure data integrity

2025-01-21 Thread Michael Chang via Grub-devel
On Tue, Jan 21, 2025 at 07:41:03AM +0100, Pascal Hambourg wrote: > Le 21/01/2025 à 07:25, Michael Chang via Grub-devel a écrit : > > In XFS, the system would end up in unbootable state if an abrupt power > > off after grub-install is occuring. It can be easily reproduced with. &

[PATCH RESEND] grub-install: force journal draining to ensure data integrity

2025-01-20 Thread Michael Chang via Grub-devel
nc to drain journal and also is not desired as reportedly having negative side effect. With this patch applied, the boot falilure can no longer be reproduced with above procedure. Signed-off-by: Michael Chang --- Makefile.util.def| 3 ++ grub-core/osdep/basic/journaled_fs.c

Re: is it possible to add a new filter to detect unusable partition types

2024-12-18 Thread Michael Chang
On Wed, Dec 18, 2024 at 06:05:54PM +0100, Thomas Weißschuh wrote: > On 2024-12-18 15:44:45+0100, Karel Zak wrote: > > On Wed, Dec 18, 2024 at 11:12:59AM GMT, Zdenek Kabelac wrote: > > [..] > > > > And in the same way blkid should expose installed grub loader - currently > > > the partition with i

Re: is it possible to add a new filter to detect unusable partition types

2024-12-17 Thread Michael Chang
On Tue, Dec 17, 2024 at 11:21:26AM +0100, Zdenek Kabelac wrote: > Dne 17. 12. 24 v 10:13 Glass Su napsal(a): > > > > > On Dec 17, 2024, at 16:34, Heming Zhao wrote: > > > > > > Hi LVM2 maintainers, > > > > > > One of SUSE's customers encountered an issue with LVM2. The user created > > > sever

[PATCH 10/10] bootp: Fix logical operator in DHCP option overload check

2024-12-16 Thread Michael Chang via Grub-devel
Signed-off-by: Michael Chang --- grub-core/net/bootp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/net/bootp.c b/grub-core/net/bootp.c index 8bf0ca782..0bfa3d185 100644 --- a/grub-core/net/bootp.c +++ b/grub-core/net/bootp.c @@ -379,7 +379,7

[PATCH 09/10] kern/efi/efi: Correct endianness in IPv6 device path

2024-12-16 Thread Michael Chang via Grub-devel
Signed-off-by: Michael Chang --- grub-core/kern/efi/efi.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/grub-core/kern/efi/efi.c b/grub-core/kern/efi/efi.c index 2997ab721..122adf267 100644 --- a/grub-core/kern/efi/efi.c +++ b/grub-core

[PATCH 07/10] efinet: Set DNS server from UEFI protocol

2024-12-16 Thread Michael Chang via Grub-devel
incorporated into the DHCPACK packet and passed into the shared DHCP packet processing routines to ensure the network interface is configured as it was previously. Signed-off-by: Ken Lin Signed-off-by: Robbie Harwood Signed-off-by: Michael Chang --- grub-core/net/drivers/efi/efinet.c | 163

[PATCH 05/10] bootp: Process DHCPACK packet during HTTP Boot

2024-12-16 Thread Michael Chang via Grub-devel
quot;HTTPClient" vendor class identifier in DHCPACK packets, interpreting it as an HTTP format rather than a PXE format. Signed-off-by: Ken Lin Signed-off-by: Robbie Harwood Signed-off-by: Michael Chang --- grub-core/net/bootp.c | 28 +++- include/grub/net.h|

[PATCH 08/10] kern/efi/efi: Print URI and DNS device path info

2024-12-16 Thread Michael Chang via Grub-devel
Signed-off-by: Michael Chang --- grub-core/kern/efi/efi.c | 37 + 1 file changed, 37 insertions(+) diff --git a/grub-core/kern/efi/efi.c b/grub-core/kern/efi/efi.c index b93ae3aba..2997ab721 100644 --- a/grub-core/kern/efi/efi.c +++ b/grub-core/kern/efi/efi.c

[PATCH 03/10] efinet + bootp: add net_dhcp6 command supporting dhcpv6

2024-12-16 Thread Michael Chang via Grub-devel
compatibility. Co-authored-by: Peter Jones Co-authored-by: Robbie Harwood Signed-off-by: Robbie Harwood Signed-off-by: Ken Lin Signed-off-by: Michael Chang --- grub-core/net/bootp.c | 915 - grub-core/net/drivers/efi/efinet.c | 38 +- grub-core/net

[PATCH 06/10] efinet: Configure network from UEFI device path

2024-12-16 Thread Michael Chang via Grub-devel
ensure the network interface is set up as it was previously. Signed-off-by: Ken Lin Signed-off-by: Robbie Harwood Signed-off-by: Michael Chang --- grub-core/net/drivers/efi/efinet.c | 306 +++-- include/grub/efi/api.h | 20 ++ 2 files changed, 311

[PATCH 01/10] net/http: Check result of grub_netbuff_put() in http_receive()

2024-12-16 Thread Michael Chang via Grub-devel
From: Robbie Harwood Co-authored-by: Peter Jones Signed-off-by: Peter Jones Signed-off-by: Robbie Harwood Signed-off-by: Michael Chang --- grub-core/net/http.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/grub-core/net/http.c b/grub-core/net/http.c index f389bf03d

[PATCH 02/10] efinet: Add structures for PXE messages

2024-12-16 Thread Michael Chang via Grub-devel
structures to represent this, and make them agnostic between ipv4 and ipv6. Signed-off-by: Ken Lin Co-authored-by: Robbie Harwood Signed-off-by: Robbie Harwood Signed-off-by: Michael Chang --- include/grub/efi/api.h | 145 +++-- 1 file changed, 139 insertions

[PATCH 04/10] grub.texi: Add net_dhcp6 document

2024-12-16 Thread Michael Chang via Grub-devel
Update grub documentation for net_dhcp6 command. Signed-off-by: Michael Chang Signed-off-by: Ken Lin Signed-off-by: Robbie Harwood --- docs/grub.texi | 30 ++ 1 file changed, 30 insertions(+) diff --git a/docs/grub.texi b/docs/grub.texi index 200e747af..50a779d11

[PATCH 00/10] Support UEFI HTTP boot with IPv6 and DNS

2024-12-16 Thread Michael Chang via Grub-devel
E messages Michael Chang (8): efinet + bootp: add net_dhcp6 command supporting dhcpv6 grub.texi: Add net_dhcp6 document bootp: Process DHCPACK packet during HTTP Boot efinet: Configure network from UEFI device path efinet: Set DNS server from UEFI protocol kern/efi/efi: Print URI and DNS d

Re: [PATCH] kern/main: Fix cmdpath in root directory

2024-11-05 Thread Michael Chang via Grub-devel
On Mon, Nov 04, 2024 at 07:15:33PM GMT, Daniel Kiper wrote: > On Fri, Nov 01, 2024 at 10:03:16AM +0800, Michael Chang wrote: > > On Wed, Oct 30, 2024 at 05:12:48PM GMT, Daniel Kiper wrote: > > > Adding Leo... > > > > > > On Tue, Oct 29, 2024 at 03:57:18PM

Re: [PATCH] kern/main: Fix cmdpath in root directory

2024-10-31 Thread Michael Chang via Grub-devel
On Wed, Oct 30, 2024 at 05:12:48PM GMT, Daniel Kiper wrote: > Adding Leo... > > On Tue, Oct 29, 2024 at 03:57:18PM +0800, Michael Chang via Grub-devel wrote: > > The "cmdpath" environment variable is set at startup to the location > > from which the grub image is lo

[PATCH] kern/main: Fix cmdpath in root directory

2024-10-29 Thread Michael Chang via Grub-devel
t. [1] https://mail.gnu.org/archive/html/grub-devel/2024-10/msg00155.html Signed-off-by: Michael Chang --- grub-core/kern/main.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/grub-core/kern/main.c b/grub-core/kern/main.c index d29494d54..6645173c1 100644 --- a/grub-co

Re: [PATCH v3 24/29] btrfs: export btrfs_subvol and btrfs_subvolid

2024-10-20 Thread Michael Chang via Grub-devel
boot/grub/i386-pc, making it accessible in place. [1] https://lists.gnu.org/archive/html/grub-devel/2024-10/msg00089.html Thanks, Michael > > Le lun. 14 oct. 2024, 20:09, Leo Sandoval a écrit : > > > From: Michael Chang > > > > We should export btrfs_subvol and b

Re: [PATCH v3 22/29] btrfs: Add ability to boot from subvolumes

2024-10-20 Thread Michael Chang via Grub-devel
On Fri, Oct 18, 2024 at 08:39:01PM GMT, Vladimir 'phcoder' Serbinenko wrote: > Le lun. 14 oct. 2024, 20:10, Leo Sandoval a écrit : > > > From: Jeff Mahoney > > > > This patch adds the ability to specify a different root on a btrfs > > filesystem too boot from other than the default one. > > > Do

Re: [PATCH] efinet: Skip virtual VLAN devices during card enumeration

2024-10-18 Thread Michael Chang via Grub-devel
On Fri, Oct 18, 2024 at 08:08:28AM GMT, zhangqiumiao wrote: > > On Thu, Oct 03, 2024 at 03:23:15PM +0800, Michael Chang via Grub-devel > > wrote: > >> Similar to the fix in commit "c52ae4057 efinet: skip virtual IPv4 and > >> IPv6 devices during card enumer

Re: [PATCH v3 08/16] normal: Add fw_path variable (revised)

2024-10-14 Thread Michael Chang via Grub-devel
On Thu, Oct 10, 2024 at 03:43:26PM GMT, Leo Sandoval wrote: > From: Paulo Flabiano Smorigo > > This patch makes grub look for its config file on efi where the app was > found. It was originally written by Matthew Garrett, and adapted to fix the > "No modules are loaded on grub2 network boot" issu

Re: [PATCH v2 25/30] btrfs: grub2-btrfs-03-follow_default

2024-10-14 Thread Michael Chang via Grub-devel
On Sat, Oct 12, 2024 at 10:51:09AM GMT, Neal Gompa wrote: > On Fri, Oct 11, 2024 at 6:40 PM Leo Sandoval wrote: > > > > From: Michael Chang > > > > Signed-off-by: Michael Chang > > Signed-off-by: Robbie Harwood > > This needs a real commit message descri

Re: [PATCH] lvm: allocate metadata buffer from raw contents

2024-10-08 Thread Michael Chang via Grub-devel
On Mon, Oct 07, 2024 at 11:49:51AM GMT, ross.philip...@oracle.com wrote: > On 10/3/24 8:40 PM, Michael Chang via Grub-devel wrote: > > On Thu, Oct 03, 2024 at 10:30:15AM GMT, ross.philip...@oracle.com wrote: > > > On 10/3/24 12:23 AM, Michael Chang via Grub-devel wrote: >

[PATCH v2] lvm: allocate metadata buffer from raw contents

2024-10-08 Thread Michael Chang via Grub-devel
: Michael Chang --- grub-core/disk/lvm.c | 79 1 file changed, 43 insertions(+), 36 deletions(-) diff --git a/grub-core/disk/lvm.c b/grub-core/disk/lvm.c index 0c32c95f9..ea260b47e 100644 --- a/grub-core/disk/lvm.c +++ b/grub-core/disk/lvm.c @@ -140,9

Re: [PATCH v1 31/37] btrfs: grub2-btrfs-04-grub2-install

2024-10-08 Thread Michael Chang via Grub-devel
On Tue, Oct 08, 2024 at 10:14:59AM GMT, Vladimir 'phcoder' Serbinenko wrote: > Le mar. 8 oct. 2024, 09:53, Michael Chang via Grub-devel > a écrit : > > > On Tue, Oct 08, 2024 at 08:07:17AM GMT, Vladimir 'phcoder' Serbinenko > > wrote: > > > Agai

Re: [PATCH v1 22/37] bootp: New net_bootp6 command

2024-10-08 Thread Michael Chang via Grub-devel
On Mon, Oct 07, 2024 at 12:20:55PM GMT, Leo Sandoval wrote: > From: Michael Chang > > Implement new net_bootp6 command for IPv6 network auto configuration via the > DHCPv6 protocol (RFC3315). This would have marked the fourth attempt to upstream the patch by different pe

Re: [PATCH v1 33/37] btrfs: grub2-btrfs-06-subvol-mount

2024-10-07 Thread Michael Chang via Grub-devel
as a mess. If a path is relative to the default subvolume, it cannot access files outside of the default subvolume tree. This patch enables access to files in other subvolumes by mounting them to a specific directory Thanks, Michael > > Le lun. 7 oct. 2024, 21:22, Leo Sandoval a écri

Re: [PATCH v1 31/37] btrfs: grub2-btrfs-04-grub2-install

2024-10-07 Thread Michael Chang via Grub-devel
ot the new default subvolume as expected. Instead, it continues to boot from a fixed subvolume. Thanks, Michael > > Le lun. 7 oct. 2024, 21:23, Leo Sandoval a écrit : > > > From: Michael Chang > > > > Signed-off-by: Michael Chang > > Signed-off-by: Robbie Ha

Re: [PATCH] lvm: allocate metadata buffer from raw contents

2024-10-03 Thread Michael Chang via Grub-devel
On Thu, Oct 03, 2024 at 10:30:15AM GMT, ross.philip...@oracle.com wrote: > On 10/3/24 12:23 AM, Michael Chang via Grub-devel wrote: > > Previously, the buffer for LVM metadata parsing was set to twice the > > size of the metadata area, which caused excessive memory use. > > &

Re: [PATCH] Fix screen coud be filled with leftover artifacts

2024-10-03 Thread Michael Chang via Grub-devel
On Thu, Oct 03, 2024 at 09:17:46PM GMT, Askar Safin wrote: > On Thu, 03 Oct 2024 11:23:08 +0400 Michael Chang via Grub-devel wrote > --- > > A regression in grub 2.12 causes the grub screen to become cluttered > > I just tested. Your patch doesn't fix anything

[PATCH] tpm: Skip loopback image measurement

2024-10-03 Thread Michael Chang via Grub-devel
it. This method is important to avoid running out of memory, since loopback images can be very large. Trying to read and measure the whole image at once could cause out of memory errors and disrupt the boot process. Signed-Off-by: Michael Chang --- grub-core/commands/tpm.c | 10 ++ 1

[PATCH] Fix screen coud be filled with leftover artifacts

2024-10-03 Thread Michael Chang via Grub-devel
utput. The issue is fixed by ensuring grub_console_cls() to work through lazy mode-setting, while also avoiding screen clearing for the hidden menu, which the flicker-free patch aims to improve. Fixes: 2d7c3abd8 (efi/console: Do not set text-mode until we actually need it) Signed-off-by: Michael

[PATCH] lvm: allocate metadata buffer from raw contents

2024-10-03 Thread Michael Chang via Grub-devel
allocate just what’s needed for the raw metadata. This change effectively reduces the buffer size while still working correctly. In my test system on openSUSE, the buffer size for LVM metadata dropped from 2,088,960 bytes to 1,119 bytes, which is a big improvement. Signed-off-by: Michael Chang

[PATCH] efinet: Skip virtual VLAN devices during card enumeration

2024-10-03 Thread Michael Chang via Grub-devel
ned-Off-by: Michael Chang --- grub-core/net/drivers/efi/efinet.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/grub-core/net/drivers/efi/efinet.c b/grub-core/net/drivers/efi/efinet.c index 3ea25cf98..58fe381ab 100644 --- a/grub-core/net/drivers/efi/efinet.c +++ b/gru

[PATCH v2] bli: Fix crash in get_part_uuid

2024-07-16 Thread Michael Chang via Grub-devel
prevent the boot process from continuing. Fixes: e0fa7dc84 (bli: Add a module for the Boot Loader Interface) Signed-off-by: Michael Chang Reviewed-By: Oliver Steffen --- grub-core/commands/bli.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/grub-core/comma

Re: [PATCH] bli: Fix crash in get_part_uuid

2024-07-16 Thread Michael Chang via Grub-devel
On Tue, Jul 16, 2024 at 05:45:10AM GMT, Oliver Steffen wrote: > Quoting Michael Chang via Grub-devel (2024-07-16 08:55:00) > > The get_part_uuid() function made an assumption that the target grub > > device is a partition device and accessed device->disk->partition > >

Re: EFI El Torito image on ISO9660 (was: [PATCH] bli: Fix crash in get_part_uuid)

2024-07-16 Thread Michael Chang via Grub-devel
On Tue, Jul 16, 2024 at 10:47:57AM GMT, Pascal Hambourg wrote: > On 16/07/2024 at 08:55, Michael Chang via Grub-devel wrote: > > > > 4. When booting from an ISO, the ESP is treated as an El Torito image in > > the boot catalog. It is therefore presented by firmware and &

[PATCH] bli: Fix crash in get_part_uuid

2024-07-15 Thread Michael Chang via Grub-devel
from continuing. Fixes: e0fa7dc84 (bli: Add a module for the Boot Loader Interface) Signed-off-by: Michael Chang --- grub-core/commands/bli.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/grub-core/commands/bli.c b/grub-core/commands/bli.c index e0d8

Re: [PATCH v3 3/6] ieee1275: implement FCP methods for WWPN and LUNs

2024-07-01 Thread Michael Chang via Grub-devel
On Thu, Jun 06, 2024 at 06:07:24PM GMT, Avnish Chouhan wrote: > This patch enables the fcp-targets and fcp-luns methods which are > responsible to get WWPNs and LUNs for fibre channel devices. > > Those methods are specially necessary if the boot directory and grub > installation are in different

Re: [PATCH v3 1/6] ieee1275/powerpc: implements fibre channel discovery for ofpathname

2024-06-26 Thread Michael Chang via Grub-devel
On Thu, Jun 06, 2024 at 06:07:22PM GMT, Avnish Chouhan wrote: > grub-ofpathname doesn't work with fibre channel because there is no > function currently implemented for it. > This patch enables it by prividing a function that looks for the port > name, building the entire path for OF devices. > >

Re: [PATCH v3 2/6] ieee1275/powerpc: enables device mapper discovery

2024-06-24 Thread Michael Chang via Grub-devel
On Thu, Jun 20, 2024 at 03:14:59PM GMT, avnish wrote: > Hi Vladimir, > > We have implemented this code to enable the ieee1275 hint for grub. We had > scenarios (in SLES) like the disk had PReP partition followed by an LVM and, > inside this LVM , the boot partition. So, we implemented this code to

Re: [PATCH] Fix screen coud be filled with leftover artifacts

2024-06-20 Thread Michael Chang via Grub-devel
On Thu, Jun 20, 2024 at 02:48:55PM GMT, Michael Chang wrote: > A regression in grub 2.12 causes the grub screen to become cluttered > with artifacts from the previous screen, whether it's the UEFI post ui, > UEFI shell, or any graphical UI running before grub. this issue occurs &

[PATCH] Fix screen coud be filled with leftover artifacts

2024-06-19 Thread Michael Chang via Grub-devel
utput. The issue is fixed by ensuring grub_console_cls() to work through lazy mode-setting, while also avoiding screen clearing for the hidden menu, which the flicker-free patch aims to improve. Fixes: 2d7c3abd8 (efi/console: Do not set text-mode until we actually need it) Signed-off-by: Michael

[PATCH] lvm: allocate metadata buffer from raw contents

2024-06-19 Thread Michael Chang via Grub-devel
allocate just what’s needed for the raw metadata. This change effectively reduces the buffer size while still working correctly. In my test system on openSUSE, the buffer size for LVM metadata dropped from 2,088,960 bytes to 1,119 bytes, which is a big improvement. Signed-off-by: Michael Chang

Re: [PATCH] ofnet: Remove 200 ms timeout in get_card_packet to reduce input latency

2024-05-26 Thread Michael Chang via Grub-devel
our internal lab and QA. Thanks, Michael On Mon, May 06, 2024 at 10:34:22AM GMT, Michael Chang wrote: > When grub image is netbooted on ppc64le, the keyboard input exhibits > significant latency, reports even say that characters are processed > about once per second. This issue makes inte

  1   2   3   4   5   >