[PATCH] Support Fedora 13 initrd filenames

d-${alt_version}" "initramfs-${alt_version}.img"; do if test -e "${dirname}/${i}" ; then initrd="$i" break -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: powerpc/sparc problems

On Fri, 2009-10-16 at 05:44 -0700, David Miller wrote: > From: Pavel Roskin > Date: Thu, 15 Oct 2009 18:41:41 -0400 > > > This makes me think that checks for __bswapsi2 and __bswapdi2 will fail > > on Sparc64, even if those functions are present and even if > &g

Re: powerpc/sparc problems

Quoting David Miller : From: Pavel Roskin Date: Thu, 15 Oct 2009 18:41:41 -0400 This makes me think that checks for __bswapsi2 and __bswapdi2 will fail on Sparc64, even if those functions are present and even if --disable-werror is used. They worked perfectly fine for me on a real system

Re: powerpc/sparc problems

g for __ashldi3, which is exported unconditionally on PowerPC, and the check fails, even though I have libc for PowerPC. That's also a cross-compiler, but I can test it on a PowerMac if necessary. This makes me think that checks for __bswapsi2 and __bswapdi2 will fail on Sparc64, even if those

Re: powerpc/sparc problems

On Mon, 2009-10-12 at 17:45 +0200, Vladimir 'phcoder' Serbinenko wrote: > On sparc64, ppc and mips we compile using -nostdlib -lgcc > -static-libgcc. I would prefer to use the same method in check and > actual compile. Ideally, we should use those flags on all architectures.

Re: powerpc/sparc problems

e-name` This way, it should be possible to check if the functions are in libgcc without requiring libc. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Resignation

Quoting Robert Millan : I'm sorry to hear that. I'd like to ask you to reconsider, and giving it a while before making it final. Would you do that? I'm sorry, but my decision is final. -- Regards, Pavel Roskin ___ Grub-devel ma

Resignation

have time. However, I cannot promise I'll reply to any pending e-mail. If there are any issues waiting for my response, please bring them to the list again. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.

Re: About firmware facilities

d? Patches are welcome. > > The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and > > how) you may access your data; but nobody's threatening your freedom: we > > still allow you to remove your data and not access it at all." > > S

Re: [PATCH] save_env variable_name=value

On Sat, 2009-09-12 at 09:54 -0500, richardvo...@gmail.com wrote: > On Fri, Sep 11, 2009 at 4:43 PM, Pavel Roskin wrote: > > I don't see how grub-mkconfig could compensate for a missing feature in > > save_env. Perhaps I'm missing the context here. > > AFAICT,

Re: [Fwd: Re: Bug#545460: segfault during update of grub-pc package]

alled with the NULL argument when going over the list. We need to understand how we get such an element in the list. Then we can think how to fix it. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: install-sh and docs/mdate-sh

e build system doesn't handle the documentation yet. It would be more useful to implement building of the documentation and then check is mdate-sh is still unused. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: grub-mkconfig fails on every non i386-pc because of gfxterm/vbe

ute for the knowledge whether they are actually functional on the target hardware. But if that's the simplest approach and it solves the original problem with all architectures other than i386-pc, then I'm fine with it. -- Regards, Pavel Roskin _

Re: [PATCH] fix an infinite loop with a corrupted pc partition table

> Any problems with this one? No objections. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Some ideas about new features of grub

arco and Pavel feel strongly about this. Please can you > comment? Ideally, I would prefer GRUB to have one scripting language. I just didn't have time and desire to argue against LUA inclusion. Having more code means more work for maintainers. -- Regards, Pavel Roskin

Re: [PATCH] save_env variable_name=value

issing feature in save_env. Perhaps I'm missing the context here. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] Clean up struct grub_module_header

`grub_module_header_types' should not be a field at all. Move enum outside struct. Keep using an 8-bit integer for `type', but make it unsigned. Remove all byteswapping for `type', as it only has one byte. Make `size' 32-bit, as grub-mkimage already assumes. 4 gigabytes should be enough for a

Re: grub-mkconfig fails on every non i386-pc because of gfxterm/vbe

ely on existence of modules. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Split big and little endian BeFS and AtheFS

ot;flags", yet we don't rename them to "unusedN". Apart from that, I'm fine with the patch. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: pc.mod -> part_msdos.mod (etc)

gt; If anyone has an objection, please say it now. No objection. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: grub-mkconfig fails on every non i386-pc because of gfxterm/vbe

; don't see why it would be default in mainstream Done. Sorry, I posted my reply before I found the message Felix was referring to. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Use common linker script for all i386-pc systems

On Tue, 2009-05-19 at 17:15 -0400, Pavel Roskin wrote: > I appreciate a lot of work you put into the Apple CC support, but your > patch complicates the code a lot. All features have a maintenance > cost. Somebody will need to fix your code when it breaks. > Considering that

Re: [PATCH] prevent duplicated entries due to symlinks

On Sun, 2009-05-10 at 00:20 +0200, Andreas wrote: > ping? > any problems still? I don't think anyone is really interested in that change. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailm

Re: grub-mkconfig fails on every non i386-pc because of gfxterm/vbe

On Fri, 2009-08-14 at 08:44 +0200, Felix Zielcke wrote: > Am Donnerstag, den 11.06.2009, 21:09 -0400 schrieb Pavel Roskin: > > Quoting Felix Zielcke : > > > > >> So you would prefer something like the attached patch? > > >> Though then we'll ne

Re: grub-mkconfig fails on every non i386-pc because of gfxterm/vbe

rub would disable gfxterm, and that should be OK. The only problem I see right now is that it's not documented in the textinfo documentation, so that users won't be able to figure it out without reading the code. -- Regards, Pavel Roskin

Re: [PATCH] Split big and little endian BeFS and AtheFS

h the split, but please use something more descriptive than U16, U32 and U64. Maybe fs_to_cpu16() etc. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Patch to compile boot.img properly on OSX

On Thu, 2009-08-13 at 02:24 -0400, Pavel Roskin wrote: > > Since Yves is interested perhaps he could do the "dirty job" of > > applying repetitive fixes and testing different images? And submit a > > patch then? > > Fine with me. I have fixed the *.img files o

Re: grub.cfg and core.img getting out of sync

the existing version in core.img cannot be used for that and we cannot keep grub.cfg backward compatible. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Patch to compile boot.img properly on OSX

. > Since Yves is interested perhaps he could do the "dirty job" of > applying repetitive fixes and testing different images? And submit a > patch then? Fine with me. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gn

Re: [PATCH] RFT: Rename local labels with a macro from boot/i386/pc/boot.S

ged LOCAL to be more similar to EXT_C (macro arguments don't normally use capital letters). I also added a comment, as there is no other way to know why we are adding "L_" to the labels. > Assuming Pavel is OK with it, I have no objection. Committed. Thank you! -- Regards

Re: [PATCH 2/2] RFT: Remove ABS macro from boot/i386/pc/boot.S

[remote rejected] master -> master (n/a (unpacker error)) error: failed to push some refs to 'git+ssh://repo.or.cz/srv/git/grub2.git' -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 1/2] RFT: Eliminate Apple specific code from boot/i386/pc/boot.S

On Thu, 2009-07-16 at 18:31 +0200, Vladimir 'phcoder' Serbinenko wrote: > On Thu, Jul 16, 2009 at 5:47 AM, Pavel Roskin wrote: > > ChangeLog: > > > >* boot/i386/pc/boot.S: Remove all code dependent on APPLE_CC. > >Use local labels start

Re: [PATCH 6/18] define asm constant for absolute memory access

out an explicit permissions form the maintainers. It's very time consuming to verify such code after it has been committed. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] move functionality of font_path() directly to util/grub-mkconfig.in and prefer unicode.pf2 over ascii.pf2

font file to check > > which characters it has. > > Ok here's a new one. Looks good to me. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] move functionality of font_path() directly to util/grub-mkconfig.in and prefer unicode.pf2 over ascii.pf2

Setting LANG=C seems unneeded in this case. After all, it's the user's choice, and we cannot examine the font file to check which characters it has. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] make 10_linux' test_gt() a bit more generic

ifier leads to the replacement being applied continuously until the last minus is consumed. The use of "g" wasn't warranted before, but it didn't have such effect. I'm committing the fix. -- Regards, Pavel Roskin ___ Grub-devel

Re: [PATCH] move functionality of font_path() directly to util/grub-mkconfig.in and prefer unicode.pf2 over ascii.pf2

setting, and I just don't see it, short or removing /usr/src/unifont.bdf and /usr/local/share/grub/unicode.pf2 so that they are never reinstalled or detected by GRUB. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Solving the grub-pe2elf problem

o do a binary build at this stage. Especially Windows users are at risk of messing things up if the entry barrier is lowered too much. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Solving the grub-pe2elf problem

It's a good idea, as it would unify Apple and Cygwin support to some degree. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 1/2] Relocator framework

. If we are using some feature that is just nice but not needed (such as binary & in lnxboot.S to set the image size to 1024), it would be better to avoid using that feature for all compilers rather than for the compilers that don't support it. -- Regards, Pavel Roskin _

Re: grub-pe2elf

o much a technical problem as an issue of trust. Committing code against the wish of maintainers should not be permitted. Those who do it should lose commit access. They are welcome to contribute, but their patches will need to be committed by others. I haven't seen any apology or expl

Re: grub-probe, but in reverse?

the meantime, a UUID of one of the partitions would do, as long as it's indeed unique. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Bug fix for LVM

t; > This new patch include the revert raid5_recover.c to r1828. Sorry for that! I have reverted that part of the patch, and I'm reviewing the whole commit for possible other errors of that kind. There is no need to combine reverts with other patches. An obvious mistake can be reverte

Re: [BUGFIX] Incorrect count of argument with rescue parser

{ 426 if (complete_arguments (buf)) 427 goto fail; 428 } (gdb) p current_word $1 = 0x21 (gdb) -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: Should the website still say that GRUB 2 is currently under development?

ecause Debian freezes at December. I don't see anything wrong with being "under development". I hope that GRUB 2 will be under development even after the 1.97. I don't see how Debian can have any problem with that. -- Regards, Pavel Roskin __

Re: Patch to compile boot.img properly on OSX

a request for testing. Besides, this patch only fixes one file. We have several images that need the same treatment. Also, the problem with lnxboot.S spilled into the build system. This will need to be cleaned up as well. -- Regards, Pavel Roskin

Re: [PATCH] gfxterm clear_char

on should be 2 spaces, not 4. >for(i = 0; i < virtual_screen.columns * virtual_screen.rows; i++) > { This brace is no longer needed. > Index: src/ChangeLog It would be more convenient if the ChangeLog entry is posted inline rather than insi

Re: grub-probe, but in reverse?

uggest that you use UUID instead. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: menuentrys with special or non-ASCII chars aren't displayed

ese, Vietnamese and German characters is displayed correctly. The same applies to a menu item consisting only of Chinese characters. Maybe your menu title has incorrect UTF-8 sequences? -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel

Re: [PATCH] fix an infinite loop with a corrupted pc partition table

than enough. I would hate to get caught in another discussion about minor issues when we have a real problem in that code. GRUB only follows a single chain of extended partitions rather than a tree of links. I think the whole point in having the Linux extended partition type is to allow it to coe

Re: [PATCH 2/2] SDL support

On Sat, 2009-07-25 at 18:26 +0200, Robert Millan wrote: > On Thu, Jul 23, 2009 at 08:19:24PM -0400, Pavel Roskin wrote: > > > > Also, when compiling on PowerPC, configure reports that SDL is enabled, > > but it is not. The same applies to USB support. > > Sho

Re: [BUGFIX] Don't use DT_DIR: It doesn't work on non-ext* filesystems

. DT_UNKNOWN is present. Perhaps the above line should be else if (de->type != DT_UNKNOWN) We only care if it's a directory or not. All other objects can be treated like files. I'm fine either way, whether we fix the "high-performance" code or remove it, as long as we don

Re: [PATCH] fix an infinite loop with a corrupted pc partition table

ith pc partitions is that AFAIK there is no normative > standard for it, only descriptive documents Yes, it's a typical "industry standard" :-( -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [Fwd: Re: Bug#495949: grub-common: grub-probe segfaults]

, so it would be fair if you apply your part under your name. Just please use a better description in the ChangeLog. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [Fwd: Re: Bug#495949: grub-common: grub-probe segfaults]

On Fri, 2009-07-24 at 16:09 -0400, Pavel Roskin wrote: > On Fri, 2009-07-24 at 20:46 +0200, Felix Zielcke wrote: > > And another bug forward > > Anyone has an idea why a dm-crypt/lvm leads to a segfault in the strcmp > > here: > > grub_partition_iterate (dest_dev-&

Re: [PATCH] fix an infinite loop with a corrupted pc partition table

s backwards should be allowed? -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [Fwd: Re: Bug#495949: grub-common: grub-probe segfaults]

dest_partmap with NULL. If it becomes "pc_partition_map", iterate with find_usable_region_msdos, if it becomes "gpt_partition_map", iterate with find_usable_region_gpt. If it's NULL or another string, exit with a warning. -- Regards, Pavel Roskin __

Re: [PATCH] fix an infinite loop with a corrupted pc partition table

continue; + if (! pcdata.ext_offset) pcdata.ext_offset = p.offset; -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [Fwd: Bug#536846: grub-pc: /boot/vmlinux entry cannot be booted]

ady to apply a patch to 10_linux.in that is based on research for all platforms supported by GRUB. I'm sorry, I have no time to research it myself at the moment. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://li

Re: [Fwd: Bug#536846: grub-pc: /boot/vmlinux entry cannot be booted]

ider the architecture in 10_linux.in. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 2/2] SDL support

On Thu, 2009-07-23 at 22:44 +0200, Vladimir 'phcoder' Serbinenko wrote: > On Thu, Jul 23, 2009 at 10:32 PM, Pavel Roskin wrote: > > On Thu, 2009-07-23 at 11:49 +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Hello. Here is already-discussed SDL suppor

Re: Fwd: [PATCH 1/2] Framebuffer split

The comment says: /* Get information about active video mode. */ Likewise, all occurrences of "get_info_and_fini" should probably be replaced with something more descriptive. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-de

Re: [PATCH 2/2] Alias cls as clear

; So I leave this to the maintainers: do we add both commands, only one, > or > neither? Let's have "clear" only, as it's more clear :-) Please include the ChangeLog entry. -- Regards, Pavel Roskin ___ Grub-devel mailing

Re: [BUGFIX] Don't use DT_DIR: It doesn't work on non-ext* filesystems

mber of preprocessor directives :-) -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [RFC, PATCH] C99 format specifiers for fixed-length integer types

o anticipate what other platforms we may support. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] zero-fill entry before asking BIOS for memory map

:DI */ addl$4, %eax movl%eax, %edi I don't know whether it would interfere with the Apple CC workaround. It would be great if we get rid of it, perhaps by using labels starting with "L_". -- Regards, Pavel Roskin __

Re: [PATCH] Check for the appropriate condition in types.h

low 4GiB (see my mm propositions for more on how > to ensure it). But I'm ok with requirement of additional explicit cast > in such cases as > (grub_uint32_t) PTR_TO_UINT (x) That would be much better that PTR_TO_UINT32, as it makes the cast explicit in the code that should ensure th

Re: [PATCH 2/2] SDL support

ecides whether SDL support will be in grub-emu. Since it's the default, maybe it's better to describe --disable-grub-emu-sdl. Obviously, it applies to grub-emu-usb as well, I just didn't have a chance to clean it up. -- Regards, Pavel Roskin _

Re: [RFC, PATCH] C99 format specifiers for fixed-length integer types

e formats. Maybe a new C standard appears with new format specifications. Maybe gcc will add some checks. But as it stands now, we won't benefit from it enough to justify less readable code. Let's move on and work on the issues where we can make the difference now. -- Regards, Pavel

Re: [PATCH] Check for the appropriate condition in types.h

ine a cast to a scalar type with a cast to change the type precision. By eliminating the second cast, we make it possible for the compiler to catch precision loss. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] lua: change grub.file_seek() to return error code, not the old offset

This makes it easier to check if the call has succeeded. The old offset is rarely needed. ChangeLog: * script/lua/grub_lib.c (grub_lua_file_seek): Return error code, not the old offset. --- script/lua/grub_lib.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) d

Re: [PATCH 3/4] Change grub_file_seek() to return grub_err_t

On Thu, 2009-07-23 at 10:23 +0200, Vladimir 'phcoder' Serbinenko wrote: > On Wed, Jul 22, 2009 at 5:16 AM, Pavel Roskin wrote: > > No callers need the previous offset. Returning -1 with implicit cast to > > grub_off_t required a cast just to check for errors. This also

Re: [PATCH] Check for the appropriate condition in types.h

the same, this > change is guaranteed not to create any problems, while it might avoid > them in the future. The patch is good. Please include the ChangeLog entry. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [RFC,PATCH] C99 format specifiers for fixed-length integer types

On Thu, 2009-07-23 at 04:03 +0200, Javier Martín wrote: > El mié, 22-07-2009 a las 21:08 -0400, Pavel Roskin escribió: > > I doubt about "runtime weirdness". gcc is good at catching such > > problems at the compile time. > Yes, in naked expressions. However, onc

Re: [RFC,PATCH] C99 format specifiers for fixed-length integer types

f you put GRUB_PRI32o instead of GRUB_PRI16o there, the compiler won't tell you anything. The patch includes the easy part, namely adding the macros. But I doesn't think it would be so pretty with the ugly part, that is, "fixing" every almost every *printf call. It will be very

Re: [PATCH] Fix chainloding + Chainloading into logical partitions

I'm sure bugs can be fixed separately. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Call a module's init function only after the module is successfully added

On Wed, 2009-07-22 at 19:36 +0200, Robert Millan wrote: > On Tue, Jul 21, 2009 at 04:02:48PM -0400, Pavel Roskin wrote: > > > > By the way, kern/dl.c have some unused functions (grub_dl_unload_all). > > grub_machine_fini() used to rely on this, but at some point we conclud

Re: [PATCH] UUID support for UFS

%08lx", > > + (unsigned long) grub_le_to_cpu32 (data->sblock.uuidhi), > > + (unsigned long) grub_le_to_cpu32 (data->sblock.uuidlow)); > > Is this really being interpreted as mixed endian by other programs? I also wondered about it. Yes, it's &q

Re: [PATCH] Fix when installing on pationless but partionable medium

On Wed, 2009-07-22 at 19:43 +0200, Vladimir 'phcoder' Serbinenko wrote: > On Wed, Jul 22, 2009 at 7:36 PM, Pavel Roskin wrote: > > On Wed, 2009-07-22 at 19:16 +0200, Robert Millan wrote: > > boot.img has holes for FAT and PC MBR. That's two configurations we &g

Re: [PATCH] Fix when installing on pationless but partionable medium

(0x80) or unset (0x0) and not another value > > Oh, that's different. I think it's fine provided that: > > - None of the commonly used free partitioning tools uses an illegal value. > > - We fail gracefully and let the user know why. I'm fine with extra checks. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Fix when installing on pationless but partionable medium

re that there is some partitioning on the hard driver. boot.img has holes for FAT and PC MBR. That's two configurations we support. No other partition tables or filesystems are supported. -- Regards, Pavel Roskin ___ Grub-devel mailing list Gr

Re: [PATCH] Build system improvement

p to disable warnings would tell users to be more careful. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 4/4] Fix ALIGN_UP cutting upper bits

If align is unsigned int, ~(align - 1) will also be unsigned int and will cut addr to 32 bits. Cast align to the type of addr. This also avoid 64-bit calculations if addr is 32-bit. ChangeLog: * include/grub/misc.h (ALIGN_UP): Cast align to the type of addr to avoid loss of uppe

[PATCH 3/4] Change grub_file_seek() to return grub_err_t

No callers need the previous offset. Returning -1 with implicit cast to grub_off_t required a cast just to check for errors. This also makes grub_file_seek() more similar to fseek(). ChangeLog: * kern/file.c (grub_file_seek): Return grub_err_t. Adjust all callers that check the

[PATCH 2/4] Fix insmod not to increase refcount above 1

grub_dl_get() can return non-NULL for an already loaded module. insmod should not increase it refcount. Only increase refcount if the module is newly loaded or if the module is unused and autoloaded, so that it won't get unloaded automatically. It's not perfect, but close enough. insmod won't l

[PATCH 1/4] Handle errors in rmmod

ChangeLog: * commands/minicmd.c (grub_mini_cmd_rmmod): Check the result of grub_dl_unload(), but not of grub_dl_unref(). On failure, restore reference count and report error. --- commands/minicmd.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --

[PATCH 3/3] Merge struct grub_dl_list into struct grub_dl

There is no need to keep a separate list of the modules. It requires additional memory allocation and additional error handling. Now grub_dl_add() can only fail if the module is already loaded. ChangeLog: * include/grub/dl.h (struct grub_dl): Add next field. * kern/dl.c: Remove

[PATCH 2/3] Eliminate grub_dl_call_init()

It's just two lines long and there is only one caller. Besides, there is no equivalent for mod->fini. ChangeLog: * kern/dl.c (grub_dl_call_init): Remove. (grub_dl_load_core): Call mod->init directly. --- kern/dl.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(

[PATCH 1/3] Don't initialize module before grub_dl_add() succeeds

ChangeLog: * kern/dl.c (grub_dl_load_core): Call grub_dl_call_init() only after grub_dl_add() succeeds. Set mod->ref_count to 1 later to allow grub_dl_unload() to work. Original patch by Joe Auricchio --- kern/dl.c | 14 +- 1 files changed, 5 insert

Re: [PATCH] UUID support for UFS

call attention to themselves: an unknowing programmer would > wonder what they are. Using a "normal" print specifier and a type cast > does not. OK, if you can do it if you want. It would be great if you fix some real bugs in process. -- Regards, Pavel Roskin

Re: [PATCH] UUID support for UFS

be introduced by that change, not fixed. Besides, the code will be harder to read. I'm not going to participate in this discussion anymore. I'm working on a real bug in the rmmod command that exists right now. It's more important than fixing potential bu

Re: [PATCH] UUID support for UFS

that *printf doesn't need to be modified. > Instead we could just define somewhere: > GRUB_PRIx32 "%x" Better yet, "x", as in libc. That would allow for "%08x" that we need for UUID. But I would prefer that w

Re: [PATCH] UUID support for UFS

On Tue, 2009-07-21 at 20:46 +0200, Javier Martín wrote: > Vladimir 'phcoder' Serbinenko escribió: > > On Tue, Jul 21, 2009 at 7:14 PM, Pavel Roskin wrote: > >> On Tue, 2009-07-21 at 15:03 +0200, Vladimir 'phcoder' Serbinenko wrote: > &g

Re: [PATCH] Support FreeBSD in osdetect.lua

ould hate to see five lines for every Linux kernel (although it would be nice to have safe mode for Windows in the GRUB menu). So this should not be an example for other OSes. Obviously, the zfs part shouldn't go in yet. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Call a module's init function only after the module is successfully added

On Tue, 2009-07-21 at 16:02 -0400, Pavel Roskin wrote: > By the way, kern/dl.c have some unused functions (grub_dl_unload_all). I was wrong, I didn't check assembler files. > Also, it looks like the memory for the module information (grub_dl_t) is > allocated twice - first in gru

Re: [PATCH] UUID support for UFS

On Tue, 2009-07-21 at 22:01 +0200, Vladimir 'phcoder' Serbinenko wrote: > On Tue, Jul 21, 2009 at 7:14 PM, Pavel Roskin wrote: > > On Tue, 2009-07-21 at 15:03 +0200, Vladimir 'phcoder' Serbinenko wrote: > >> + grub_sprintf (*uuid, "%08lx%08l

Re: [PATCH] Call a module's init function only after the module is successfully added

t_t. grub_dl_load() can return either memory from the list that shouldn't be freed by the caller, or the result of grub_dl_load_file(), which is allocated and is not referenced anywhere. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] UUID support for UFS

d. Linux kernel doesn't print UUID at all. I would add a dash between the numbers to make it more readable unless there is a precedent where the dash is not used. Apart from that, the code looks good and the result matches the output of dumpfs. -- Regards, Pavel Roskin _

Re: [PATCH] Support FreeBSD in osdetect.lua

uot;. I don't know if it's possible, but it could be useful. Actually, I don't want osdetect.lua to be overengineered and overloaded with intimate knowledge of different OSes. It's an example for others to extend, not a complete solution. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] xfs bug fix

implifies error handling and keeps the code short. If a bigger chunk of memory needs to be allocated, use grub_realloc(). Please avoid non-descriptive labels like "fail_2". -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

  1   2   3   4   5   6   7   8   9   10   >