Re: [PATCH] (pxe:server_ip:gateway_ip) parsing wrong?

2010-06-07 Thread Seth Goldberg
Quoting Colin Watson, who wrote the following on Mon, 7 Jun 2010: Oh, and speaking of PXE support, what's the point of the pxe_unload command? As near as I can tell, it seems to be the equivalent of 'rmmod pxe'. Is there some reason one might want to run this if pxe were built into the core

Re: [PATCH] (pxe:server_ip:gateway_ip) parsing wrong?

2010-06-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 06/07/2010 06:58 PM, Colin Watson wrote: > While writing documentation for booting GRUB over the network, I noticed > that the code to handle (pxe:server_ip:gateway_ip) device names looks > wrong. Shouldn't it be like this? > > Go ahead. > 2010-06-07 Colin Watson > > * fs/i386/pc/px

Re: [PATCH] (pxe:server_ip:gateway_ip) parsing wrong?

2010-06-07 Thread Colin Watson
Oh, and speaking of PXE support, what's the point of the pxe_unload command? As near as I can tell, it seems to be the equivalent of 'rmmod pxe'. Is there some reason one might want to run this if pxe were built into the core image, or is it cruft that we should remove? -- Colin Watson

[PATCH] (pxe:server_ip:gateway_ip) parsing wrong?

2010-06-07 Thread Colin Watson
While writing documentation for booting GRUB over the network, I noticed that the code to handle (pxe:server_ip:gateway_ip) device names looks wrong. Shouldn't it be like this? 2010-06-07 Colin Watson * fs/i386/pc/pxe.c (grub_pxe_open): Fix parsing of gateway_ip. === modified file 'f