[PATCH] Better ahci error handling

2018-01-02 Thread Stefan Fritsch
Hi, on a Fujitsu E744 laptop we have a problem that sometimes there is a very long delay (up to several minutes) when booting from hard disk. It seems accessing the DVD drive (which has no disk inserted) sometimes fails with some errors that are not correctly handled by grub, which leads to each a

Re: [PATCH] Better ahci error handling

2018-01-02 Thread Michel Hermier
Hi, IS_FATAL_ERROR sounds like a utility macro, I would add a parameter to test the flags and make it return a Bool compatible value. My 2 cents comments. Cheers Le 2 janv. 2018 11:05, "Stefan Fritsch" a écrit : Hi, on a Fujitsu E744 laptop we have a problem that sometimes there is a very long

Re: [PATCH] Better ahci error handling

2018-01-03 Thread Stefan Fritsch
On Tue, 2 Jan 2018, Michel Hermier wrote: > Hi, > IS_FATAL_ERROR sounds like a utility macro, I would add a parameter to test > the flags and make it return a Bool compatible value. > My 2 cents comments. > Cheers Yes, the IS_FATAL_ERROR name is not good. I have renamed it to GRUB_AHCI_HBA_PORT_

Re: [PATCH] Better ahci error handling

2018-01-08 Thread Daniel Kiper
On Wed, Jan 03, 2018 at 11:36:29AM +0100, Stefan Fritsch wrote: > On Tue, 2 Jan 2018, Michel Hermier wrote: > > > Hi, > > IS_FATAL_ERROR sounds like a utility macro, I would add a parameter to test > > the flags and make it return a Bool compatible value. > > My 2 cents comments. > > Cheers > > Yes