Re: [PATCH] Enable pager by default

2019-10-30 Thread Javier Martinez Canillas
On 10/30/19 1:12 PM, Daniel Kiper wrote: > On Fri, Oct 25, 2019 at 11:02:04AM +0200, Javier Martinez Canillas wrote: [snip] >> >> But I'll wait for the discussion to settle and a solution to be agreed upon, >> before posting a new patch for this. > > After some thinking it seems to me that Valdi

Re: [PATCH] Enable pager by default

2019-10-30 Thread adrian15 adrian15
I agree. One of the Super Grub2 Disk options consists on showing from its menu the COPYRIGHT page... the pager variable is set to true so that the output is paged when the cat command is run. This usecase might not work anymore if something else than prompting a message on the interactive screen w

Re: [PATCH] Enable pager by default

2019-10-30 Thread Daniel Kiper
On Fri, Oct 25, 2019 at 11:02:04AM +0200, Javier Martinez Canillas wrote: > Hello Daniel, > > On 10/24/19 4:50 PM, Daniel Kiper wrote: > > [snip] > > >> > >> From 7c4da6295ebd3a034d1f7e32099eab33efa465d4 Mon Sep 17 00:00:00 2001 > >> From: Javier Martinez Canillas > >> Date: Tue, 22 Oct 2019 15:35

Re: [PATCH] Enable pager by default

2019-10-27 Thread Michael Chang
On Fri, Oct 25, 2019 at 08:48:05AM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Fri, 25 Oct 2019, 08:20 Michael Chang, wrote: > > > On Thu, Oct 24, 2019 at 04:39:09PM +0200, Daniel Kiper wrote: > > > On Thu, Oct 24, 2019 at 06:54:53AM +, Michael Chang wrote: > > > > On Tue, Oct 22, 2019 a

Re: [PATCH] Enable pager by default

2019-10-25 Thread Javier Martinez Canillas
Hello Daniel, On 10/24/19 4:50 PM, Daniel Kiper wrote: [snip] >> >> From 7c4da6295ebd3a034d1f7e32099eab33efa465d4 Mon Sep 17 00:00:00 2001 >> From: Javier Martinez Canillas >> Date: Tue, 22 Oct 2019 15:35:12 +0200 >> Subject: [PATCH v2] Add a GRUB_COMMAND_FLAG_PAGINATED to request paginated >>

Re: [PATCH] Enable pager by default

2019-10-25 Thread Vladimir 'phcoder' Serbinenko
On Fri, 25 Oct 2019, 08:20 Michael Chang, wrote: > On Thu, Oct 24, 2019 at 04:39:09PM +0200, Daniel Kiper wrote: > > On Thu, Oct 24, 2019 at 06:54:53AM +, Michael Chang wrote: > > > On Tue, Oct 22, 2019 at 04:04:28PM +0200, Daniel Kiper wrote: > > > > On Tue, Oct 22, 2019 at 10:30:20AM +0200,

Re: [PATCH] Enable pager by default

2019-10-24 Thread Michael Chang
On Thu, Oct 24, 2019 at 04:39:09PM +0200, Daniel Kiper wrote: > On Thu, Oct 24, 2019 at 06:54:53AM +, Michael Chang wrote: > > On Tue, Oct 22, 2019 at 04:04:28PM +0200, Daniel Kiper wrote: > > > On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canillas wrote: > > > > Hello Daniel, > >

Re: [PATCH] Enable pager by default

2019-10-24 Thread Vladimir 'phcoder' Serbinenko
What is the advantage of having -p versus just using pager=1? We should not duplicate functionality. It increases code size with no benefit. The easiest solution for informing the user is to add it to stating prompt in GRUB console On Thu, Oct 24, 2019 at 6:07 PM Daniel Kiper wrote: > > On Wed, O

Re: [PATCH] Enable pager by default

2019-10-24 Thread Daniel Kiper
On Wed, Oct 23, 2019 at 01:26:54PM +0200, Javier Martinez Canillas wrote: > Hello Daniel, > > On 10/22/19 4:04 PM, Daniel Kiper wrote: > > On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canillas wrote: > >> Hello Daniel, > >> > >> On 10/21/19 4:56 PM, Daniel Kiper wrote: > >>> On Fri, Oc

Re: [PATCH] Enable pager by default

2019-10-24 Thread Daniel Kiper
On Thu, Oct 24, 2019 at 06:54:53AM +, Michael Chang wrote: > On Tue, Oct 22, 2019 at 04:04:28PM +0200, Daniel Kiper wrote: > > On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canillas wrote: > > > Hello Daniel, > > > > > > On 10/21/19 4:56 PM, Daniel Kiper wrote: > > > > On Fri, Oct 1

Re: [PATCH] Enable pager by default

2019-10-23 Thread Michael Chang
On Tue, Oct 22, 2019 at 04:04:28PM +0200, Daniel Kiper wrote: > On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canillas wrote: > > Hello Daniel, > > > > On 10/21/19 4:56 PM, Daniel Kiper wrote: > > > On Fri, Oct 18, 2019 at 02:43:18PM +0200, Javier Martinez Canillas wrote: > > >> From: P

Re: [PATCH] Enable pager by default

2019-10-23 Thread Javier Martinez Canillas
Hello Daniel, On 10/22/19 4:04 PM, Daniel Kiper wrote: > On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canillas wrote: >> Hello Daniel, >> >> On 10/21/19 4:56 PM, Daniel Kiper wrote: >>> On Fri, Oct 18, 2019 at 02:43:18PM +0200, Javier Martinez Canillas wrote: From: Peter Jones >

Re: [PATCH] Enable pager by default

2019-10-22 Thread Nicholas Vinson
On 10/22/19 10:04, Daniel Kiper wrote: On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canillas wrote: Hello Daniel, On 10/21/19 4:56 PM, Daniel Kiper wrote: On Fri, Oct 18, 2019 at 02:43:18PM +0200, Javier Martinez Canillas wrote: From: Peter Jones When user enters into the GRU

Re: [PATCH] Enable pager by default

2019-10-22 Thread Daniel Kiper
On Tue, Oct 22, 2019 at 10:30:20AM +0200, Javier Martinez Canillas wrote: > Hello Daniel, > > On 10/21/19 4:56 PM, Daniel Kiper wrote: > > On Fri, Oct 18, 2019 at 02:43:18PM +0200, Javier Martinez Canillas wrote: > >> From: Peter Jones > >> > >> When user enters into the GRUB shell and tries to us

Re: [PATCH] Enable pager by default

2019-10-22 Thread Javier Martinez Canillas
Hello Daniel, On 10/21/19 4:56 PM, Daniel Kiper wrote: > On Fri, Oct 18, 2019 at 02:43:18PM +0200, Javier Martinez Canillas wrote: >> From: Peter Jones >> >> When user enters into the GRUB shell and tries to use help command, lot of >> information is scrolled out of screen and the user doesn't ha

Re: [PATCH] Enable pager by default

2019-10-21 Thread Daniel Kiper
On Fri, Oct 18, 2019 at 02:43:18PM +0200, Javier Martinez Canillas wrote: > From: Peter Jones > > When user enters into the GRUB shell and tries to use help command, lot of > information is scrolled out of screen and the user doesn't have chance to > read it. Also, there isn't any information abou

[PATCH] Enable pager by default

2019-10-18 Thread Javier Martinez Canillas
From: Peter Jones When user enters into the GRUB shell and tries to use help command, lot of information is scrolled out of screen and the user doesn't have chance to read it. Also, there isn't any information about 'set pager=1' at the end of the help output, to tell the user how scrolling could