Re: [PATCH] Fix bad test on GRUB_DISABLE_SUBMENU.

2019-09-20 Thread Daniel Kiper
On Thu, Sep 19, 2019 at 02:42:05PM +0200, Javier Martinez Canillas wrote: > Hello Daniel, > > On 9/18/19 2:53 PM, Daniel Kiper wrote: > > On Tue, Sep 17, 2019 at 05:52:10PM +0200, Javier Martinez Canillas wrote: > >> From: Prarit Bhargava > >> > >> The file /etc/grub.d/10_linux does > >> > >> if [

Re: [PATCH] Fix bad test on GRUB_DISABLE_SUBMENU.

2019-09-19 Thread Javier Martinez Canillas
Hello Daniel, On 9/18/19 2:53 PM, Daniel Kiper wrote: > On Tue, Sep 17, 2019 at 05:52:10PM +0200, Javier Martinez Canillas wrote: >> From: Prarit Bhargava >> >> The file /etc/grub.d/10_linux does >> >> if [ "x$is_top_level" = xtrue ] && [ "x${GRUB_DISABLE_SUBMENU}" != xy ]; then >> >> when it sho

Re: [PATCH] Fix bad test on GRUB_DISABLE_SUBMENU.

2019-09-18 Thread Daniel Kiper
On Tue, Sep 17, 2019 at 05:52:10PM +0200, Javier Martinez Canillas wrote: > From: Prarit Bhargava > > The file /etc/grub.d/10_linux does > > if [ "x$is_top_level" = xtrue ] && [ "x${GRUB_DISABLE_SUBMENU}" != xy ]; then > > when it should do > > if [ "x$is_top_level" = xtrue ] && [ "x${GRUB_DISABLE

[PATCH] Fix bad test on GRUB_DISABLE_SUBMENU.

2019-09-17 Thread Javier Martinez Canillas
From: Prarit Bhargava The file /etc/grub.d/10_linux does if [ "x$is_top_level" = xtrue ] && [ "x${GRUB_DISABLE_SUBMENU}" != xy ]; then when it should do if [ "x$is_top_level" = xtrue ] && [ "x${GRUB_DISABLE_SUBMENU}" != xtrue ]; then which results in submenus in /boot/grub2/grub.cfg when GRUB