On Feb 7, 2008 3:18 AM, Robert Millan <[EMAIL PROTECTED]> wrote:
> On Wed, Feb 06, 2008 at 03:29:45PM +0800, Bean wrote:
> > > This patch fixes both issues.
> >
> > Actually, the first version of grub_cpio_find_file returned
> > GRUB_ERR_FILE_NONE when the end of file is encounter, but then,
> > so
On Wed, Feb 06, 2008 at 03:29:45PM +0800, Bean wrote:
> > This patch fixes both issues.
>
> Actually, the first version of grub_cpio_find_file returned
> GRUB_ERR_FILE_NONE when the end of file is encounter, but then,
> somebody find out that opening non existent file have problem, and the
> resul
Robert Millan wrote:
2008-02-05 Christian Franke <[EMAIL PROTECTED]>
* fs/cpio.c (grub_cpio_find_file): Return GRUB_ERR_NONE
and (*ofs = 0) instead of GRUB_ERR_FILE_NOT_FOUND on last
I would suggest "(and set *ofs = 0)" here to make it clearer.
OK.
2008-02-06
Hi Robert,
you wrote:
> On Wed, Feb 06, 2008 at 12:02:37AM +0100, Christian Franke wrote:
> > Two issues found in current CVS:
> >
> > 1. Booting a grub2-mkrescue floppy crashes if
> > "(memdisk)/boot/grub/grub.cfg" does not exist. This is because
> > grub_cpio_open does not set grub_errno if a f
On Feb 6, 2008 7:02 AM, Christian Franke <[EMAIL PROTECTED]> wrote:
> Two issues found in current CVS:
>
> 1. Booting a grub2-mkrescue floppy crashes if
> "(memdisk)/boot/grub/grub.cfg" does not exist. This is because
> grub_cpio_open does not set grub_errno if a file does not exist.
>
> 2. The cpi
Hi Christian,
On Wed, Feb 06, 2008 at 12:02:37AM +0100, Christian Franke wrote:
> Two issues found in current CVS:
>
> 1. Booting a grub2-mkrescue floppy crashes if
> "(memdisk)/boot/grub/grub.cfg" does not exist. This is because
> grub_cpio_open does not set grub_errno if a file does not exis
Two issues found in current CVS:
1. Booting a grub2-mkrescue floppy crashes if
"(memdisk)/boot/grub/grub.cfg" does not exist. This is because
grub_cpio_open does not set grub_errno if a file does not exist.
2. The cpio format may not work. Header scan finishes early if data size
is empty (di
