Re: [PATCH] Fix packing issue of machine_mmap_entry

2007-11-17 Thread Robert Millan
On Sat, Nov 10, 2007 at 04:55:45PM +0100, Marco Gerards wrote: 2007-11-09 Christian Franke [EMAIL PROTECTED] * include/grub/i386/pc/init.h (struct grub_machine_mmap_entry): Add attribute packed, gcc 3.4.4 on Cygwin aligns this to 64 bit boundary by default. This looks

Re: [PATCH] Fix packing issue of machine_mmap_entry

2007-11-10 Thread Marco Gerards
Christian Franke [EMAIL PROTECTED] writes: Marco Gerards wrote: ... Add compile time assert to check packing. Can you remove the compile time assert? Done. We usually check stuff like this using configure. If you can send in a patch for configure.ac, that would be appreciated.

Re: [PATCH] Fix packing issue of machine_mmap_entry

2007-11-09 Thread Marco Gerards
Christian Franke [EMAIL PROTECTED] writes: First patch related to the Cygwin port: struct machine_mmap_entry is sensitive to packing of 64 bit values which apparently differs between gcc releases. Thanks! Christian 2007-10-22 Christian Franke [EMAIL PROTECTED] *

Re: [PATCH] Fix packing issue of machine_mmap_entry

2007-10-23 Thread Christian Franke
Robert Millan wrote: ... +/* Compile time assert to check packing */ +typedef char ASSERT_sizeof_grub_machine_mmap_entry[ + sizeof (struct grub_machine_mmap_entry) == 4+8+8+4 ? 1 : -1]; Nice, I didn't know you could do compile time assertion in C. But is it really necessary to check

[PATCH] Fix packing issue of machine_mmap_entry

2007-10-22 Thread Christian Franke
First patch related to the Cygwin port: struct machine_mmap_entry is sensitive to packing of 64 bit values which apparently differs between gcc releases. Christian 2007-10-22 Christian Franke [EMAIL PROTECTED] * include/grub/i386/pc/init.h (struct grub_machine_mmap_entry):