Re: [PATCH] Huge changes in mm.c

Hollis Blanchard <[EMAIL PROTECTED]> writes: > On Jul 12, 2005, at 8:41 AM, Vincent Pelletier wrote: >> >> Marco Gerards wrote: >>> So with this change all problems are fixed? In that case this patch >>> needs to be committed. >> >> No I can read files from an ext2 partition on sparc64. >> What's

Re: [PATCH] Huge changes in mm.c

On Jul 12, 2005, at 8:41 AM, Vincent Pelletier wrote: Marco Gerards wrote: So with this change all problems are fixed? In that case this patch needs to be committed. No I can read files from an ext2 partition on sparc64. What's the next step ? :) Loading modules ? I don't know exactly how to

Re: [PATCH] Huge changes in mm.c

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Marco Gerards wrote: > So with this change all problems are fixed? In that case this patch > needs to be committed. No I can read files from an ext2 partition on sparc64. What's the next step ? :) Loading modules ? I don't know exactly how to make a

Re: [PATCH] Huge changes in mm.c

Vincent Pelletier <[EMAIL PROTECTED]> writes: >> At a quick glance, one trivial bug is that GRUB_MM_ALIGN_LOG2 is set to 8 on >> 64-bit systems. This must be 5. > > Works 8|... So with this change all problems are fixed? In that case this patch needs to be committed. -- Marco __

Re: [PATCH] Huge changes in mm.c

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Yoshinori K. Okuji wrote: > Basically, I do not want huge changes, unless you have a good reason to do > it. One of the reasons that made me study mm.c it that I get an unaligned pointer when I type "rescue". Built from current cvs & tested with :

Re: [PATCH] Huge changes in mm.c

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Vincent Guffens wrote: > Vincent Pelletier wrote: > It must be released by the one who called the malloc. I don't see any good reason to forget - on kernel side - this chunk, as we still keep the struct member in memory. Anyway, I've done some other m

Re: [PATCH] Huge changes in mm.c

Since I have no time at the moment, I will write a short comment. Basically, I do not want huge changes, unless you have a good reason to do it. The current implementation has been tested intensively, is very stable, and I see no missing functionality in it. Please do not reinvent a wheel only

Re: [PATCH] Huge changes in mm.c

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Marco Gerards wrote: > What do you mean with defragmenting? I think you mean joining freed > regions, which should be done at the time it is freed. I always > thought that was the case already. I'll add the line, and I might change the defrag functi

Re: [PATCH] Huge changes in mm.c

Vincent Pelletier wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi. In my attempt to port grub 2 to usparc, I had big problems with all the memory allocation things, so I decided to rewrite the functions after reading them (I wasn't able to understand at all 20% of the code). Some comme

Re: [PATCH] Huge changes in mm.c

Vincent Pelletier <[EMAIL PROTECTED]> writes: Hi Vincent, > I've added a defrag function that merges consecutive free chunks. It's > pretty fast (O(N), N=number of chunks) but I only call it when needed... > Maybe could it be interesting to call it on each grub_free(). What do you mean with defr

[PATCH] Huge changes in mm.c

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi. In my attempt to port grub 2 to usparc, I had big problems with all the memory allocation things, so I decided to rewrite the functions after reading them (I wasn't able to understand at all 20% of the code). Some comments : It *seems* that befor