Re: [PATCH] Make grub_strtoul() "end" pointer have the right const params.

2020-02-21 Thread Peter Jones
On Tue, Feb 18, 2020 at 10:39:07PM -0500, Nicholas Vinson wrote: > On 2/18/20 19:32, Peter Jones wrote: > > On Tue, Feb 04, 2020 at 08:04:30PM -0500, Nicholas Vinson wrote: > > > On 2/4/20 16:02, Peter Jones wrote: > > > > grub_strtoul() and grub_strtoull() don't make the /pointer/ to "end" be > >

Re: [PATCH] Make grub_strtoul() "end" pointer have the right const params.

2020-02-18 Thread Nicholas Vinson
On 2/18/20 19:32, Peter Jones wrote: On Tue, Feb 04, 2020 at 08:04:30PM -0500, Nicholas Vinson wrote: On 2/4/20 16:02, Peter Jones wrote: grub_strtoul() and grub_strtoull() don't make the /pointer/ to "end" be const like normal implementations do, and as a result, at many places in grub_strto

Re: [PATCH] Make grub_strtoul() "end" pointer have the right const params.

2020-02-18 Thread Peter Jones
On Tue, Feb 04, 2020 at 08:04:30PM -0500, Nicholas Vinson wrote: > On 2/4/20 16:02, Peter Jones wrote: > > grub_strtoul() and grub_strtoull() don't make the /pointer/ to "end" be > > const like normal implementations do, and as a result, at many places in > > grub_strtoul() and grub_strtoull() app

Re: [PATCH] Make grub_strtoul() "end" pointer have the right const params.

2020-02-04 Thread Nicholas Vinson
On 2/4/20 16:02, Peter Jones wrote: grub_strtoul() and grub_strtoull() don't make the /pointer/ to "end" be const like normal implementations do, and as a result, at many places in grub_strtoul() and grub_strtoull() appear to be patterned after the C standard functions strtoul() and strtoull()

[PATCH] Make grub_strtoul() "end" pointer have the right const params.

2020-02-04 Thread Peter Jones
grub_strtoul() and grub_strtoull() don't make the /pointer/ to "end" be const like normal implementations do, and as a result, at many places in the tree, people appear to have abandoned trying to figure out C's syntax and instead of fixing it, chosen to cast a mutable pointer to an immutable array