On Jan 29, 2008 5:10 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> Bean <[EMAIL PROTECTED]> writes:
>
> > add two sanity check, one for chuck size, make sure the on disk
> > structure is correct, one for raw image, make sure the image won't
> > overflown. also adjust a few macro names and the filt
Bean <[EMAIL PROTECTED]> writes:
> add two sanity check, one for chuck size, make sure the on disk
> structure is correct, one for raw image, make sure the image won't
> overflown. also adjust a few macro names and the filter handling code.
>
> * conf/i386-pc.rmk (pkglib_MODULES): Add `png.m
add two sanity check, one for chuck size, make sure the on disk
structure is correct, one for raw image, make sure the image won't
overflown. also adjust a few macro names and the filter handling code.
* conf/i386-pc.rmk (pkglib_MODULES): Add `png.mod'.
(png_mod_SOURCES): New varia
Bean <[EMAIL PROTECTED]> writes:
> On Jan 24, 2008 8:14 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
>> It would be nice, not required. I don't expect too much problems
>> here...
>>
>> Perhaps a better approach would be possible to do a check after
>> reading a size:
>>
>> int size = foo();
>>
>
On Jan 24, 2008 8:14 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> It would be nice, not required. I don't expect too much problems
> here...
>
> Perhaps a better approach would be possible to do a check after
> reading a size:
>
> int size = foo();
>
> Check the size of the file here
>
> while (
Bean <[EMAIL PROTECTED]> writes:
> On Jan 24, 2008 4:29 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
>> Bean <[EMAIL PROTECTED]> writes:
>>
>> > On Jan 23, 2008 6:36 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
>> >> > static grub_uint32_t
>> >> > grub_png_get_dword (struct grub_png_data *data)
>>
On Jan 24, 2008 4:29 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> Bean <[EMAIL PROTECTED]> writes:
>
> > On Jan 23, 2008 6:36 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> >> > static grub_uint32_t
> >> > grub_png_get_dword (struct grub_png_data *data)
> >> > {
> >> > grub_uint32_t r;
> >> >
>
Bean <[EMAIL PROTECTED]> writes:
> On Jan 23, 2008 6:36 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
>> > static grub_uint32_t
>> > grub_png_get_dword (struct grub_png_data *data)
>> > {
>> > grub_uint32_t r;
>> >
>> > r = 0;
>>
>> Why this?
>
> just to make sure if grub_file_read fails, this
On Jan 23, 2008 6:36 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> > static grub_uint32_t
> > grub_png_get_dword (struct grub_png_data *data)
> > {
> > grub_uint32_t r;
> >
> > r = 0;
>
> Why this?
just to make sure if grub_file_read fails, this function will return 0.
> Please follow our st
Bean <[EMAIL PROTECTED]> writes:
Hi,
> remove longjmp, also add grub_png prefix to function names.
Thanks!
A changelog entry is missing, this is a single file. See the review
below for some comments.
--
Marco
> /*
> * GRUB -- GRand Unified Bootloader
> * Copyright (C) 2008 Free Soft
Hi,
remove longjmp, also add grub_png prefix to function names.
/*
* GRUB -- GRand Unified Bootloader
* Copyright (C) 2008 Free Software Foundation, Inc.
*
* GRUB is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as publishe
Hi,
fix a few things:
apply filter to the whole scan line instead of per pixel
add support for stored block type
support RGBA color type
change a few names and types
/*
* GRUB -- GRand Unified Bootloader
* Copyright (C) 2008 Free Software Foundation, Inc.
*
* GRUB is free software: you
Hi,
This is reader for png image file.
/*
* GRUB -- GRand Unified Bootloader
* Copyright (C) 2008 Free Software Foundation, Inc.
*
* GRUB is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Softwar
13 matches
Mail list logo
