Re: [PATCH] Remove HFS support

2022-09-01 Thread Daniel Axtens
"Vladimir 'phcoder' Serbinenko" writes: > Le ven. 26 août 2022, 15:47, Daniel Axtens a écrit : > >> Let me answer this out of order. >> >> > I understand the need to sometimes get rid of old code, but since the HFS >> > module can be blacklisted as Vladimir explains, I don't really understand

Re: [PATCH] Remove HFS support

2022-08-30 Thread Robbie Harwood
John Paul Adrian Glaubitz writes: > On 8/30/22 18:37, Robbie Harwood wrote: > >> As the person currently responsible for the Red Hat tree: I am also >> not happy about this state of affairs. > > I don't want to sound rude, but GRUB isn't a RedHat-only project, it's a > community project.

Re: [PATCH] Remove HFS support

2022-08-30 Thread Robbie Harwood
"Vladimir 'phcoder' Serbinenko" writes: > Le ven. 26 août 2022, 15:47, Daniel Axtens a écrit : > >> Let me answer this out of order. >> >>> I understand the need to sometimes get rid of old code, but since >>> the HFS module can be blacklisted as Vladimir explains, I don't >>> really understand

Re: [PATCH] Remove HFS support

2022-08-30 Thread John Paul Adrian Glaubitz
On 8/30/22 18:37, Robbie Harwood wrote: As the person currently responsible for the Red Hat tree: I am also not happy about this state of affairs. I don't want to sound rude, but GRUB isn't a RedHat-only project, it's a community project. So, while I understand RH's point of view, I would also

Re: [PATCH] Remove HFS support

2022-08-30 Thread Robbie Harwood
Daniel Axtens writes: >>> Have you checked that you can't boot them with HFS+? Because HFS+ >>> came in 1998, which was (AFAICT) pretty early on in the G3 >>> lifecycle. So I'd be really surprised if the firmware didn't support >>> booting from HFS+. I'd be very keen to hear. >> >> I have not

Re: [PATCH] Remove HFS support

2022-08-26 Thread Vladimir 'phcoder' Serbinenko
Le ven. 26 août 2022, 17:46, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> a écrit : > Hi Vladimir! > > On 8/19/22 21:01, Vladimir 'phcoder' Serbinenko wrote: > > But booting old machines is still desirable for GRUB. Is there a reason > why > > HFS is actively bad for modern machines?

Re: [PATCH] Remove HFS support

2022-08-26 Thread John Paul Adrian Glaubitz
Hi Vladimir! On 8/19/22 21:01, Vladimir 'phcoder' Serbinenko wrote: But booting old machines is still desirable for GRUB. Is there a reason why HFS is actively bad for modern machines? Especially if it's disabled in case of lockdown. Can I have more details about your security concerns? I may

Re: [PATCH] Remove HFS support

2022-08-26 Thread John Paul Adrian Glaubitz
On 8/26/22 15:31, Daniel Axtens wrote: I want _all_ grub code to reach a minimum standard of not crashing or corrupting memory in the presence of malicious input. HFS does not reach that standard. I surely understand that although it sounds a little academic to me. Whether or not the HFS

Re: [PATCH] Remove HFS support

2022-08-26 Thread Daniel Axtens
Let me answer this out of order. > I understand the need to sometimes get rid of old code, but since the HFS > module can be blacklisted as Vladimir explains, I don't really understand > the reasoning in this particular case. I want _all_ grub code to reach a minimum standard of not crashing or

Re: [PATCH] Remove HFS support

2022-08-24 Thread John Paul Adrian Glaubitz
On 8/20/22 15:53, Daniel Axtens wrote: Really, plain HFS, not HFS+? Wowsers! Yes, we're currently using HFS. Just to be clear, by PowerMacs you mean Macs with PowerPC chips, so machines last produced around 2006? Yes. Have you checked that you can't boot them with HFS+? Because HFS+ came

Re: [PATCH] Remove HFS support

2022-08-24 Thread John Paul Adrian Glaubitz
Hi Vladimir! On 8/19/22 21:45, Vladimir 'phcoder' Serbinenko wrote: This kind of consideration was taken into account when designing security system and even when GRUB2 itself was designed. The solution is modules whitelist. There are many modules that can be dropped from signed build not

Re: [PATCH] Remove HFS support

2022-08-24 Thread John Paul Adrian Glaubitz
Hello! On 8/19/22 21:04, Dimitri John Ledkov wrote: There is no need for that code on any signed grubs or upstream. Ports that want to support this patch can have it conditionally compiled / enabled only on that arch, but not other. That's not how open source works. Individual projects do

Re: [PATCH] Remove HFS support

2022-08-20 Thread Daniel Axtens
"Vladimir 'phcoder' Serbinenko" writes: > No go from me either. Older macs may not be able to read HFS+ /boot. Also > HFS+ presents couple of problems the biggest one is that in case of sudden > reboot HFS+ often needs to be mounted by OSX or cleaning dirty flag > manually before it becomes

Re: [PATCH] Remove HFS support

2022-08-20 Thread Daniel Axtens
>> As Daniel Axtens has been finding out, the HFS code is terrible in >> terms of security. If you still need it for old/semi-dead machines, >> maybe you should fork an older grub release and stay with that? > > I don't know what should be the deal with the security of a boot loader > to be

Re: [PATCH] Remove HFS support

2022-08-20 Thread Daniel Axtens
"Vladimir 'phcoder' Serbinenko" writes: > Le ven. 19 août 2022, 21:05, Dimitri John Ledkov < > dimitri.led...@canonical.com> a écrit : > >> There is no need for that code on any signed grubs or upstream. Ports that >> want to support this patch can have it conditionally compiled / enabled >>

Re: [PATCH] Remove HFS support

2022-08-20 Thread Daniel Axtens
John Paul Adrian Glaubitz writes: >> On Aug 19, 2022, at 3:59 PM, Daniel Kiper wrote: >> >> On Fri, Aug 19, 2022 at 11:38:26PM +1000, Daniel Axtens wrote: >>> HFS is so so very old now. According to Wikipedia, HFS was >>> introduced in 1985 and the successor HFS+ came out in January >>> 1998.

Re: [PATCH] Remove HFS support

2022-08-19 Thread Vladimir 'phcoder' Serbinenko
Le ven. 19 août 2022, 21:05, Dimitri John Ledkov < dimitri.led...@canonical.com> a écrit : > There is no need for that code on any signed grubs or upstream. Ports that > want to support this patch can have it conditionally compiled / enabled > only on that arch, but not other. > > For example, in

Re: [PATCH] Remove HFS support

2022-08-19 Thread Dimitri John Ledkov
There is no need for that code on any signed grubs or upstream. Ports that want to support this patch can have it conditionally compiled / enabled only on that arch, but not other. For example, in Ubuntu we already use separate builds for signed & unsigned bootloaders. Or one may keep grub-2.06

Re: [PATCH] Remove HFS support

2022-08-19 Thread Vladimir 'phcoder' Serbinenko
Le ven. 19 août 2022, 20:11, Steve McIntyre a écrit : > On Fri, Aug 19, 2022 at 04:03:38PM +0200, John Paul Adrian Glaubitz wrote: > >> On Aug 19, 2022, at 3:59 PM, Daniel Kiper wrote: > >> > >> If I do not hear any major objections in the following weeks I will > >> merge this patch or a

Re: [PATCH] Remove HFS support

2022-08-19 Thread John Paul Adrian Glaubitz
On 8/19/22 20:09, Steve McIntyre wrote: On Fri, Aug 19, 2022 at 04:03:38PM +0200, John Paul Adrian Glaubitz wrote: On Aug 19, 2022, at 3:59 PM, Daniel Kiper wrote: If I do not hear any major objections in the following weeks I will merge this patch or a variant of it in the second half of

Re: [PATCH] Remove HFS support

2022-08-19 Thread Steve McIntyre
On Fri, Aug 19, 2022 at 04:03:38PM +0200, John Paul Adrian Glaubitz wrote: >> On Aug 19, 2022, at 3:59 PM, Daniel Kiper wrote: >> >> If I do not hear any major objections in the following weeks I will >> merge this patch or a variant of it in the second half of September. > >We’re still

Re: [PATCH] Remove HFS support

2022-08-19 Thread Vladimir 'phcoder' Serbinenko
No go from me either. Older macs may not be able to read HFS+ /boot. Also HFS+ presents couple of problems the biggest one is that in case of sudden reboot HFS+ often needs to be mounted by OSX or cleaning dirty flag manually before it becomes writeable. Le ven. 19 août 2022, 16:05, John Paul

Re: [PATCH] Remove HFS support

2022-08-19 Thread John Paul Adrian Glaubitz
> On Aug 19, 2022, at 3:59 PM, Daniel Kiper wrote: > > On Fri, Aug 19, 2022 at 11:38:26PM +1000, Daniel Axtens wrote: >> HFS is so so very old now. According to Wikipedia, HFS was >> introduced in 1985 and the successor HFS+ came out in January >> 1998. Mac OS dropped support for writing HFS

Re: [PATCH] Remove HFS support

2022-08-19 Thread Daniel Kiper
On Fri, Aug 19, 2022 at 11:38:26PM +1000, Daniel Axtens wrote: > HFS is so so very old now. According to Wikipedia, HFS was > introduced in 1985 and the successor HFS+ came out in January > 1998. Mac OS dropped support for writing HFS in 2009 and dropped > support for reading HFS in 2019 with

[PATCH] Remove HFS support

2022-08-19 Thread Daniel Axtens
HFS is so so very old now. According to Wikipedia, HFS was introduced in 1985 and the successor HFS+ came out in January 1998. Mac OS dropped support for writing HFS in 2009 and dropped support for reading HFS in 2019 with macOS 10.15. Grub's support for it doesn't survive contact with a fuzzer,