Re: [PATCH] Small unicode problem fix in normal/menu.c

2005-07-09 Thread Yoshinori K. Okuji
On Tuesday 05 July 2005 22:36, Vincent Pelletier wrote: > I was also wondering about the font format. Does any editor exists ? Or > is it taken from an existing format ? I'm dying to see Japanese chars on > grub menu while playing the tetris theme :] . I described the format here: http://lists.gn

Re: [PATCH] Small unicode problem fix in normal/menu.c

2005-07-05 Thread Vincent Pelletier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Yoshinori K. Okuji wrote: > You can check in this patch, but this is not the right thing to do. So I prefer not checking it in. I had the idea to start a Unicode debate on how to handle this. My first idea would be : unsigned int grub_putcode(...); un

Re: [PATCH] Small unicode problem fix in normal/menu.c

2005-07-05 Thread Marco Gerards
Marco Gerards <[EMAIL PROTECTED]> writes: > Vincent Pelletier <[EMAIL PROTECTED]> writes: > >> There is an alignment problem when menu is drawn with Unicode chars in >> titles : there aren't enough spaces written on the right to make the >> hilight fill horizontaly the menu. > > This sounds like a

Re: [Bulk] [PATCH] Small unicode problem fix in normal/menu.c

2005-07-05 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: > On Monday 04 July 2005 16:45, Vincent Pelletier wrote: >> ncurses-like (not macros !) : >> >> void grub_getyx (unsigned int &y, unsigned int &x) >> void grub_getmaxyx (unsigned int &y, unsigned int &x) /* to get the term >> size */ > > My feeling

Re: [PATCH] Small unicode problem fix in normal/menu.c

2005-07-05 Thread Marco Gerards
Vincent Pelletier <[EMAIL PROTECTED]> writes: > There is an alignment problem when menu is drawn with Unicode chars in > titles : there aren't enough spaces written on the right to make the > hilight fill horizontaly the menu. This sounds like a bug in the terminal to me. In that case it has to

Re: [Bulk] [PATCH] Small unicode problem fix in normal/menu.c

2005-07-05 Thread Vincent Pelletier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Yoshinori K. Okuji wrote: > My feeling is that it is not convenient to use pointers. Right. My first idea was to use a struct as return type : struct coords { unsigned char x; unsigned char y; }; So it becomes : if (grub_getxy () .x) Or maybe

Re: [Bulk] [PATCH] Small unicode problem fix in normal/menu.c

2005-07-04 Thread Yoshinori K. Okuji
On Monday 04 July 2005 16:45, Vincent Pelletier wrote: > ncurses-like (not macros !) : > > void grub_getyx (unsigned int &y, unsigned int &x) > void grub_getmaxyx (unsigned int &y, unsigned int &x) /* to get the term > size */ My feeling is that it is not convenient to use pointers. For example, w

Re: [PATCH] Small unicode problem fix in normal/menu.c

2005-07-04 Thread Yoshinori K. Okuji
On Sunday 03 July 2005 22:52, Vincent Pelletier wrote: > There is an alignment problem when menu is drawn with Unicode chars in > titles : there aren't enough spaces written on the right to make the > hilight fill horizontaly the menu. You can check in this patch, but this is not the right thing t

Re: [Bulk] [PATCH] Small unicode problem fix in normal/menu.c

2005-07-04 Thread Vincent Pelletier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 About the grub_getxy function... Wouldn't it be better to change it ? ncurses-like (not macros !) : void grub_getyx (unsigned int &y, unsigned int &x) void grub_getmaxyx (unsigned int &y, unsigned int &x) /* to get the term size */ Any comment ? V

[PATCH] Small unicode problem fix in normal/menu.c

2005-07-03 Thread Vincent Pelletier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 There is an alignment problem when menu is drawn with Unicode chars in titles : there aren't enough spaces written on the right to make the hilight fill horizontaly the menu. 2005-07-03 Vincent Pelletier <[EMAIL PROTECTED]> * normal/menu.c