Re: [PATCH] Warn if MBR gap is small and user uses advanced modules

2020-04-27 Thread Vladimir 'phcoder' Serbinenko
On Wed, Mar 11, 2020 at 2:34 PM Daniel Kiper wrote: > > Adding Michael, Mihai, Javier and Peter... > > Below you can find what more or less Vladimir and I agreed WRT small MBR > gap. In general Vladimir convinced me to phase out small MBR gaps > support gradually. This is first step in this journe

Re: [PATCH] Warn if MBR gap is small and user uses advanced modules

2020-03-11 Thread Vladimir 'phcoder' Serbinenko
On Wed, Mar 11, 2020, 18:08 Didier Spaier wrote: > > > Le 11/03/2020 à 13:43, Daniel Kiper a écrit : > > Adding Michael, Mihai, Javier and Peter... > > > > Below you can find what more or less Vladimir and I agreed WRT small MBR > > gap. In general Vladimir convinced me to phase out small MBR gap

Re: [PATCH] Warn if MBR gap is small and user uses advanced modules

2020-03-11 Thread Didier Spaier
Le 11/03/2020 à 13:43, Daniel Kiper a écrit : > Adding Michael, Mihai, Javier and Peter... > > Below you can find what more or less Vladimir and I agreed WRT small MBR > gap. In general Vladimir convinced me to phase out small MBR gaps > support gradually. This is first step in this journey. We

Re: [PATCH] Warn if MBR gap is small and user uses advanced modules

2020-03-11 Thread Michael Chang
On Wed, Mar 11, 2020 at 01:43:14PM +0100, Daniel Kiper wrote: > Adding Michael, Mihai, Javier and Peter... > > Below you can find what more or less Vladimir and I agreed WRT small MBR > gap. In general Vladimir convinced me to phase out small MBR gaps > support gradually. This is first step in thi

Re: [PATCH] Warn if MBR gap is small and user uses advanced modules

2020-03-11 Thread Javier Martinez Canillas
Hello Daniel, On 3/11/20 1:43 PM, Daniel Kiper wrote: > Adding Michael, Mihai, Javier and Peter... > > Below you can find what more or less Vladimir and I agreed WRT small MBR > gap. In general Vladimir convinced me to phase out small MBR gaps > support gradually. This is first step in this journ

Re: [PATCH] Warn if MBR gap is small and user uses advanced modules

2020-03-11 Thread Daniel Kiper
Adding Michael, Mihai, Javier and Peter... Below you can find what more or less Vladimir and I agreed WRT small MBR gap. In general Vladimir convinced me to phase out small MBR gaps support gradually. This is first step in this journey. We think that we have to build some warnings into the code an

Re: [PATCH] Warn if MBR gap is small and user uses advanced modules

2020-03-10 Thread Mihai Moldovan
* On 3/10/20 1:23 PM, Vladimir 'phcoder' Serbinenko wrote: > [...] > diff --git a/include/grub/util/install.h b/include/grub/util/install.h > index 2631b1074..982115f57 100644 > --- a/include/grub/util/install.h > +++ b/include/grub/util/install.h > @@ -193,13 +193,13 @@ grub_util_bios_setup (const

[PATCH] Warn if MBR gap is small and user uses advanced modules

2020-03-10 Thread Vladimir 'phcoder' Serbinenko
Daniel, do you want to adjust the whitelist? We don't want to support small MBR gap in pair with anything but the simplest config of biosdisk+part_msdos+simple filesystem. In this path "simple filesystems" are all current filesystems except zfs and btrfs --- grub-core/partmap/gpt.c | 9 +