Re: [PATCH] btrfs: avoid "used uninitialized" error with GCC7

2017-04-04 Thread Andrei Borzenkov
03.04.2017 11:59, Vladimir 'phcoder' Serbinenko пишет: > On Fri, Mar 31, 2017, 06:43 Andrei Borzenkov wrote: > >> sblock was local and so considered new variable on every loop >> iteration. >> >> While on it, dynamically allocate buffer to reduce stack usage. >> > Looks good. Did you check all in

Re: [PATCH] btrfs: avoid "used uninitialized" error with GCC7

2017-04-03 Thread Vladimir 'phcoder' Serbinenko
On Fri, Mar 31, 2017, 06:43 Andrei Borzenkov wrote: > sblock was local and so considered new variable on every loop > iteration. > > While on it, dynamically allocate buffer to reduce stack usage. > Looks good. Did you check all instances sizeof, so we don't have sizeof of pointer? Did you check

[PATCH] btrfs: avoid "used uninitialized" error with GCC7

2017-03-31 Thread Andrei Borzenkov
sblock was local and so considered new variable on every loop iteration. While on it, dynamically allocate buffer to reduce stack usage. Closes: 50597 --- grub-core/fs/btrfs.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/grub-core/fs/btrfs.c b/grub-cor