Re: [PATCH] chainloader: patch in BPB's sectors_per_track and num_heads

2018-03-05 Thread Daniel Kiper
On Sat, Mar 03, 2018 at 12:22:04PM +0100, C. Masloch wrote: > Hello, > > Was this overlooked? Yep, sorry about that. > I think I should check whether dev->disk->data actually is a (struct > grub_biosdisk_data *) but I don't know how! I am not sure it is possible. Anyway, LGTM. Daniel

Re: [PATCH] chainloader: patch in BPB's sectors_per_track and num_heads

2018-03-05 Thread Daniel Kiper
On Thu, Feb 01, 2018 at 03:51:55PM +0100, C. Masloch wrote: > > These fields must reflect the ROM-BIOS's geometry for CHS-based > loaders to correctly load their next stage. Most loaders do not > query the ROM-BIOS (Int13.08), relying on the BPB fields to hold > the correct values already. > >

Re: [PATCH] chainloader: patch in BPB's sectors_per_track and num_heads

2018-03-03 Thread C. Masloch
Hello, Was this overlooked? I think I should check whether dev->disk->data actually is a (struct grub_biosdisk_data *) but I don't know how! Regards, ecm On at 2018-02-01 15:51 +01:00, C. Masloch wrote: > > These fields must reflect the ROM-BIOS's geometry for CHS-based > loaders to

[PATCH] chainloader: patch in BPB's sectors_per_track and num_heads

2018-02-01 Thread C. Masloch
These fields must reflect the ROM-BIOS's geometry for CHS-based loaders to correctly load their next stage. Most loaders do not query the ROM-BIOS (Int13.08), relying on the BPB fields to hold the correct values already. Tested with lDebug booted in qemu via grub2's FreeDOS direct loading