Re: [PATCH] cli_lock: Added build option to block command line interface

2024-06-05 Thread Daniel Kiper via Grub-devel
On Wed, Jan 24, 2024 at 06:26:37AM +, Alec Brown wrote: > Added functionality to disable command line interface access and editing of > GRUB > menu entries if GRUB image is built with --disable-cli. > > Signed-off-by: Alec Brown Reviewed-by: Daniel Kiper Daniel ___

Re: [PATCH] cli_lock: Added build option to block command line interface

2024-06-05 Thread Vladimir 'phcoder' Serbinenko
Reviewed-By: Vladimir Serbinenko On Wed, Jan 24, 2024 at 9:27 AM Alec Brown wrote: > > Added functionality to disable command line interface access and editing of > GRUB > menu entries if GRUB image is built with --disable-cli. > > Signed-off-by: Alec Brown > --- > docs/grub.texi

Re: [PATCH] cli_lock: Added build option to block command line interface

2024-01-26 Thread Vladimir 'phcoder' Serbinenko
Le ven. 26 janv. 2024, 23:15, Daniel Kiper a écrit : > On Fri, Jan 26, 2024 at 02:12:31AM +0300, Vladimir 'phcoder' Serbinenko > wrote: > > Please detail your use case. GRUB already had user framework in the same > > problem space. > > I am not sure what exactly you mean by "user framework". Coul

Re: [PATCH] cli_lock: Added build option to block command line interface

2024-01-26 Thread Daniel Kiper
On Fri, Jan 26, 2024 at 02:12:31AM +0300, Vladimir 'phcoder' Serbinenko wrote: > Please detail your use case. GRUB already had user framework in the same > problem space. I am not sure what exactly you mean by "user framework". Could you elaborate or point us code examples? Anyway, we need a mech

Re: [PATCH] cli_lock: Added build option to block command line interface

2024-01-26 Thread Daniel Kiper
On Wed, Jan 24, 2024 at 08:28:39AM +0100, Olaf Hering wrote: > Wed, 24 Jan 2024 06:26:37 + Alec Brown : > > > +static bool cli_disabled = false; > > Are there any other values than zero for "false"? > If not, the initialization can be removed. Even if you are technically correct I think we sho

Re: [PATCH] cli_lock: Added build option to block command line interface

2024-01-25 Thread Vladimir 'phcoder' Serbinenko
Please detail your use case. GRUB already had user framework in the same problem space. Le mer. 24 janv. 2024, 09:27, Alec Brown a écrit : > Added functionality to disable command line interface access and editing > of GRUB > menu entries if GRUB image is built with --disable-cli. > > Signed-off

Re: [PATCH] cli_lock: Added build option to block command line interface

2024-01-23 Thread Olaf Hering
Wed, 24 Jan 2024 06:26:37 + Alec Brown : > +static bool cli_disabled = false; Are there any other values than zero for "false"? If not, the initialization can be removed. Olaf pgpyCy0AM4E27.pgp Description: Digitale Signatur von OpenPGP ___ Grub

[PATCH] cli_lock: Added build option to block command line interface

2024-01-23 Thread Alec Brown
Added functionality to disable command line interface access and editing of GRUB menu entries if GRUB image is built with --disable-cli. Signed-off-by: Alec Brown --- docs/grub.texi | 6 -- grub-core/kern/main.c | 28 grub-core/kern/resc