Re: [PATCH] diskfilter: Treat an unrecognized RAID level as an error

2012-02-04 Thread Richard Laager
On Sat, 2012-02-04 at 23:30 +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 04.02.2012 23:01, Richard Laager wrote: > > disk/diskfilter.c: In function 'grub_diskfilter_make_raid': > > disk/diskfilter.c:847:21: error: 'totsize' may be used uninitialized in > > this function [-Werror=uniniti

Re: [PATCH] diskfilter: Treat an unrecognized RAID level as an error

2012-02-04 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 04.02.2012 23:01, Richard Laager wrote: disk/diskfilter.c: In function 'grub_diskfilter_make_raid': disk/diskfilter.c:847:21: error: 'totsize' may be used uninitialized in this function [-Werror=uninitialized] Perhaps my patch should use assert() instead of return NULL? We don't use assert si

[PATCH] diskfilter: Treat an unrecognized RAID level as an error

2012-02-04 Thread Richard Laager
disk/diskfilter.c: In function 'grub_diskfilter_make_raid': disk/diskfilter.c:847:21: error: 'totsize' may be used uninitialized in this function [-Werror=uninitialized] Perhaps my patch should use assert() instead of return NULL? -- Richard diskfilter: Treat an unrecognized RAID level as an err