Re: [PATCH] fs/btrfs: Make extent item iteration to handle gaps

2021-11-02 Thread Daniel Kiper
On Fri, Oct 29, 2021 at 02:52:29PM +0200, David Sterba wrote: > On Thu, Oct 28, 2021 at 03:36:10PM +0800, Qu Wenruo wrote: > > Gentle ping? > > > > Without this patch, the new mkfs.btrfs NO_HOLES feature would break any > > kernel/initramfs with hole in it. > > Just to clarify, it's not a new featu

Re: [PATCH] fs/btrfs: Make extent item iteration to handle gaps

2021-10-29 Thread David Sterba
On Thu, Oct 28, 2021 at 03:36:10PM +0800, Qu Wenruo wrote: > Gentle ping? > > Without this patch, the new mkfs.btrfs NO_HOLES feature would break any > kernel/initramfs with hole in it. Just to clarify, it's not a new feature, it's been out for a long time (since 3.14). The new thing is that it

Re: [PATCH] fs/btrfs: Make extent item iteration to handle gaps

2021-10-28 Thread Qu Wenruo
On 2021/10/28 17:27, Michael Chang wrote: On Thu, Oct 28, 2021 at 03:36:10PM +0800, The development of GNU GRUB wrote: Gentle ping? Without this patch, the new mkfs.btrfs NO_HOLES feature would break any kernel/initramfs with hole in it. And considering the modification is already small, I b

Re: [PATCH] fs/btrfs: Make extent item iteration to handle gaps

2021-10-28 Thread Michael Chang via Grub-devel
On Thu, Oct 28, 2021 at 03:36:10PM +0800, The development of GNU GRUB wrote: > Gentle ping? > > Without this patch, the new mkfs.btrfs NO_HOLES feature would break any > kernel/initramfs with hole in it. > > And considering the modification is already small, I believe this patch is > definitely w

Re: [PATCH] fs/btrfs: Make extent item iteration to handle gaps

2021-10-28 Thread Qu Wenruo via Grub-devel
Gentle ping? Without this patch, the new mkfs.btrfs NO_HOLES feature would break any kernel/initramfs with hole in it. And considering the modification is already small, I believe this patch is definitely worthy as a bug fix. Thanks, Qu On 2021/10/16 09:40, Qu Wenruo wrote: [BUG] Grub btr

[PATCH] fs/btrfs: Make extent item iteration to handle gaps

2021-10-18 Thread David Disseldorp
Tested-by: David Disseldorp This fixes the failures seen with the Dracut reflinked initramfs patchset at https://github.com/dracutdevs/dracut/pull/1531 . Thanks, David ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listin

Re: [PATCH] fs/btrfs: Make extent item iteration to handle gaps

2021-10-18 Thread Qu Wenruo via Grub-devel
On 2021/10/18 18:49, David Disseldorp wrote: Tested-by: David Disseldorp This fixes the failures seen with the Dracut reflinked initramfs patchset at https://github.com/dracutdevs/dracut/pull/1531 . Thanks, David Missing CC to grub mail list I guess? Thanks, Qu _

[PATCH] fs/btrfs: Make extent item iteration to handle gaps

2021-10-15 Thread Qu Wenruo via Grub-devel
[BUG] Grub btrfs implementation can't handle two very basic btrfs file layouts: 1. Mixed inline/regualr extents # mkfs.btrfs -f test.img # mount test.img /mnt/btrfs # xfs_io -f -c "pwrite 0 1k" -c "sync" -c "falloc 0 4k" \ -c "pwrite 4k 4k" /mnt/btrfs/file # umount /mnt/