Re: [PATCH] luks2: Continue trying all keyslots even if there are some failures

2022-08-20 Thread Patrick Steinhardt
On Fri, Aug 19, 2022 at 04:10:44PM +0200, Daniel Kiper wrote: > On Mon, Aug 15, 2022 at 05:23:15PM +0200, Patrick Steinhardt wrote: > > On Fri, Jul 22, 2022 at 03:04:50AM -0500, Glenn Washburn wrote: > > > luks2_get_keyslot can fail for a variety of reasons that do not > > > neccesarily > > > mean

Re: [PATCH] luks2: Continue trying all keyslots even if there are some failures

2022-08-19 Thread Daniel Kiper
On Mon, Aug 15, 2022 at 05:23:15PM +0200, Patrick Steinhardt wrote: > On Fri, Jul 22, 2022 at 03:04:50AM -0500, Glenn Washburn wrote: > > luks2_get_keyslot can fail for a variety of reasons that do not neccesarily > > mean the next keyslot should not be tried (eg. a new kdf type). So always > > try

Re: [PATCH] luks2: Continue trying all keyslots even if there are some failures

2022-08-15 Thread Patrick Steinhardt
On Fri, Jul 22, 2022 at 03:04:50AM -0500, Glenn Washburn wrote: > luks2_get_keyslot can fail for a variety of reasons that do not neccesarily > mean the next keyslot should not be tried (eg. a new kdf type). So always > try the next slot. This will make GRUB more resilient to non-spec json data > t

Re: [PATCH] luks2: Continue trying all keyslots even if there are some failures

2022-08-02 Thread Daniel Kiper
On Fri, Jul 22, 2022 at 03:04:50AM -0500, Glenn Washburn wrote: > luks2_get_keyslot can fail for a variety of reasons that do not neccesarily > mean the next keyslot should not be tried (eg. a new kdf type). So always > try the next slot. This will make GRUB more resilient to non-spec json data > t

[PATCH] luks2: Continue trying all keyslots even if there are some failures

2022-07-22 Thread Glenn Washburn
luks2_get_keyslot can fail for a variety of reasons that do not neccesarily mean the next keyslot should not be tried (eg. a new kdf type). So always try the next slot. This will make GRUB more resilient to non-spec json data that 3rd party systems may add. We do not care if some of the keyslots ar