Re: [PATCH] misc: Set grub_errno on all failures in grub_xvasprintf()

2023-10-05 Thread Glenn Washburn
On Sat, 2 Sep 2023 22:03:08 +0200 "Vladimir 'phcoder' Serbinenko" wrote: > 2 problems: > 1) Did you audit that all call places either clear or propagate error? Am I correct in understanding that you're asking if all calls to grub_xvasprintf() with clear grub_errno or return it? I have not checke

Re: [PATCH] misc: Set grub_errno on all failures in grub_xvasprintf()

2023-09-02 Thread Vladimir 'phcoder' Serbinenko
2 problems: 1) Did you audit that all call places either clear or propagate error? 2) We use standard error message "out of memory". This allows it to be translated and not be too technical. Le sam. 2 sept. 2023, 04:17, Glenn Washburn a écrit : > When failing to allocate the preallocate buffer,

Re: [PATCH] misc: Set grub_errno on all failures in grub_xvasprintf()

2023-09-02 Thread Daniel Kiper
On Fri, Sep 01, 2023 at 09:16:24PM -0500, Glenn Washburn wrote: > When failing to allocate the preallocate buffer, grub_xvasprintf() > returns NULL, but does not set grub_errno. Returning NULL is sufficient > for a caller to determine there was an error. However, some usages of > grub_xvasprintf()

[PATCH] misc: Set grub_errno on all failures in grub_xvasprintf()

2023-09-01 Thread Glenn Washburn
When failing to allocate the preallocate buffer, grub_xvasprintf() returns NULL, but does not set grub_errno. Returning NULL is sufficient for a caller to determine there was an error. However, some usages of grub_xvasprintf() check for a NULL return value and then return grub_errno, which could re