Re: [PATCH] osdep/linux: Fix md array device enumeration

2023-06-12 Thread Daniel Kiper
On Wed, Jun 07, 2023 at 02:33:35PM -0700, Kees Cook wrote: > On Wed, Jun 07, 2023 at 03:39:24PM +0200, Daniel Kiper wrote: > > On Tue, Jun 06, 2023 at 11:02:31AM -0700, Kees Cook wrote: > > > On Tue, Jun 6, 2023 at 10:27 AM Julian Andres Klode > > > wrote: > > > > > > > > On Tue, Jun 06, 2023 at 0

Re: [PATCH] osdep/linux: Fix md array device enumeration

2023-06-07 Thread Kees Cook
On Wed, Jun 07, 2023 at 03:39:24PM +0200, Daniel Kiper wrote: > On Tue, Jun 06, 2023 at 11:02:31AM -0700, Kees Cook wrote: > > On Tue, Jun 6, 2023 at 10:27 AM Julian Andres Klode > > wrote: > > > > > > On Tue, Jun 06, 2023 at 07:09:26PM +0200, Daniel Kiper wrote: > > > > On Tue, Jun 06, 2023 at 06

Re: [PATCH] osdep/linux: Fix md array device enumeration

2023-06-07 Thread Daniel Kiper
On Tue, Jun 06, 2023 at 11:02:31AM -0700, Kees Cook wrote: > On Tue, Jun 6, 2023 at 10:27 AM Julian Andres Klode > wrote: > > > > On Tue, Jun 06, 2023 at 07:09:26PM +0200, Daniel Kiper wrote: > > > On Tue, Jun 06, 2023 at 06:15:27PM +0200, Julian Andres Klode wrote: > > > > On Tue, Jun 06, 2023 at

Re: [PATCH] osdep/linux: Fix md array device enumeration

2023-06-06 Thread Kees Cook
On Tue, Jun 6, 2023 at 10:27 AM Julian Andres Klode wrote: > > On Tue, Jun 06, 2023 at 07:09:26PM +0200, Daniel Kiper wrote: > > On Tue, Jun 06, 2023 at 06:15:27PM +0200, Julian Andres Klode wrote: > > > On Tue, Jun 06, 2023 at 06:10:21PM +0200, Julian Andres Klode wrote: > > [...] > > This patch

Re: [PATCH] osdep/linux: Fix md array device enumeration

2023-06-06 Thread Julian Andres Klode
On Tue, Jun 06, 2023 at 07:09:26PM +0200, Daniel Kiper wrote: > On Tue, Jun 06, 2023 at 06:15:27PM +0200, Julian Andres Klode wrote: > > On Tue, Jun 06, 2023 at 06:10:21PM +0200, Julian Andres Klode wrote: > > > From: Kees Cook > > > > > > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_IN

Re: [PATCH] osdep/linux: Fix md array device enumeration

2023-06-06 Thread Daniel Kiper
On Tue, Jun 06, 2023 at 06:15:27PM +0200, Julian Andres Klode wrote: > On Tue, Jun 06, 2023 at 06:10:21PM +0200, Julian Andres Klode wrote: > > From: Kees Cook > > > > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's > > disk.number, which is an internal kernel index. If an array has

Re: [PATCH] osdep/linux: Fix md array device enumeration

2023-06-06 Thread Julian Andres Klode
On Tue, Jun 06, 2023 at 06:10:21PM +0200, Julian Andres Klode wrote: > From: Kees Cook > > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's > disk.number, which is an internal kernel index. If an array has had drives > added, removed, etc, there may be gaps in GET_DISK_INFO's result

[PATCH] osdep/linux: Fix md array device enumeration

2023-06-06 Thread Julian Andres Klode
From: Kees Cook GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's disk.number, which is an internal kernel index. If an array has had drives added, removed, etc, there may be gaps in GET_DISK_INFO's results. But since the consumer of devicelist cannot tolerate gaps (it expects to wal

Re: [PATCH] osdep/linux: Fix md array device enumeration

2021-10-08 Thread Petr Vorel
Hi Kees, > Hi Petr, > On Wed, Oct 06, 2021 at 09:28:32AM +0200, Petr Vorel wrote: > > Hi Kees, Daniel, > > > On Sat, Sep 25, 2021 at 07:03:35PM -0700, k...@ubuntu.com wrote: > > > > From: Kees Cook > > > > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's > > > > disk.number, whic

Re: [PATCH] osdep/linux: Fix md array device enumeration

2021-10-07 Thread Kees Cook
Hi Petr, On Wed, Oct 06, 2021 at 09:28:32AM +0200, Petr Vorel wrote: > Hi Kees, Daniel, > > > On Sat, Sep 25, 2021 at 07:03:35PM -0700, k...@ubuntu.com wrote: > > > From: Kees Cook > > > > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's > > > disk.number, which is an internal ker

Re: [PATCH] osdep/linux: Fix md array device enumeration

2021-10-07 Thread Kees Cook
Hi Daniel, On Tue, Oct 05, 2021 at 06:38:13PM +0200, Daniel Kiper wrote: > On Sat, Sep 25, 2021 at 07:03:35PM -0700, k...@ubuntu.com wrote: > > From: Kees Cook > > > > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's > > disk.number, which is an internal kernel index. If an array ha

Re: [PATCH] osdep/linux: Fix md array device enumeration

2021-10-06 Thread Petr Vorel
Hi Kees, Daniel, > On Sat, Sep 25, 2021 at 07:03:35PM -0700, k...@ubuntu.com wrote: > > From: Kees Cook > > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's > > disk.number, which is an internal kernel index. If an array has had drives > > added, removed, etc, there may be gaps in

Re: [PATCH] osdep/linux: Fix md array device enumeration

2021-10-05 Thread Daniel Kiper
On Sat, Sep 25, 2021 at 07:03:35PM -0700, k...@ubuntu.com wrote: > From: Kees Cook > > GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's > disk.number, which is an internal kernel index. If an array has had drives > added, removed, etc, there may be gaps in GET_DISK_INFO's results. Bu

[PATCH] osdep/linux: Fix md array device enumeration

2021-09-25 Thread kees
From: Kees Cook GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's disk.number, which is an internal kernel index. If an array has had drives added, removed, etc, there may be gaps in GET_DISK_INFO's results. But since the consumer of devicelist cannot tolerate gaps (it expects to wal

[PATCH] osdep/linux: Fix md array device enumeration

2021-01-17 Thread Kees Cook
GET_ARRAY_INFO's info.nr_disks does not map to GET_DISK_INFO's disk.number, which is an internal kernel index. If an array has had drives added, removed, etc, there may be gaps in GET_DISK_INFO's results. But since the consumer of devicelist cannot tolerate gaps (it expects to walk a NULL-terminate