On Fri, Apr 19, 2019 at 09:19:35AM +0200, adrian15 wrote:
> El 18/04/19 a las 12:29, Daniel Kiper escribió:
> > On Sat, Apr 13, 2019 at 12:54:53PM +0200, adrian15 wrote:
> >> I confirm this patch applied over 2.04rc1 tag enables me to build grub
> >> on my system.
> >> Thank you very much!
> >
> >
El 18/04/19 a las 12:29, Daniel Kiper escribió:
> On Sat, Apr 13, 2019 at 12:54:53PM +0200, adrian15 wrote:
>> I confirm this patch applied over 2.04rc1 tag enables me to build grub
>> on my system.
>> Thank you very much!
>
> May I add "Tested-by: adrian15 " to this patch?
>
> Daniel
No problem.
On Sat, Apr 13, 2019 at 12:54:53PM +0200, adrian15 wrote:
> I confirm this patch applied over 2.04rc1 tag enables me to build grub
> on my system.
> Thank you very much!
May I add "Tested-by: adrian15 " to this patch?
Daniel
___
Grub-devel mailing list
> On Apr 12, 2019, at 5:59 AM, Daniel Kiper wrote:
>
> Some older GCC versions produce following error when x86 MSR modules are
> build:
>
> In file included from commands/i386/rdmsr.c:29:0:
> ../include/grub/i386/rdmsr.h:27:29: error: no previous prototype for
> ‘grub_msr_read’ [-Werror=mi
I confirm this patch applied over 2.04rc1 tag enables me to build grub
on my system.
Thank you very much!
adrian15
El 12/04/19 a las 13:59, Daniel Kiper escribió:
> Some older GCC versions produce following error when x86 MSR modules are
> build:
>
> In file included from commands/i386/rdmsr.
LGTM.
Just a note: it's a correct usage of extern, just not consistent with
rest of codebase and not supported by old gcc
On Sat, Apr 13, 2019 at 12:02 AM Daniel Kiper wrote:
>
> Some older GCC versions produce following error when x86 MSR modules are
> build:
>
> In file included from command
Some older GCC versions produce following error when x86 MSR modules are build:
In file included from commands/i386/rdmsr.c:29:0:
../include/grub/i386/rdmsr.h:27:29: error: no previous prototype for
‘grub_msr_read’ [-Werror=missing-prototypes]
extern inline grub_uint64_t grub_msr_read (gru
