Hi,
Glenn Washburn wrote:
> > > if [ -z "$debug" ] && [ "$RET" -eq "$xfail" ]; then
I wrote:
> > If indeed in a successful --xfail test RET must have the value of "$xfail"
> > (i guess 1), then it is concise and sufficient.
> [...] the only acceptable xfail case is for RET=1. If
> RET is greate
On Wed, 02 Oct 2024 09:08:23 +0200
"Thomas Schmitt" wrote:
> Hi,
>
> i wrote:
> > > Assuming variable "xfail" is be set to a non-empty string exactly if
> > > argument "--xfail" is given, i'd replace:
> > >
> > > if [ -z "$debug" ] && [ "${RET:-1}" -eq 0 ]; then
> > > rm -rf "$lukste
Hi,
i wrote:
> > Assuming variable "xfail" is be set to a non-empty string exactly if
> > argument "--xfail" is given, i'd replace:
> >
> > if [ -z "$debug" ] && [ "${RET:-1}" -eq 0 ]; then
> > rm -rf "$lukstestdir" || :
> > fi
Glenn Washburn wrote:
> RET should never be undefined
On Fri, 27 Sep 2024 13:59:35 +0200
"Thomas Schmitt" wrote:
> Hi,
>
> Glenn Washburn wrote:
> > [...] grub-shell-luks-tester cleans up after
> > itself, if it returns success. grub_cmd_cryptomount has a test that
> > expects failure. But grub-shell-luks-tester doesn't know that this is
> > an exp
Hi,
Glenn Washburn wrote:
> [...] grub-shell-luks-tester cleans up after
> itself, if it returns success. grub_cmd_cryptomount has a test that
> expects failure. But grub-shell-luks-tester doesn't know that this is
> an expected failure and should cleanup and grub_cmd_cryptomount doesn't
> ever cl
On Thu, 26 Sep 2024 22:44:20 +0200
"Thomas Schmitt" wrote:
> Hi,
>
> i wrote:
> > > I meanwhile forgot why i proposed
> > > > +unset TMPDIR
> > > but there was some theoretical reason for this ...
>
> Glenn Washburn wrote:
> > My guess was that you wanted to unexport TMPDIR.
>
> Yes. The r
Hi,
i wrote:
> > I meanwhile forgot why i proposed
> > > +unset TMPDIR
> > but there was some theoretical reason for this ...
Glenn Washburn wrote:
> My guess was that you wanted to unexport TMPDIR.
Yes. The reason was that i wanted to limit the effect of exporting to
the run of grub-shell-l
On Mon, 23 Sep 2024 17:52:00 +0200
"Thomas Schmitt" wrote:
> Hi,
>
> The patches apply without complaints by "git am".
>
> But when i run (again as superuser, shudder):
>
> make check TESTS=grub_cmd_cryptomount
>
> i still get in /tmp the empty direcories /tmp/17*.LUKS2_*.
>
>
> Minor nit
Hi,
The patches apply without complaints by "git am".
But when i run (again as superuser, shudder):
make check TESTS=grub_cmd_cryptomount
i still get in /tmp the empty direcories /tmp/17*.LUKS2_*.
Minor nitpick:
> [PATCH 2/4] tests: Cleaup the cryptsetup script in grub_cmd_cryptomount
> un
Thomas Schmitt proposed variations on these fixes[1]. I've broken his
patch into several patches with improvements.
Glenn
[1] https://lore.kernel.org/all/9956308756800479...@scdbackup.webframe.org/
Glenn Washburn (4):
tests/util/grub-shell-luks-tester: Add missing line to create RET
variab
10 matches
Mail list logo
