Re: [PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode

> > Then I don't understand what > >  grub_video_set_mode ("1024x768;800x600;640x480", > GRUB_VIDEO_MODE_TYPE_PURE_TEXT) > > could mean.  Are you requesting a graphical mode or a text one?  If it's a > text one, why the list of resolutions? Actually it's grub_video_set_mode ("auto", GRUB_VIDEO_MOD

Re: [PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode

On Sun, Aug 23, 2009 at 12:58:46PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > Btw, please include a ChangeLog entry next time. > Ok. I will from now one but it will also mean a delay sending patches ;) I know it's a PITA, but consider that it needs to be done anyway. When you think about tha

Re: [PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode

On Sun, Aug 23, 2009 at 12:30 PM, Robert Millan wrote: > > I've only one comment, the rest looks fine. > > Btw, please include a ChangeLog entry next time. Ok. I will from now one but it will also mean a delay sending patches ;) > People usually associate "pure text" mode with a managed mode like 8

Re: [PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode

I've only one comment, the rest looks fine. Btw, please include a ChangeLog entry next time. On Sun, Aug 16, 2009 at 08:51:06PM +0200, Vladimir 'phcoder' Serbinenko wrote: > diff --git a/commands/videotest.c b/commands/videotest.c > index 6fe4b9b..07f61bd 100644 > --- a/commands/videotest.c > ++

Re: [PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode

On Fri, Aug 21, 2009 at 02:54:32PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 17, 2009 at 3:51 PM, Robert Millan wrote: > > On Sun, Aug 16, 2009 at 08:51:06PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > >> After discussion on IRC it revealed that hook-based approach is > >> un

Re: [PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode

On Mon, Aug 17, 2009 at 3:51 PM, Robert Millan wrote: > On Sun, Aug 16, 2009 at 08:51:06PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> After discussion on IRC it revealed that hook-based approach is >> unpracticable because number of available modes grows exponentially >> with every parameter av

Re: [PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode

On Sun, Aug 16, 2009 at 08:51:06PM +0200, Vladimir 'phcoder' Serbinenko wrote: > After discussion on IRC it revealed that hook-based approach is > unpracticable because number of available modes grows exponentially > with every parameter available. Here is the patch to change to > flag-based approa

[PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode

After discussion on IRC it revealed that hook-based approach is unpracticable because number of available modes grows exponentially with every parameter available. Here is the patch to change to flag-based approach -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.