Re: [PATCH 2/3] osdep/unix/getroot.c: Clean up redundant code

2024-01-25 Thread Vladimir 'phcoder' Serbinenko
Le mar. 23 janv. 2024, 17:44, Daniel Kiper a écrit : > Mate, > > Next time please respond to all people/addresses in the original > email... > > On Mon, Jan 22, 2024 at 02:09:38PM +, Mate Kukri wrote: > > Dear Alec, and grub-devel, > > > > I haven't checked the specific code in question, but

Re: [PATCH 2/3] osdep/unix/getroot.c: Clean up redundant code

2024-01-23 Thread Daniel Kiper
Mate, Next time please respond to all people/addresses in the original email... On Mon, Jan 22, 2024 at 02:09:38PM +, Mate Kukri wrote: > Dear Alec, and grub-devel, > > I haven't checked the specific code in question, but do we really want > to be removing such null-assignments? (Thinking abo

Re: [PATCH 2/3] osdep/unix/getroot.c: Clean up redundant code

2024-01-22 Thread Mate Kukri
Dear Alec, and grub-devel, I haven't checked the specific code in question, but do we really want to be removing such null-assignments? (Thinking about multiple patches exactly like this). In correct code, they are of course redundant by definition, however their intended purpose is that if the c

[PATCH 2/3] osdep/unix/getroot.c: Clean up redundant code

2024-01-19 Thread Alec Brown
In grub-core/osdep/unix/getroot.c, coverity spotted redundant code where the double pointer os_dev was being set to 0 and then being overwritten later without being used. Since this is unnecessary, we can remove the code that sets os_dev to 0. Fixes: CID 428875 Signed-off-by: Alec Brown --- gru