Re: [PATCH 2/4] Add grub_efi_get_variable

2012-02-08 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 08.02.2012 21:19, Matthew Garrett wrote: On Wed, Feb 08, 2012 at 09:09:23PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 08.02.2012 21:04, Matthew Garrett wrote: On Wed, Feb 08, 2012 at 08:55:39PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: + for (i=0; i<(int)grub_strle

Re: [PATCH 2/4] Add grub_efi_get_variable

2012-02-08 Thread Matthew Garrett
On Wed, Feb 08, 2012 at 09:09:23PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 08.02.2012 21:04, Matthew Garrett wrote: > >On Wed, Feb 08, 2012 at 08:55:39PM +0100, Vladimir 'φ-coder/phcoder' > >Serbinenko wrote: > >>>+ for (i=0; i<(int)grub_strlen((char *)var); i++) > >>>+var16

Re: [PATCH 2/4] Add grub_efi_get_variable

2012-02-08 Thread Matthew Garrett
On Wed, Feb 08, 2012 at 08:55:39PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > >+ for (i=0; i<(int)grub_strlen((char *)var); i++) > >+var16[i] = var[i]; > >+ var16[i] = '\0'; > >+ > We use grub_utf8_to_utf16. Also don't forget to multiply the malloc > length by GRUB_MAX_UTF16_PER_U

Re: [PATCH 2/4] Add grub_efi_get_variable

2012-02-08 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 08.02.2012 21:04, Matthew Garrett wrote: On Wed, Feb 08, 2012 at 08:55:39PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: + for (i=0; i<(int)grub_strlen((char *)var); i++) +var16[i] = var[i]; + var16[i] = '\0'; + We use grub_utf8_to_utf16. Also don't forget to multiply the mallo

Re: [PATCH 2/4] Add grub_efi_get_variable

2012-02-08 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 08.02.2012 17:51, Matthew Garrett wrote: Code may wish to obtain system information from EFI variables. Add support for making the platform call. --- ChangeLog|6 ++ grub-core/kern/efi/efi.c | 32 include/grub/efi/api.h |4 ++

[PATCH 2/4] Add grub_efi_get_variable

2012-02-08 Thread Matthew Garrett
Code may wish to obtain system information from EFI variables. Add support for making the platform call. --- ChangeLog|6 ++ grub-core/kern/efi/efi.c | 32 include/grub/efi/api.h |4 include/grub/efi/efi.h |3 ++- 4 files