Re: [PATCH V3] multiboot2: Implement quirk-modules-after-kernel

2020-04-17 Thread Lukasz Hawrylko
On Thu, 2020-04-16 at 21:18 +, Chen, Zide wrote: > > > > Hi Zide > > > > Above modification changes another behavior. Before your patch, lowest > > address for multiboot2 modules allocation was 0x0, now, when you removed > > #ifndef, it is set to 1MB even if quirk is not enabled. I think that

RE: [PATCH V3] multiboot2: Implement quirk-modules-after-kernel

2020-04-16 Thread Chen, Zide
> -Original Message- > From: Lukasz Hawrylko > Sent: Tuesday, April 7, 2020 2:20 AM > To: The development of GNU GRUB > Cc: Chen, Zide > Subject: Re: [PATCH V3] multiboot2: Implement quirk-modules-after-kernel > > On Mon, 2020-04-06 at 23:30 -0700, Zide Ch

RE: [PATCH V3] multiboot2: Implement quirk-modules-after-kernel

2020-04-07 Thread Chen, Zide
Hi Lukasz, > From: Lukasz Hawrylko > Sent: Tuesday, April 7, 2020 2:20 AM > To: The development of GNU GRUB > Cc: Chen, Zide > Subject: Re: [PATCH V3] multiboot2: Implement quirk-modules-after-kernel > > On Mon, 2020-04-06 at 23:30 -0700, Zide Chen wrote:

Re: [PATCH V3] multiboot2: Implement quirk-modules-after-kernel

2020-04-07 Thread Lukasz Hawrylko
On Mon, 2020-04-06 at 23:30 -0700, Zide Chen wrote: > @@ -392,11 +395,9 @@ grub_cmd_module (grub_command_t cmd __attribute__ > ((unused)), >if (! file) > return grub_errno; > > -#ifndef GRUB_USE_MULTIBOOT2 >lowest_addr = 0x10; > - if (grub_multiboot_quirks & GRUB_MULTIBOOT_QUIR

[PATCH V3] multiboot2: Implement quirk-modules-after-kernel

2020-04-06 Thread Zide Chen
In contrast to Mulitboot, in Mulitboot2, there is currently no way to control where to load the modules to. This could be a problem, e.g., the OS loaded by Multiboot2 needs to reserve low address for some particular purposes and not for loading modules. This patch implements the quirk quirk-module