Re: [PATCH resend] ofnet: Initialize structs in bootpath parser

2018-08-29 Thread Julian Andres Klode
On Wed, Aug 29, 2018 at 04:51:46PM +0800, Michael Chang wrote: > Actually I also have a similar patch posted one month ago for the very same > problem. > > https://lists.gnu.org/archive/html/grub-devel/2018-07/msg00103.html > > But as long as either way will do, I don't mind which one is going to

Re: [PATCH resend] ofnet: Initialize structs in bootpath parser

2018-08-29 Thread Michael Chang
Actually I also have a similar patch posted one month ago for the very same problem. https://lists.gnu.org/archive/html/grub-devel/2018-07/msg00103.html But as long as either way will do, I don't mind which one is going to be reviewed and eventually merged. :) On Thu, Aug 23, 2018 at 02:12:56PM

Re: [PATCH resend] ofnet: Initialize structs in bootpath parser

2018-08-24 Thread Paul Menzel
On 08/23/18 14:12, Julian Andres Klode wrote: > Code later on checks if variables inside the struct are > 0 to see if they have been set, like if there were addresses > in the bootpath. > > The variables were not initialized however, so the check > might suceed with uninitialized data, and a new

[PATCH resend] ofnet: Initialize structs in bootpath parser

2018-08-23 Thread Julian Andres Klode
Code later on checks if variables inside the struct are 0 to see if they have been set, like if there were addresses in the bootpath. The variables were not initialized however, so the check might suceed with uninitialized data, and a new interface with random addresses has been added. This caused