Re: [PATCH v1] fix kernel cmdline corruption

2020-03-31 Thread Olaf Hering
Am Tue, 31 Mar 2020 15:33:54 +0200 schrieb Daniel Kiper : > the patch cannot change the default Come on, this is obvious data corruption. Noone would want to opt-in into data corruption. Noone has shown a usecase for that odd commit from 2011. Apply the patch and be done with it. Olaf pgpwgNE

Re: [PATCH v1] fix kernel cmdline corruption

2020-03-31 Thread Daniel Kiper
On Mon, Mar 30, 2020 at 05:04:42PM +0800, Michael Chang wrote: > On Thu, Mar 26, 2020 at 10:33:01PM +0100, Daniel Kiper wrote: > > CC-ing Vladimir... > > > > On Thu, Mar 19, 2020 at 03:48:28PM +0800, Michael Chang wrote: > > > Hi Olaf, > > > > > > The patch rang a bell to me and eventually I figure

Re: [PATCH v1] fix kernel cmdline corruption

2020-03-30 Thread Michael Chang
On Thu, Mar 26, 2020 at 10:33:01PM +0100, Daniel Kiper wrote: > CC-ing Vladimir... > > On Thu, Mar 19, 2020 at 03:48:28PM +0800, Michael Chang wrote: > > Hi Olaf, > > > > The patch rang a bell to me and eventually I figured out that I had > > similar patch posted. > > > > https://lists.gnu.org/arc

Re: [PATCH v1] fix kernel cmdline corruption

2020-03-26 Thread Daniel Kiper
CC-ing Vladimir... On Thu, Mar 19, 2020 at 03:48:28PM +0800, Michael Chang wrote: > Hi Olaf, > > The patch rang a bell to me and eventually I figured out that I had > similar patch posted. > > https://lists.gnu.org/archive/html/grub-devel/2018-04/msg00038.html Yeah, it looks that it fell through

Re: [PATCH v1] fix kernel cmdline corruption

2020-03-19 Thread Olaf Hering
Am Thu, 19 Mar 2020 15:48:28 +0800 schrieb Michael Chang : > compatibilty issue. There can not possibly be any compat issue. Please go ahead and fix this bug. Olaf pgp_HXWiYCbGr.pgp Description: Digitale Signatur von OpenPGP ___ Grub-devel mailing l

Re: [PATCH v1] fix kernel cmdline corruption

2020-03-19 Thread Michael Chang
Hi Olaf, The patch rang a bell to me and eventually I figured out that I had similar patch posted. https://lists.gnu.org/archive/html/grub-devel/2018-04/msg00038.html In short, the issue is not only in the fix itself, but also to take care and provide a measure to avoid incompatible grub.cfg bef

[PATCH v1] fix kernel cmdline corruption

2020-03-18 Thread Olaf Hering
The functions grub_create_loader_cmdline and its sibling grub_loader_cmdline_size add extra, unexpected characters to the kernel cmdline. Both functions are supposed to copy each argv[] element verbatim. It is up to the caller of the kernel command ('linux' for example) to add desired quoting or es