Re: [PATCH v1] readd build dependency for startup_raw.S

2023-08-18 Thread Glenn Washburn
On Fri, 18 Aug 2023 16:33:19 +0200 Olaf Hering wrote: > Thu, 17 Aug 2023 15:21:44 -0500 Glenn Washburn : > > > On Thu, 17 Aug 2023 11:00:44 +0200 > > Olaf Hering wrote: > > > It is the result of my attempt to build just the required binaries, > > > without docs. > > > I came up with this: > >

Re: [PATCH v1] readd build dependency for startup_raw.S

2023-08-18 Thread Olaf Hering
Thu, 17 Aug 2023 15:21:44 -0500 Glenn Washburn : > On Thu, 17 Aug 2023 11:00:44 +0200 > Olaf Hering wrote: > > It is the result of my attempt to build just the required binaries, without > > docs. > > I came up with this: > > git clean -dffx > > bash bootstrap > > mkdir .b > > cd .b > >

Re: [PATCH v1] readd build dependency for startup_raw.S

2023-08-17 Thread Mike Gilbert
On Thu, Aug 17, 2023 at 4:21 PM Glenn Washburn wrote: > What version of automake are you using? I'm on 1.16.3-2 from Debian 11. > rs_decoder.h is ending up in BUILT_SOURCES, so it should get built > before anything is compiled. Can you check BUILT_SOURCES? For me > rs_decoder.h is included via a f

Re: [PATCH v1] readd build dependency for startup_raw.S

2023-08-17 Thread Glenn Washburn
On Thu, 17 Aug 2023 11:00:44 +0200 Olaf Hering wrote: > Wed, 16 Aug 2023 14:33:43 -0500 Glenn Washburn : > > > There's an extra 'd' in read in the subject line. > > Perhaps there is a better phrase to describe the act of adding something back? Ah, it needs a dash, "re-add". I misinterpreted yo

Re: [PATCH v1] readd build dependency for startup_raw.S

2023-08-17 Thread Glenn Washburn
On Wed, 16 Aug 2023 21:43:25 -0400 Mike Gilbert wrote: > On Wed, Aug 16, 2023 at 3:33 PM Glenn Washburn > wrote: > > > > Hi Olaf, > > > > There's an extra 'd' in read in the subject line. > > > > On Wed, 16 Aug 2023 11:55:01 +0200 > > Olaf Hering wrote: > > > > > startup_raw.S includes a genera

Re: [PATCH v1] readd build dependency for startup_raw.S

2023-08-17 Thread Olaf Hering
Wed, 16 Aug 2023 14:33:43 -0500 Glenn Washburn : > There's an extra 'd' in read in the subject line. Perhaps there is a better phrase to describe the act of adding something back? > I don't see this error when building any of the targets that I test. It is the result of my attempt to build just

Re: [PATCH v1] readd build dependency for startup_raw.S

2023-08-16 Thread Paul Menzel
Dear Glenn, Am 16.08.23 um 21:33 schrieb Glenn Washburn: There's an extra 'd' in read in the subject line. I think it’s supposed to be “re-add”, that means to add it back. Kind regards, Paul ___ Grub-devel mailing list Grub-devel@gnu.org https:

Re: [PATCH v1] readd build dependency for startup_raw.S

2023-08-16 Thread Mike Gilbert
On Wed, Aug 16, 2023 at 3:33 PM Glenn Washburn wrote: > > Hi Olaf, > > There's an extra 'd' in read in the subject line. > > On Wed, 16 Aug 2023 11:55:01 +0200 > Olaf Hering wrote: > > > startup_raw.S includes a generated file, and used to have a dependency > > in the Makefile to make sure the ge

Re: [PATCH v1] readd build dependency for startup_raw.S

2023-08-16 Thread Glenn Washburn
Hi Olaf, There's an extra 'd' in read in the subject line. On Wed, 16 Aug 2023 11:55:01 +0200 Olaf Hering wrote: > startup_raw.S includes a generated file, and used to have a dependency > in the Makefile to make sure the generated file exists prior > compilation. This dependency was removed, an

[PATCH v1] readd build dependency for startup_raw.S

2023-08-16 Thread Olaf Hering
startup_raw.S includes a generated file, and used to have a dependency in the Makefile to make sure the generated file exists prior compilation. This dependency was removed, and as a result building startup_raw.S randomly fails: ../../20230814T181249.4fdcb339b/grub-core/boot/i386/pc/startup_raw.S: