Re: [PATCH v2] cryptodisk: allow the user to retry failed passphrases

2024-04-27 Thread Forest
On Sat, 27 Apr 2024 04:18:29 -0500, Glenn Washburn wrote: >Its also a good idea to always CC Daniel on patches. They may more easily >get dropped otherwise. Thanks. Will do. >This does not account for tries_env not being a numeric value with no >garbage at the end or the empty string. I think th

Re: [PATCH v2] cryptodisk: allow the user to retry failed passphrases

2024-04-27 Thread Glenn Washburn
Its also a good idea to always CC Daniel on patches. They may more easily get dropped otherwise. On Sun, 07 Apr 2024 14:52:32 -0700 Forest wrote: > Changes since last rev: > - replace some spaces with tabs > - better explain the clearing of grub_errno > - let an environment variable override the

Re: [PATCH v2] cryptodisk: allow the user to retry failed passphrases

2024-04-27 Thread Glenn Washburn
On Mon, 22 Apr 2024 10:45:29 -0700 Forest wrote: > On Sun, 07 Apr 2024 14:52:32 -0700, Forest wrote: > > >Changes since last rev: > >- replace some spaces with tabs > >- better explain the clearing of grub_errno > >- let an environment variable override the number of passphrase tries > > As a n

Re: [PATCH v2] cryptodisk: allow the user to retry failed passphrases

2024-04-22 Thread Patrick Plenefisch
On Mon, Apr 22, 2024 at 1:48 PM Forest wrote: > On Sun, 07 Apr 2024 14:52:32 -0700, Forest wrote: > > >Changes since last rev: > >- replace some spaces with tabs > >- better explain the clearing of grub_errno > >- let an environment variable override the number of passphrase tries > > As a new co

Re: [PATCH v2] cryptodisk: allow the user to retry failed passphrases

2024-04-22 Thread Forest
On Sun, 07 Apr 2024 14:52:32 -0700, Forest wrote: >Changes since last rev: >- replace some spaces with tabs >- better explain the clearing of grub_errno >- let an environment variable override the number of passphrase tries As a new contributor, is there something I should do to ensure my patch i

[PATCH v2] cryptodisk: allow the user to retry failed passphrases

2024-04-07 Thread Forest
Changes since last rev: - replace some spaces with tabs - better explain the clearing of grub_errno - let an environment variable override the number of passphrase tries Thanks to Glenn Washburn for reviewing. Signed-off-by: Forest diff --git a/docs/grub.texi b/docs/grub.texi index a225f9a88..6