Re: [PATCH v2 1/1] Add support for grub-emu to kexec Linux menu entries

2022-08-23 Thread Robbie Harwood
Daniel Kiper writes: > On Tue, Aug 16, 2022 at 12:07:06PM -0400, Robbie Harwood wrote: >> Raymund Will writes: >> >>> Granted, the duplication of `--kexec` to signify "force it", might >>> as well be spelled out as `--force-kexec` (or something similar). >>> (But that change will provoke

Re: [PATCH v2 1/1] Add support for grub-emu to kexec Linux menu entries

2022-08-20 Thread Daniel Kiper
On Tue, Aug 16, 2022 at 12:07:06PM -0400, Robbie Harwood wrote: > Raymund Will writes: > > > Hi, > > > > please let me try to add a bit of context and explain three IMHO > > crucial points of the proposed patch. > > > > First, it is meant to work without any changes to config-files > > on

Re: [PATCH v2 1/1] Add support for grub-emu to kexec Linux menu entries

2022-08-16 Thread Robbie Harwood
Raymund Will writes: > Hi, > > please let me try to add a bit of context and explain three IMHO > crucial points of the proposed patch. > > First, it is meant to work without any changes to config-files > on 'linux'-systems, simply by calling `grub-emu --kexec`. > And, called this way, it

Re: [PATCH v2 1/1] Add support for grub-emu to kexec Linux menu entries

2022-08-15 Thread Raymund Will
Hi, please let me try to add a bit of context and explain three IMHO crucial points of the proposed patch. First, it is meant to work without any changes to config-files on 'linux'-systems, simply by calling `grub-emu --kexec`. And, called this way, it actually uses `systemctl kexec` exclusively

Re: [PATCH v2 1/1] Add support for grub-emu to kexec Linux menu entries

2022-08-11 Thread Daniel Kiper
On Mon, Aug 08, 2022 at 11:43:15PM +0200, Vladimir 'phcoder' Serbinenko wrote: > I like it in general however I had a comment: in future GRUB could be able to > do the same through second approach: load a constructed kexec blob with all > the > parts. This would allow to e.g. kexec FreeBSD. This

Re: [PATCH v2 1/1] Add support for grub-emu to kexec Linux menu entries

2022-08-11 Thread Daniel Kiper
On Mon, Aug 08, 2022 at 02:58:06PM -0400, Robbie Harwood wrote: > Daniel Kiper writes: > > > On Tue, Jul 19, 2022 at 04:39:34PM -0400, Robbie Harwood wrote: > > > >> +static grub_err_t > >> +grub_linux_boot (void) > >> +{ > >> + grub_err_t rc = GRUB_ERR_NONE; > >> + char *initrd_param; > >> +

Re: [PATCH v2 1/1] Add support for grub-emu to kexec Linux menu entries

2022-08-11 Thread Robbie Harwood
"Vladimir 'phcoder' Serbinenko" writes: > I like it in general however I had a comment: in future GRUB could be able > to do the same through second approach: load a constructed kexec blob with > all the parts. This would allow to e.g. kexec FreeBSD. This didn't have to > be implemented now.

Re: [PATCH v2 1/1] Add support for grub-emu to kexec Linux menu entries

2022-08-08 Thread Vladimir 'phcoder' Serbinenko
I like it in general however I had a comment: in future GRUB could be able to do the same through second approach: load a constructed kexec blob with all the parts. This would allow to e.g. kexec FreeBSD. This didn't have to be implemented now. Meanwhile can we use "kexec" as command name? It's

Re: [PATCH v2 1/1] Add support for grub-emu to kexec Linux menu entries

2022-08-08 Thread Robbie Harwood
Daniel Kiper writes: > On Tue, Jul 19, 2022 at 04:39:34PM -0400, Robbie Harwood wrote: > >> +static grub_err_t >> +grub_linux_boot (void) >> +{ >> + grub_err_t rc = GRUB_ERR_NONE; >> + char *initrd_param; >> + const char *kexec[] = { "kexec", "-l", kernel_path, boot_cmdline, NULL, >> NULL };

Re: [PATCH v2 1/1] Add support for grub-emu to kexec Linux menu entries

2022-08-03 Thread Daniel Kiper
On Tue, Jul 19, 2022 at 04:39:34PM -0400, Robbie Harwood wrote: > From: Raymund Will > > The GRUB emulator is used as a debugging utility but it could also be used > as a user-space bootloader if there is support to boot an operating system. > > The Linux kernel is already able to (re)boot

[PATCH v2 1/1] Add support for grub-emu to kexec Linux menu entries

2022-07-19 Thread Robbie Harwood
From: Raymund Will The GRUB emulator is used as a debugging utility but it could also be used as a user-space bootloader if there is support to boot an operating system. The Linux kernel is already able to (re)boot another kernel via the kexec boot mechanism. So the grub-emu tool could rely on