The arm relocation code has a manual special case for EFI binaries to
add the natural alignment to its own relocation awareness.

Since commit a51f953f4ee87 ("mkimage: Align efi sections on 4k
boundary") we changed that alignment from 0x400 to 0x1000 bytes. Reflect
the change in that branch that we forgot as well.

This fixes running 32bit arm grub efi binaries for me again.

Fixes: a51f953f4ee87 ("mkimage: Align efi sections on 4k boundary")
Reported-by: Heinrich Schuchardt <xypron.g...@gmx.de>
Reported-by: Steve McIntyre <st...@einval.com>
Signed-off-by: Alexander Graf <ag...@csgraf.de>
Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com>
Tested-by: Julien ROBIN <julien.robi...@free.fr>
---
 util/grub-mkimagexx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/grub-mkimagexx.c b/util/grub-mkimagexx.c
index 470fbf4dd..bc087c2b5 100644
--- a/util/grub-mkimagexx.c
+++ b/util/grub-mkimagexx.c
@@ -1137,7 +1137,7 @@ SUFFIX (relocate_addrs) (Elf_Ehdr *e, struct 
section_metadata *smd,
                                       (int) sym_addr, (int) sym_addr);
                       /* Data will be naturally aligned */
                       if (image_target->id == IMAGE_EFI)
-                        sym_addr += 0x400;
+                        sym_addr += GRUB_PE32_SECTION_ALIGNMENT;
                       *target = grub_host_to_target32 (grub_target_to_host32 
(*target) + sym_addr);
                     }
                     break;
-- 
2.16.4


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to