Re: [PATCH v2 5/6] multiboot2: Add support for relocatable images

2015-11-12 Thread Daniel Kiper
On Thu, Nov 12, 2015 at 02:26:21PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 12.11.2015 14:15, Daniel Kiper wrote: > > On Tue, Nov 10, 2015 at 04:23:46PM +0100, Vladimir 'phcoder' Serbinenko > > wrote: > >> Le 10 nov. 2015 3:52 PM, "Daniel Kiper" a écrit : > >>> On Mon, Nov 09, 20

Re: [PATCH v2 5/6] multiboot2: Add support for relocatable images

2015-11-12 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 12.11.2015 14:15, Daniel Kiper wrote: > On Tue, Nov 10, 2015 at 04:23:46PM +0100, Vladimir 'phcoder' Serbinenko wrote: >> Le 10 nov. 2015 3:52 PM, "Daniel Kiper" a écrit : >>> On Mon, Nov 09, 2015 at 09:08:35PM +0100, Vladimir 'φ-coder/phcoder' >> Serbinenko wrote: On 20.07.2015 16:35, Dan

Re: [PATCH v2 5/6] multiboot2: Add support for relocatable images

2015-11-10 Thread Daniel Kiper
On Mon, Nov 09, 2015 at 09:08:35PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 20.07.2015 16:35, Daniel Kiper wrote: > > Signed-off-by: Daniel Kiper > What is handling the actual relocation? In Xen we get image offset from GRUB2 and using this value we calculate relative addresses.

Re: [PATCH v2 5/6] multiboot2: Add support for relocatable images

2015-11-09 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 20.07.2015 16:35, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper What is handling the actual relocation? Why doesn't this patch include support for ELF relocations? > --- > grub-core/loader/i386/multiboot_mbi.c |6 ++-- > grub-core/loader/multiboot.c | 12 +-- > grub-core

Re: [PATCH v2 5/6] multiboot2: Add support for relocatable images

2015-08-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:35:53PM +0200, Daniel Kiper wrote: This parts needs a bit of details I think. As in why can't the ELF note that is present in the binary be satisfied. Or under what conditions would the existing code not work? > Signed-off-by: Daniel Kiper > --- > grub-core/loader/i3

[PATCH v2 5/6] multiboot2: Add support for relocatable images

2015-07-20 Thread Daniel Kiper
Signed-off-by: Daniel Kiper --- grub-core/loader/i386/multiboot_mbi.c |6 ++-- grub-core/loader/multiboot.c | 12 +-- grub-core/loader/multiboot_elfxx.c| 28 +++ grub-core/loader/multiboot_mbi2.c | 63 + include/grub/multi