Re: [PATCH v3] grub-install: Delay copying files to {grubdir, platdir} after install_device was validated.

2023-11-23 Thread Mate Kukri
I believe this to be accidental, as the patch was developed in two steps with one hunk added later. I believe it shouldn't make a difference in functionality, but it is unnecessary and I will send patch v4 tomorrow with the hunks in the original order. On Thu, Nov 23, 2023 at 6:36 PM Daniel Kiper

Re: [PATCH v3] grub-install: Delay copying files to {grubdir, platdir} after install_device was validated.

2023-11-23 Thread Daniel Kiper
On Wed, Nov 22, 2023 at 11:53:13AM +, Mate Kukri wrote: > Previously grub-install copied modules to grubdir before doing any validation > on > the install_device. > > When grub-install was called with an invalid install_device, modules > were already copied to /boot before it found out and was

[PATCH v3] grub-install: Delay copying files to {grubdir, platdir} after install_device was validated.

2023-11-22 Thread Mate Kukri
Previously grub-install copied modules to grubdir before doing any validation on the install_device. When grub-install was called with an invalid install_device, modules were already copied to /boot before it found out and was forced to rely on atexit rollback. This patch delays copying the modul