Re: [Xen-devel] [PATCH v3 02/10] xen: reduce number of global variables in xen loader

2016-02-19 Thread Lennart Sorensen
On Fri, Feb 19, 2016 at 05:59:27AM +0100, Juergen Gross wrote: > On 18/02/16 18:00, Lennart Sorensen wrote: > > On Thu, Feb 18, 2016 at 11:34:49AM +0100, Juergen Gross wrote: > >> On 18/02/16 11:22, Daniel Kiper wrote: > >>> On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote: > The

Re: [Xen-devel] [PATCH v3 02/10] xen: reduce number of global variables in xen loader

2016-02-18 Thread Juergen Gross
On 18/02/16 18:00, Lennart Sorensen wrote: > On Thu, Feb 18, 2016 at 11:34:49AM +0100, Juergen Gross wrote: >> On 18/02/16 11:22, Daniel Kiper wrote: >>> On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote: The loader for xen paravirtualized environment is using lots of global v

Re: [PATCH v3 02/10] xen: reduce number of global variables in xen loader

2016-02-18 Thread Daniel Kiper
On Thu, Feb 18, 2016 at 11:34:49AM +0100, Juergen Gross wrote: > On 18/02/16 11:22, Daniel Kiper wrote: > > On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote: > >> The loader for xen paravirtualized environment is using lots of global > >> variables. Reduce the number by making them eit

Re: [PATCH v3 02/10] xen: reduce number of global variables in xen loader

2016-02-18 Thread Lennart Sorensen
On Thu, Feb 18, 2016 at 11:34:49AM +0100, Juergen Gross wrote: > On 18/02/16 11:22, Daniel Kiper wrote: > > On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote: > >> The loader for xen paravirtualized environment is using lots of global > >> variables. Reduce the number by making them eit

Re: [PATCH v3 02/10] xen: reduce number of global variables in xen loader

2016-02-18 Thread Juergen Gross
On 18/02/16 11:22, Daniel Kiper wrote: > On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote: >> The loader for xen paravirtualized environment is using lots of global >> variables. Reduce the number by making them either local or by putting >> them into a single state structure. >> >> Si

Re: [PATCH v3 02/10] xen: reduce number of global variables in xen loader

2016-02-18 Thread Daniel Kiper
On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote: > The loader for xen paravirtualized environment is using lots of global > variables. Reduce the number by making them either local or by putting > them into a single state structure. > > Signed-off-by: Juergen Gross Just two nitpicks

[PATCH v3 02/10] xen: reduce number of global variables in xen loader

2016-02-17 Thread Juergen Gross
The loader for xen paravirtualized environment is using lots of global variables. Reduce the number by making them either local or by putting them into a single state structure. Signed-off-by: Juergen Gross --- grub-core/loader/i386/xen.c | 259 +++- 1 fil