Re: [PATCH v3 1/3] Allow explicit module dependencies

2023-12-11 Thread Oliver Steffen
Quoting Julian Andres Klode (2023-12-08 18:29:52) > On Fri, Dec 08, 2023 at 01:20:37PM +0100, Daniel Kiper wrote: > > On Wed, Dec 06, 2023 at 05:39:53PM +0100, Daniel Kiper wrote: > > > On Wed, Dec 06, 2023 at 04:39:29PM +0100, Olaf Hering wrote: > > > > Wed, 6 Dec 2023 16:24:53 +0100 Daniel Kiper

Re: [PATCH v3 1/3] Allow explicit module dependencies

2023-12-08 Thread Julian Andres Klode
On Fri, Dec 08, 2023 at 01:20:37PM +0100, Daniel Kiper wrote: > On Wed, Dec 06, 2023 at 05:39:53PM +0100, Daniel Kiper wrote: > > On Wed, Dec 06, 2023 at 04:39:29PM +0100, Olaf Hering wrote: > > > Wed, 6 Dec 2023 16:24:53 +0100 Daniel Kiper : > > > > > > > Could you provide us exact steps to reprod

Re: [PATCH v3 1/3] Allow explicit module dependencies

2023-12-08 Thread Daniel Kiper
On Wed, Dec 06, 2023 at 05:39:53PM +0100, Daniel Kiper wrote: > On Wed, Dec 06, 2023 at 04:39:29PM +0100, Olaf Hering wrote: > > Wed, 6 Dec 2023 16:24:53 +0100 Daniel Kiper : > > > > > Could you provide us exact steps to reproduce the problem? > > > > Something like this? > > > > mkdir .b > > cd $_

Re: [PATCH v3 1/3] Allow explicit module dependencies

2023-12-06 Thread Daniel Kiper
On Wed, Dec 06, 2023 at 04:39:29PM +0100, Olaf Hering wrote: > Wed, 6 Dec 2023 16:24:53 +0100 Daniel Kiper : > > > Could you provide us exact steps to reproduce the problem? > > Something like this? > > mkdir .b > cd $_ > ../grub-src-dir/configure [options] Ugh, yeah, the file is missing in this c

Re: [PATCH v3 1/3] Allow explicit module dependencies

2023-12-06 Thread Olaf Hering
Wed, 6 Dec 2023 16:24:53 +0100 Daniel Kiper : > Could you provide us exact steps to reproduce the problem? Something like this? mkdir .b cd $_ ../grub-src-dir/configure [options] A brief look at the sources indicates the new file could be generated during build, with "echo content > $@". Ola

Re: [PATCH v3 1/3] Allow explicit module dependencies

2023-12-06 Thread Daniel Kiper
Hi Olaf, On Wed, Dec 06, 2023 at 09:19:06AM +0100, Olaf Hering wrote: > Thu, 16 Nov 2023 16:37:38 +0100 Oliver Steffen : > > > +syminfo.lst: gensyminfo.sh kernel_syms.lst extra_deps.lst $(MODULE_FILES) > > + cat kernel_syms.lst extra_deps.lst > $@.new > > There are rules to create gensyminfo.sh

Re: [PATCH v3 1/3] Allow explicit module dependencies

2023-12-06 Thread Olaf Hering
Thu, 16 Nov 2023 16:37:38 +0100 Oliver Steffen : > +syminfo.lst: gensyminfo.sh kernel_syms.lst extra_deps.lst $(MODULE_FILES) > + cat kernel_syms.lst extra_deps.lst > $@.new There are rules to create gensyminfo.sh and kernel_syms.lst, but there is no rule to create extra_deps.lst. As a resul

[PATCH v3 1/3] Allow explicit module dependencies

2023-11-16 Thread Oliver Steffen
The build system deduces inter-module dependencies from the symbols required and exported by the modules. This works well, except for some rare cases where the dependency is indirect or hidden. A module might not make use of any function of some other module, but still expect its functionality to b