Re: [PATCH v5 1/2] misc: Add cast in grub_strncasecmp() to drop sign when calling grub_tolower()

2022-08-19 Thread Daniel Kiper
On Thu, Aug 11, 2022 at 12:48:42PM -0500, Glenn Washburn wrote: > Note this cast was fixed in grub_strcasecmp() in commit ce41ab7aab > (* grub-core/kern/misc.c (grub_strcmp): Use unsigned comparison as per > common usage and preffered in several parts of code.), but this commit > omitted fixing it

[PATCH v5 1/2] misc: Add cast in grub_strncasecmp() to drop sign when calling grub_tolower()

2022-08-11 Thread Glenn Washburn
Note this cast was fixed in grub_strcasecmp() in commit ce41ab7aab (* grub-core/kern/misc.c (grub_strcmp): Use unsigned comparison as per common usage and preffered in several parts of code.), but this commit omitted fixing it in grub_strncasecmp(). Signed-off-by: Glenn Washburn ---